From: <naomi.chu@mediatek.com> To: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, Bart Van Assche <bvanassche@acm.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Manivannan Sadhasivam <mani@kernel.org>, Asutosh Das <quic_asutoshd@quicinc.com>, Can Guo <quic_cang@quicinc.com> Cc: <wsd_upstream@mediatek.com>, <peter.wang@mediatek.com>, <casper.li@mediatek.com>, <powen.kao@mediatek.com>, <alice.chao@mediatek.com>, <naomi.chu@mediatek.com>, <chun-hung.wu@mediatek.com>, <cc.chou@mediatek.com>, <eddie.huang@mediatek.com> Subject: [PATCH v3 1/1] ufs: core: Expand MCQ queue slot to DeviceQueueDepth + 1 Date: Thu, 2 Nov 2023 13:24:24 +0800 [thread overview] Message-ID: <20231102052426.12006-2-naomi.chu@mediatek.com> (raw) In-Reply-To: <20231102052426.12006-1-naomi.chu@mediatek.com> From: Naomi Chu <naomi.chu@mediatek.com> The UFSHCI 4.0 specification mandates that there should always be at least one empty slot in each queue for distinguishing between full and empty states. Enlarge the `hwq->max_entries` to `DeviceQueueDepth +1` to allow UFSHCI 4.0 controllers to fully utilize MCQ queue slots. Fixes: 4682abfae2eb ("scsi: ufs: core: mcq: Allocate memory for MCQ mode") Signed-off-by: Naomi Chu <naomi.chu@mediatek.com> --- drivers/ufs/core/ufs-mcq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c index 2ba8ec254dce..5c75ab9d6bb5 100644 --- a/drivers/ufs/core/ufs-mcq.c +++ b/drivers/ufs/core/ufs-mcq.c @@ -436,7 +436,7 @@ int ufshcd_mcq_init(struct ufs_hba *hba) for (i = 0; i < hba->nr_hw_queues; i++) { hwq = &hba->uhq[i]; - hwq->max_entries = hba->nutrs; + hwq->max_entries = hba->nutrs + 1; spin_lock_init(&hwq->sq_lock); spin_lock_init(&hwq->cq_lock); mutex_init(&hwq->sq_mutex); -- 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: <naomi.chu@mediatek.com> To: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, Bart Van Assche <bvanassche@acm.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Manivannan Sadhasivam <mani@kernel.org>, Asutosh Das <quic_asutoshd@quicinc.com>, Can Guo <quic_cang@quicinc.com> Cc: <wsd_upstream@mediatek.com>, <peter.wang@mediatek.com>, <casper.li@mediatek.com>, <powen.kao@mediatek.com>, <alice.chao@mediatek.com>, <naomi.chu@mediatek.com>, <chun-hung.wu@mediatek.com>, <cc.chou@mediatek.com>, <eddie.huang@mediatek.com> Subject: [PATCH v3 1/1] ufs: core: Expand MCQ queue slot to DeviceQueueDepth + 1 Date: Thu, 2 Nov 2023 13:24:24 +0800 [thread overview] Message-ID: <20231102052426.12006-2-naomi.chu@mediatek.com> (raw) In-Reply-To: <20231102052426.12006-1-naomi.chu@mediatek.com> From: Naomi Chu <naomi.chu@mediatek.com> The UFSHCI 4.0 specification mandates that there should always be at least one empty slot in each queue for distinguishing between full and empty states. Enlarge the `hwq->max_entries` to `DeviceQueueDepth +1` to allow UFSHCI 4.0 controllers to fully utilize MCQ queue slots. Fixes: 4682abfae2eb ("scsi: ufs: core: mcq: Allocate memory for MCQ mode") Signed-off-by: Naomi Chu <naomi.chu@mediatek.com> --- drivers/ufs/core/ufs-mcq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c index 2ba8ec254dce..5c75ab9d6bb5 100644 --- a/drivers/ufs/core/ufs-mcq.c +++ b/drivers/ufs/core/ufs-mcq.c @@ -436,7 +436,7 @@ int ufshcd_mcq_init(struct ufs_hba *hba) for (i = 0; i < hba->nr_hw_queues; i++) { hwq = &hba->uhq[i]; - hwq->max_entries = hba->nutrs; + hwq->max_entries = hba->nutrs + 1; spin_lock_init(&hwq->sq_lock); spin_lock_init(&hwq->cq_lock); mutex_init(&hwq->sq_mutex); -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-02 5:26 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-02 5:24 [PATCH v3 0/1] ufs: core: Expand MCQ queue slot to DeviceQueueDepth + 1 naomi.chu 2023-11-02 5:24 ` naomi.chu 2023-11-02 5:24 ` naomi.chu [this message] 2023-11-02 5:24 ` [PATCH v3 1/1] " naomi.chu 2023-11-02 13:23 ` Stanley Chu 2023-11-02 13:23 ` Stanley Chu 2023-11-02 16:37 ` Manivannan Sadhasivam 2023-11-02 16:37 ` Manivannan Sadhasivam 2023-11-02 19:15 ` Bart Van Assche 2023-11-02 19:15 ` Bart Van Assche 2023-11-02 19:16 ` Bart Van Assche 2023-11-02 19:16 ` Bart Van Assche 2023-11-03 2:19 ` Peter Wang (王信友) 2023-11-03 2:19 ` Peter Wang (王信友) 2023-11-03 2:35 ` Chun-Hung Wu (巫駿宏) 2023-11-03 2:35 ` Chun-Hung Wu (巫駿宏) 2023-11-09 2:35 ` Martin K. Petersen 2023-11-09 2:35 ` Martin K. Petersen 2023-11-15 15:13 ` [PATCH v3 0/1] " Martin K. Petersen 2023-11-15 15:13 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231102052426.12006-2-naomi.chu@mediatek.com \ --to=naomi.chu@mediatek.com \ --cc=alice.chao@mediatek.com \ --cc=alim.akhtar@samsung.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=avri.altman@wdc.com \ --cc=bvanassche@acm.org \ --cc=casper.li@mediatek.com \ --cc=cc.chou@mediatek.com \ --cc=chun-hung.wu@mediatek.com \ --cc=eddie.huang@mediatek.com \ --cc=jejb@linux.ibm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=mani@kernel.org \ --cc=martin.petersen@oracle.com \ --cc=matthias.bgg@gmail.com \ --cc=peter.wang@mediatek.com \ --cc=powen.kao@mediatek.com \ --cc=quic_asutoshd@quicinc.com \ --cc=quic_cang@quicinc.com \ --cc=wsd_upstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.