All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonas Karlman <jonas@kwiboo.se>
Subject: [PATCH v3 06/16] drm/bridge: tpd12s015: Convert to platform remove callback returning void
Date: Thu,  2 Nov 2023 17:56:47 +0100	[thread overview]
Message-ID: <20231102165640.3307820-24-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20231102165640.3307820-18-u.kleine-koenig@pengutronix.de>

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/gpu/drm/bridge/ti-tpd12s015.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-tpd12s015.c b/drivers/gpu/drm/bridge/ti-tpd12s015.c
index b588fea12502..f9fb35683a27 100644
--- a/drivers/gpu/drm/bridge/ti-tpd12s015.c
+++ b/drivers/gpu/drm/bridge/ti-tpd12s015.c
@@ -179,13 +179,11 @@ static int tpd12s015_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int tpd12s015_remove(struct platform_device *pdev)
+static void tpd12s015_remove(struct platform_device *pdev)
 {
 	struct tpd12s015_device *tpd = platform_get_drvdata(pdev);
 
 	drm_bridge_remove(&tpd->bridge);
-
-	return 0;
 }
 
 static const struct of_device_id tpd12s015_of_match[] = {
@@ -197,7 +195,7 @@ MODULE_DEVICE_TABLE(of, tpd12s015_of_match);
 
 static struct platform_driver tpd12s015_driver = {
 	.probe	= tpd12s015_probe,
-	.remove = tpd12s015_remove,
+	.remove_new = tpd12s015_remove,
 	.driver	= {
 		.name	= "tpd12s015",
 		.of_match_table = tpd12s015_of_match,
-- 
2.42.0


  parent reply	other threads:[~2023-11-02 16:57 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 16:56 [PATCH v3 00/16] drm: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-02 16:56 ` Uwe Kleine-König
2023-11-02 16:56 ` Uwe Kleine-König
2023-11-02 16:56 ` [Nouveau] " Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 01/16] drm/bridge: tpd12s015: Drop buggy __exit annotation for remove function Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 02/16] drm/arcpgu: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 03/16] drm/armada: " Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 04/16] drm/bridge: cdns-mhdp8546: Improve error reporting in remove callback Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 05/16] drm/bridge: cdns-mhdp8546: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-02 16:56 ` Uwe Kleine-König [this message]
2023-11-02 16:56 ` [PATCH v3 07/16] drm/etnaviv: " Uwe Kleine-König
2023-11-02 17:05   ` Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 08/16] drm/exynos: " Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-08  4:16   ` Inki Dae
2023-11-08  7:54     ` Uwe Kleine-König
2023-11-08  7:54       ` Uwe Kleine-König
2023-11-08  7:54       ` Uwe Kleine-König
2023-11-28 16:55       ` Uwe Kleine-König
2023-11-28 16:55         ` Uwe Kleine-König
2023-11-28 16:55         ` Uwe Kleine-König
2023-11-28 17:04         ` Krzysztof Kozlowski
2023-11-28 17:04           ` Krzysztof Kozlowski
2023-11-28 17:04           ` Krzysztof Kozlowski
2023-12-07  2:37         ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-12-07  2:37           ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-12-07  2:37           ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-12-07  8:03           ` Uwe Kleine-König
2023-12-07  8:03             ` Uwe Kleine-König
2023-12-07  8:03             ` Uwe Kleine-König
2023-12-12  5:38             ` Inki Dae
2023-12-12  5:38               ` Inki Dae
2023-12-12  5:38               ` Inki Dae
2023-11-02 16:56 ` [PATCH v3 09/16] drm/imx/dcss: " Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 10/16] drm/imx: lcdc: " Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 11/16] drm/kmb: " Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 12/16] drm/mediatek: " Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 13/16] drm/meson: " Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56   ` Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 14/16] drm/nouveau: " Uwe Kleine-König
2023-11-02 16:56   ` [Nouveau] " Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 15/16] drm/sprd: " Uwe Kleine-König
2023-11-02 16:56 ` [PATCH v3 16/16] drm/tilcdc: " Uwe Kleine-König
2023-11-03  7:58   ` Tomi Valkeinen
2023-11-28 16:49     ` Uwe Kleine-König
2023-11-28 19:54     ` sarha
2023-12-04 17:04       ` Uwe Kleine-König
2023-11-20 12:05 ` [PATCH v3 00/16] drm: " Uwe Kleine-König
2023-11-20 12:05   ` Uwe Kleine-König
2023-11-20 12:05   ` Uwe Kleine-König
2023-11-20 12:05   ` [Nouveau] " Uwe Kleine-König
2023-11-21  8:21   ` Thomas Zimmermann
2023-11-21  8:21     ` Thomas Zimmermann
2023-11-21  8:21     ` Thomas Zimmermann
2023-11-21  8:21     ` [Nouveau] " Thomas Zimmermann
2023-11-28 19:47 ` [PATCH v3 16/16] drm/tilcdc: " jyri.sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102165640.3307820-24-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.