All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Helge Deller <deller@gmx.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, kernel@pengutronix.de
Subject: [PATCH 08/22] fb: omapfb/opa362: Don't put .remove() in .exit.text and drop suppress_bind_attrs
Date: Tue,  7 Nov 2023 10:17:49 +0100	[thread overview]
Message-ID: <20231107091740.3924258-9-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20231107091740.3924258-1-u.kleine-koenig@pengutronix.de>

On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410: section mismatch in reference: tfp410_driver+0x4 (section: .data) -> tfp410_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c b/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c
index dd29dc5c77ec..866d71489358 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c
@@ -231,7 +231,7 @@ static int opa362_probe(struct platform_device *pdev)
 	return r;
 }
 
-static int __exit opa362_remove(struct platform_device *pdev)
+static int opa362_remove(struct platform_device *pdev)
 {
 	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
 	struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -260,11 +260,10 @@ MODULE_DEVICE_TABLE(of, opa362_of_match);
 
 static struct platform_driver opa362_driver = {
 	.probe	= opa362_probe,
-	.remove	= __exit_p(opa362_remove),
+	.remove	= opa362_remove,
 	.driver	= {
 		.name	= "amplifier-opa362",
 		.of_match_table = opa362_of_match,
-		.suppress_bind_attrs = true,
 	},
 };
 
-- 
2.42.0


WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Helge Deller <deller@gmx.de>
Cc: kernel@pengutronix.de, linux-omap@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 08/22] fb: omapfb/opa362: Don't put .remove() in .exit.text and drop suppress_bind_attrs
Date: Tue,  7 Nov 2023 10:17:49 +0100	[thread overview]
Message-ID: <20231107091740.3924258-9-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20231107091740.3924258-1-u.kleine-koenig@pengutronix.de>

On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410: section mismatch in reference: tfp410_driver+0x4 (section: .data) -> tfp410_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c b/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c
index dd29dc5c77ec..866d71489358 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c
@@ -231,7 +231,7 @@ static int opa362_probe(struct platform_device *pdev)
 	return r;
 }
 
-static int __exit opa362_remove(struct platform_device *pdev)
+static int opa362_remove(struct platform_device *pdev)
 {
 	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
 	struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -260,11 +260,10 @@ MODULE_DEVICE_TABLE(of, opa362_of_match);
 
 static struct platform_driver opa362_driver = {
 	.probe	= opa362_probe,
-	.remove	= __exit_p(opa362_remove),
+	.remove	= opa362_remove,
 	.driver	= {
 		.name	= "amplifier-opa362",
 		.of_match_table = opa362_of_match,
-		.suppress_bind_attrs = true,
 	},
 };
 
-- 
2.42.0


  parent reply	other threads:[~2023-11-07  9:20 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07  9:17 [PATCH 00/22] fb: handle remove callbacks in .exit.text and convert to .remove_new Uwe Kleine-König
2023-11-07  9:17 ` Uwe Kleine-König
2023-11-07  9:17 ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 01/22] fb: amifb: Stop using platform_driver_probe() Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-08 21:06   ` Geert Uytterhoeven
2023-11-08 21:06     ` Geert Uytterhoeven
2023-11-08 21:32     ` Helge Deller
2023-11-08 21:32       ` Helge Deller
2023-11-08 21:34       ` Geert Uytterhoeven
2023-11-08 21:34         ` Geert Uytterhoeven
2023-11-09 20:31         ` Helge Deller
2023-11-09 20:31           ` Helge Deller
2023-11-07  9:17 ` [PATCH 02/22] fb: atmel_lcdfb: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07 19:20   ` kernel test robot
2023-11-07 20:01   ` Uwe Kleine-König
2023-11-07 20:01     ` Uwe Kleine-König
2023-11-07 20:01     ` Uwe Kleine-König
2023-11-07 20:37     ` Helge Deller
2023-11-07 20:37       ` Helge Deller
2023-11-07 20:37       ` Helge Deller
2023-11-08 18:48   ` Nathan Chancellor
2023-11-08 18:48     ` Nathan Chancellor
2023-11-08 18:48     ` Nathan Chancellor
2023-11-08 20:27     ` Helge Deller
2023-11-08 20:27       ` Helge Deller
2023-11-08 20:27       ` Helge Deller
2023-11-08 21:00     ` Uwe Kleine-König
2023-11-08 21:00       ` Uwe Kleine-König
2023-11-08 21:24       ` Helge Deller
2023-11-08 21:24         ` Helge Deller
2023-11-08 21:24         ` Helge Deller
2023-11-08 21:52         ` Uwe Kleine-König
2023-11-08 21:52           ` Uwe Kleine-König
2023-11-08 21:52           ` Uwe Kleine-König
2023-11-08 21:57           ` Helge Deller
2023-11-08 21:57             ` Helge Deller
2023-11-08 21:57             ` Helge Deller
2023-11-09  6:24             ` Uwe Kleine-König
2023-11-09  6:24               ` Uwe Kleine-König
2023-11-09  9:55               ` Helge Deller
2023-11-09  9:55                 ` Helge Deller
2023-11-09 10:20                 ` Nicolas Ferre
2023-11-09 10:20                   ` Nicolas Ferre
2023-11-09 10:20                   ` Nicolas Ferre
2023-11-09 10:32                 ` Uwe Kleine-König
2023-11-09 10:32                   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 03/22] fb: omapfb/analog-tv: Don't put .remove() in .exit.text and drop suppress_bind_attrs Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 04/22] fb: omapfb/dpi: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 05/22] fb: omapfb/dsi-cm: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 06/22] fb: omapfb/dvi: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 07/22] fb: omapfb/hdmi: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` Uwe Kleine-König [this message]
2023-11-07  9:17   ` [PATCH 08/22] fb: omapfb/opa362: " Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 09/22] fb: omapfb/sharp-ls037v7dw01: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 10/22] fb: omapfb/tfp410: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 11/22] fb: omapfb/tpd12s015: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 12/22] fb: amifb: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 13/22] fb: atmel_lcdfb: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 14/22] fb: omapfb/analog-tv: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 15/22] fb: omapfb/dpi: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 16/22] fb: omapfb/dsi-cm: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 17/22] fb: omapfb/dvi: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:17 ` [PATCH 18/22] fb: omapfb/hdmi: " Uwe Kleine-König
2023-11-07  9:17   ` Uwe Kleine-König
2023-11-07  9:18 ` [PATCH 19/22] fb: omapfb/opa362: " Uwe Kleine-König
2023-11-07  9:18   ` Uwe Kleine-König
2023-11-07  9:18 ` [PATCH 20/22] fb: omapfb/sharp-ls037v7dw01: " Uwe Kleine-König
2023-11-07  9:18   ` Uwe Kleine-König
2023-11-07  9:18 ` [PATCH 21/22] fb: omapfb/tfp410: " Uwe Kleine-König
2023-11-07  9:18   ` Uwe Kleine-König
2023-11-07  9:18 ` [PATCH 22/22] fb: omapfb/tpd12s015: " Uwe Kleine-König
2023-11-07  9:18   ` Uwe Kleine-König
2023-11-07 13:57 ` [PATCH 00/22] fb: handle remove callbacks in .exit.text and convert to .remove_new Helge Deller
2023-11-07 13:57   ` Helge Deller
2023-11-07 13:57   ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231107091740.3924258-9-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=deller@gmx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.