All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, hreitz@redhat.com, stefanha@redhat.com,
	qemu-devel@nongnu.org
Subject: [PATCH for-8.2 3/4] stream: Fix AioContext locking during bdrv_graph_wrlock()
Date: Wed, 15 Nov 2023 18:20:11 +0100	[thread overview]
Message-ID: <20231115172012.112727-4-kwolf@redhat.com> (raw)
In-Reply-To: <20231115172012.112727-1-kwolf@redhat.com>

In stream_prepare(), we need to temporarily drop the AioContext lock
that job_prepare_locked() took for us while calling the graph write lock
functions which can poll.

All block nodes related to this block job are in the same AioContext, so
we can pass any of them to bdrv_graph_wrlock()/ bdrv_graph_wrunlock().
Unfortunately, the one that we picked is base, which can be NULL - and
in this case the AioContext lock is not released and deadlocks can
occur.

Fix this by passing s->target_bs, which is never NULL.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/stream.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/stream.c b/block/stream.c
index e3aa696289..01fe7c0f16 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -99,9 +99,9 @@ static int stream_prepare(Job *job)
             }
         }
 
-        bdrv_graph_wrlock(base);
+        bdrv_graph_wrlock(s->target_bs);
         bdrv_set_backing_hd_drained(unfiltered_bs, base, &local_err);
-        bdrv_graph_wrunlock(base);
+        bdrv_graph_wrunlock(s->target_bs);
 
         /*
          * This call will do I/O, so the graph can change again from here on.
-- 
2.41.0



  parent reply	other threads:[~2023-11-15 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 17:20 [PATCH for-8.2 0/4] block: Fix deadlocks with the stream job Kevin Wolf
2023-11-15 17:20 ` [PATCH for-8.2 1/4] block: Fix bdrv_graph_wrlock() call in blk_remove_bs() Kevin Wolf
2023-11-15 17:20 ` [PATCH for-8.2 2/4] block: Fix deadlocks in bdrv_graph_wrunlock() Kevin Wolf
2023-11-15 17:20 ` Kevin Wolf [this message]
2023-11-15 17:20 ` [PATCH for-8.2 4/4] iotests: Test two stream jobs in a single iothread Kevin Wolf
2023-11-15 18:36 ` [PATCH for-8.2 0/4] block: Fix deadlocks with the stream job Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231115172012.112727-4-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.