All of lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: matthias.bgg@gmail.com
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
	p.zabel@pengutronix.de, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	wenst@chromium.org
Subject: [PATCH v1 01/20] arm64: dts: mediatek: mt8183: Change iospaces for thermal and svs
Date: Fri, 17 Nov 2023 10:42:09 +0100	[thread overview]
Message-ID: <20231117094228.40013-2-angelogioacchino.delregno@collabora.com> (raw)
In-Reply-To: <20231117094228.40013-1-angelogioacchino.delregno@collabora.com>

The SVS iospace starts at 0x1100bc00 and not at 0x1100b000 as the
latter is the thermal sensor iospace instead.

Change the iospaces for both as following:
 - Thermal: 0x1100b000, length 0xc00
 - SVS: 0x1100bc00, length 0x400

Please note that while this would be a breaking change for SVS (but
not for thermal sensors), it doesn't matter because the svs driver
never worked anyway because of the missing trips in tzts2, causing
that thermal zone to never actually register, hence the SVS driver
to fail probing anyway.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 26 ++++++++++++------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 5169779d01df..13c3104bc67b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1183,22 +1183,10 @@ spi0: spi@1100a000 {
 			status = "disabled";
 		};
 
-		svs: svs@1100b000 {
-			compatible = "mediatek,mt8183-svs";
-			reg = <0 0x1100b000 0 0x1000>;
-			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_LOW>;
-			clocks = <&infracfg CLK_INFRA_THERM>;
-			clock-names = "main";
-			nvmem-cells = <&svs_calibration>,
-				      <&thermal_calibration>;
-			nvmem-cell-names = "svs-calibration-data",
-					   "t-calibration-data";
-		};
-
 		thermal: thermal@1100b000 {
 			#thermal-sensor-cells = <1>;
 			compatible = "mediatek,mt8183-thermal";
-			reg = <0 0x1100b000 0 0x1000>;
+			reg = <0 0x1100b000 0 0xc00>;
 			clocks = <&infracfg CLK_INFRA_THERM>,
 				 <&infracfg CLK_INFRA_AUXADC>;
 			clock-names = "therm", "auxadc";
@@ -1210,6 +1198,18 @@ thermal: thermal@1100b000 {
 			nvmem-cell-names = "calibration-data";
 		};
 
+		svs: svs@1100bc00 {
+			compatible = "mediatek,mt8183-svs";
+			reg = <0 0x1100bc00 0 0x400>;
+			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&infracfg CLK_INFRA_THERM>;
+			clock-names = "main";
+			nvmem-cells = <&svs_calibration>,
+				      <&thermal_calibration>;
+			nvmem-cell-names = "svs-calibration-data",
+					   "t-calibration-data";
+		};
+
 		thermal_zones: thermal-zones {
 			cpu_thermal: cpu-thermal {
 				polling-delay-passive = <100>;
-- 
2.42.0


WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: matthias.bgg@gmail.com
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
	p.zabel@pengutronix.de, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	wenst@chromium.org
Subject: [PATCH v1 01/20] arm64: dts: mediatek: mt8183: Change iospaces for thermal and svs
Date: Fri, 17 Nov 2023 10:42:09 +0100	[thread overview]
Message-ID: <20231117094228.40013-2-angelogioacchino.delregno@collabora.com> (raw)
In-Reply-To: <20231117094228.40013-1-angelogioacchino.delregno@collabora.com>

The SVS iospace starts at 0x1100bc00 and not at 0x1100b000 as the
latter is the thermal sensor iospace instead.

Change the iospaces for both as following:
 - Thermal: 0x1100b000, length 0xc00
 - SVS: 0x1100bc00, length 0x400

Please note that while this would be a breaking change for SVS (but
not for thermal sensors), it doesn't matter because the svs driver
never worked anyway because of the missing trips in tzts2, causing
that thermal zone to never actually register, hence the SVS driver
to fail probing anyway.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 26 ++++++++++++------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 5169779d01df..13c3104bc67b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1183,22 +1183,10 @@ spi0: spi@1100a000 {
 			status = "disabled";
 		};
 
-		svs: svs@1100b000 {
-			compatible = "mediatek,mt8183-svs";
-			reg = <0 0x1100b000 0 0x1000>;
-			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_LOW>;
-			clocks = <&infracfg CLK_INFRA_THERM>;
-			clock-names = "main";
-			nvmem-cells = <&svs_calibration>,
-				      <&thermal_calibration>;
-			nvmem-cell-names = "svs-calibration-data",
-					   "t-calibration-data";
-		};
-
 		thermal: thermal@1100b000 {
 			#thermal-sensor-cells = <1>;
 			compatible = "mediatek,mt8183-thermal";
-			reg = <0 0x1100b000 0 0x1000>;
+			reg = <0 0x1100b000 0 0xc00>;
 			clocks = <&infracfg CLK_INFRA_THERM>,
 				 <&infracfg CLK_INFRA_AUXADC>;
 			clock-names = "therm", "auxadc";
@@ -1210,6 +1198,18 @@ thermal: thermal@1100b000 {
 			nvmem-cell-names = "calibration-data";
 		};
 
+		svs: svs@1100bc00 {
+			compatible = "mediatek,mt8183-svs";
+			reg = <0 0x1100bc00 0 0x400>;
+			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&infracfg CLK_INFRA_THERM>;
+			clock-names = "main";
+			nvmem-cells = <&svs_calibration>,
+				      <&thermal_calibration>;
+			nvmem-cell-names = "svs-calibration-data",
+					   "t-calibration-data";
+		};
+
 		thermal_zones: thermal-zones {
 			cpu_thermal: cpu-thermal {
 				polling-delay-passive = <100>;
-- 
2.42.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-17  9:42 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17  9:42 [PATCH v1 00/20] MediaTek SVS driver partial refactoring AngeloGioacchino Del Regno
2023-11-17  9:42 ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` AngeloGioacchino Del Regno [this message]
2023-11-17  9:42   ` [PATCH v1 01/20] arm64: dts: mediatek: mt8183: Change iospaces for thermal and svs AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 02/20] soc: mediatek: mtk-svs: Subtract offset from regs_v2 to avoid conflict AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 03/20] soc: mediatek: mtk-svs: Convert sw_id and type to enumerations AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 04/20] soc: mediatek: mtk-svs: Build bank name string dynamically AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 05/20] soc: mediatek: mtk-svs: Reduce memory footprint of struct svs_bank AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 06/20] soc: mediatek: mtk-svs: Change the thermal sensor device name AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 07/20] soc: mediatek: mtk-svs: Add a map to retrieve fused values AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 08/20] soc: mediatek: mtk-svs: Add SVS-Thermal coefficient to SoC platform data AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 09/20] soc: mediatek: mtk-svs: Move t-calibration-data retrieval to svs_probe() AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 10/20] soc: mediatek: mtk-svs: Commonize efuse parse function for most SoCs AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 11/20] soc: mediatek: mtk-svs: Drop supplementary svs per-bank pointer AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 12/20] soc: mediatek: mtk-svs: Commonize MT8192 probe function for MT8186 AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 13/20] soc: mediatek: mtk-svs: Remove redundant print in svs_get_efuse_data AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 14/20] soc: mediatek: mtk-svs: Compress of_device_id entries AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 15/20] soc: mediatek: mtk-svs: Cleanup of svs_probe() function AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 16/20] soc: mediatek: mtk-svs: Check if SVS mode is available in the beginning AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 17/20] soc: mediatek: mtk-svs: Use ULONG_MAX to compare floor frequency AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 18/20] soc: mediatek: mtk-svs: Constify runtime-immutable members of svs_bank AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17 14:32   ` Eugen Hristev
2023-11-17 14:32     ` Eugen Hristev
2023-11-21 11:53     ` AngeloGioacchino Del Regno
2023-11-21 11:53       ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 19/20] arm64: dts: mediatek: mt8192: Add Smart Voltage Scaling node AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno
2023-11-17  9:42 ` [PATCH v1 20/20] arm64: dts: mediatek: mt8195: Add SVS node and reduce LVTS_AP iospace AngeloGioacchino Del Regno
2023-11-17  9:42   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231117094228.40013-2-angelogioacchino.delregno@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.