From: Su Hui <suhui@nfschina.com>
To: tomas.winkler@intel.com, arnd@arndb.de,
gregkh@linuxfoundation.org, nathan@kernel.org,
ndesaulniers@google.com, trix@redhat.com
Cc: Su Hui <suhui@nfschina.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
kernel-janitors@vger.kernel.org
Subject: [PATCH v2 2/2] misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write
Date: Mon, 20 Nov 2023 17:55:26 +0800 [thread overview]
Message-ID: <20231120095523.178385-2-suhui@nfschina.com> (raw)
In-Reply-To: <20231120095523.178385-1-suhui@nfschina.com>
Clang static analyzer complains that value stored to 'rets' is never
read.Let 'buf_len = -EOVERFLOW' to make sure we can return '-EOVERFLOW'.
Fixes: 8c8d964ce90f ("mei: move hbuf_depth from the mei device to the hw modules")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
v2: split v1 patch to different patches
v1: https://lore.kernel.org/all/5c98fc07-36a9-92cc-f8d6-c4efdc0c34aa@nfschina.com/
drivers/misc/mei/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index 7ea80779a0e2..9d090fa07516 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -2032,7 +2032,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, unsigned long time
hbuf_slots = mei_hbuf_empty_slots(dev);
if (hbuf_slots < 0) {
- rets = -EOVERFLOW;
+ buf_len = -EOVERFLOW;
goto out;
}
--
2.30.2
next prev parent reply other threads:[~2023-11-20 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 9:55 [PATCH v2 1/2] misc: mei: client.c: return negative error code in mei_cl_write Su Hui
2023-11-20 9:55 ` Su Hui [this message]
2023-11-20 10:02 ` [PATCH v2 2/2] misc: mei: client.c: fix problem of return '-EOVERFLOW' " Greg KH
2023-11-20 10:02 ` [PATCH v2 1/2] misc: mei: client.c: return negative error code " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120095523.178385-2-suhui@nfschina.com \
--to=suhui@nfschina.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tomas.winkler@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.