All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 2/7] automation: remove com1= parameter on QEMU smoke tests
Date: Tue, 21 Nov 2023 17:03:53 +0100	[thread overview]
Message-ID: <20231121160358.8080-3-roger.pau@citrix.com> (raw)
In-Reply-To: <20231121160358.8080-1-roger.pau@citrix.com>

The serial is already setup by the firmware, be consistent with the rest of the
QEMU tests and don't specify a com1 setup.

Note it's also bogus, as the extra ',' will make the intended DPS argument to
be parsed as the io-base.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes in v2:
 - New in this version
---
 automation/scripts/qemu-smoke-x86-64.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/automation/scripts/qemu-smoke-x86-64.sh b/automation/scripts/qemu-smoke-x86-64.sh
index 188ff8e3d658..3014d07314b9 100755
--- a/automation/scripts/qemu-smoke-x86-64.sh
+++ b/automation/scripts/qemu-smoke-x86-64.sh
@@ -19,8 +19,7 @@ set +e
 timeout -k 1 30 \
 qemu-system-x86_64 -nographic -kernel binaries/xen \
         -initrd xtf/tests/example/$k \
-        -append "loglvl=all com1=115200,,8n1 console=com1 noreboot \
-                 console_timestamps=boot $extra" \
+        -append "loglvl=all console=com1 noreboot console_timestamps=boot $extra" \
         -m 512 -monitor none -serial file:smoke.serial
 set -e
 grep -q 'Test result: SUCCESS' smoke.serial || exit 1
-- 
2.42.0



  parent reply	other threads:[~2023-11-21 16:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 16:03 [PATCH v2 0/7] automation: minor fixes and improvements Roger Pau Monne
2023-11-21 16:03 ` [PATCH v2 1/7] automation: remove CR characters from serial output Roger Pau Monne
2023-11-21 16:03 ` Roger Pau Monne [this message]
2023-11-22  1:23   ` [PATCH v2 2/7] automation: remove com1= parameter on QEMU smoke tests Stefano Stabellini
2023-11-21 16:03 ` [PATCH v2 3/7] automation: add Xen timestamps to all tests Roger Pau Monne
2023-11-21 16:03 ` [PATCH v2 4/7] automation: fix jessie/stretch images to use archive.debian.org apt repos Roger Pau Monne
2023-11-21 16:03 ` [PATCH v2 5/7] automation: update tests to use Debian Bookworm Roger Pau Monne
2023-11-21 16:03 ` [PATCH v2 6/7] automation: set architecture in docker files Roger Pau Monne
2023-11-22  1:28   ` Stefano Stabellini
2023-11-21 16:03 ` [PATCH v2 7/7] automation: switch to multi-platform images when possible Roger Pau Monne
2023-11-22  1:29   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121160358.8080-3-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.