From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 02/21] coda_flag_children(): cope with dentries turning negative
Date: Fri, 24 Nov 2023 06:04:03 +0000 [thread overview]
Message-ID: <20231124060422.576198-2-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20231124060422.576198-1-viro@zeniv.linux.org.uk>
->d_lock on parent does not stabilize ->d_inode of child.
We don't do much with that inode in there, but we need
at least to avoid struct inode getting freed under us...
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/coda/cache.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/coda/cache.c b/fs/coda/cache.c
index 3b8c4513118f..bfbc03c6b632 100644
--- a/fs/coda/cache.c
+++ b/fs/coda/cache.c
@@ -92,13 +92,16 @@ static void coda_flag_children(struct dentry *parent, int flag)
{
struct dentry *de;
+ rcu_read_lock();
spin_lock(&parent->d_lock);
list_for_each_entry(de, &parent->d_subdirs, d_child) {
+ struct inode *inode = d_inode_rcu(de);
/* don't know what to do with negative dentries */
- if (d_inode(de) )
- coda_flag_inode(d_inode(de), flag);
+ if (inode)
+ coda_flag_inode(inode, flag);
}
spin_unlock(&parent->d_lock);
+ rcu_read_unlock();
return;
}
--
2.39.2
next prev parent reply other threads:[~2023-11-24 6:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 6:02 [RFC][PATCHSET v3] simplifying fast_dput(), dentry_kill() et.al Al Viro
2023-11-24 6:04 ` [PATCH v3 01/21] switch nfsd_client_rmdir() to use of simple_recursive_removal() Al Viro
2023-11-24 6:04 ` Al Viro [this message]
2023-11-24 21:22 ` [PATCH v3 02/21] coda_flag_children(): cope with dentries turning negative Linus Torvalds
2023-11-24 22:58 ` Paul E. McKenney
2023-11-24 6:04 ` [PATCH v3 03/21] dentry: switch the lists of children to hlist Al Viro
2023-11-24 7:44 ` Amir Goldstein
2023-11-24 7:55 ` Al Viro
2023-11-24 8:02 ` Amir Goldstein
2023-11-24 6:04 ` [PATCH v3 04/21] centralize killing dentry from shrink list Al Viro
2023-11-24 6:04 ` [PATCH v3 05/21] shrink_dentry_list(): no need to check that dentry refcount is marked dead Al Viro
2023-11-24 6:04 ` [PATCH v3 06/21] fast_dput(): having ->d_delete() is not reason to delay refcount decrement Al Viro
2023-11-24 6:04 ` [PATCH v3 07/21] fast_dput(): handle underflows gracefully Al Viro
2023-11-24 6:04 ` [PATCH v3 08/21] fast_dput(): new rules for refcount Al Viro
2023-11-24 6:04 ` [PATCH v3 09/21] __dput_to_list(): do decrement of refcount in the callers Al Viro
2023-11-24 6:04 ` [PATCH v3 10/21] make retain_dentry() neutral with respect to refcounting Al Viro
2023-11-24 6:04 ` [PATCH v3 11/21] __dentry_kill(): get consistent rules for victim's refcount Al Viro
2023-11-24 6:04 ` [PATCH v3 12/21] dentry_kill(): don't bother with retain_dentry() on slow path Al Viro
2023-11-24 6:04 ` [PATCH v3 13/21] Call retain_dentry() with refcount 0 Al Viro
2023-11-24 6:04 ` [PATCH v3 14/21] fold the call of retain_dentry() into fast_dput() Al Viro
2023-11-24 6:04 ` [PATCH v3 15/21] don't try to cut corners in shrink_lock_dentry() Al Viro
2023-11-24 6:04 ` [PATCH v3 16/21] fold dentry_kill() into dput() Al Viro
2023-11-24 6:04 ` [PATCH v3 17/21] to_shrink_list(): call only if refcount is 0 Al Viro
2023-11-24 6:04 ` [PATCH v3 18/21] switch select_collect{,2}() to use of to_shrink_list() Al Viro
2023-11-24 6:04 ` [PATCH v3 19/21] d_prune_aliases(): use a shrink list Al Viro
2023-11-24 6:04 ` [PATCH v3 20/21] __dentry_kill(): new locking scheme Al Viro
2023-11-24 6:04 ` [PATCH v3 21/21] retain_dentry(): introduce a trimmed-down lockless variant Al Viro
2023-11-24 21:28 ` [RFC][PATCHSET v3] simplifying fast_dput(), dentry_kill() et.al Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124060422.576198-2-viro@zeniv.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.