All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: <lee@kernel.org>, <pavel@ucw.cz>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<andy.shevchenko@gmail.com>
Cc: <kernel@sberdevices.ru>, <rockosov@gmail.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-leds@vger.kernel.org>,
	Martin Kurbanov <mmkurbanov@salutedevices.com>,
	Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: [PATCH v5 01/11] leds: aw200xx: fix write to DIM parameter
Date: Sat, 25 Nov 2023 23:05:09 +0300	[thread overview]
Message-ID: <20231125200519.1750-2-ddrokosov@salutedevices.com> (raw)
In-Reply-To: <20231125200519.1750-1-ddrokosov@salutedevices.com>

From: Martin Kurbanov <mmkurbanov@salutedevices.com>

If write only DIM value to the page 4, LED brightness will not be
updated, as both DIM and FADE need to be written to the page 4.
Therefore, write DIM to the page 1.

Fixes: 36a87f371b7a ("leds: Add AW20xx driver")
Signed-off-by: Martin Kurbanov <mmkurbanov@salutedevices.com>
Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/leds/leds-aw200xx.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c
index ef4eda6a09ee..842a22087b16 100644
--- a/drivers/leds/leds-aw200xx.c
+++ b/drivers/leds/leds-aw200xx.c
@@ -74,6 +74,10 @@
 #define AW200XX_LED2REG(x, columns) \
 	((x) + (((x) / (columns)) * (AW200XX_DSIZE_COLUMNS_MAX - (columns))))
 
+/* DIM current configuration register on page 1 */
+#define AW200XX_REG_DIM_PAGE1(x, columns) \
+	AW200XX_REG(AW200XX_PAGE1, AW200XX_LED2REG(x, columns))
+
 /*
  * DIM current configuration register (page 4).
  * The even address for current DIM configuration.
@@ -153,7 +157,8 @@ static ssize_t dim_store(struct device *dev, struct device_attribute *devattr,
 
 	if (dim >= 0) {
 		ret = regmap_write(chip->regmap,
-				   AW200XX_REG_DIM(led->num, columns), dim);
+				   AW200XX_REG_DIM_PAGE1(led->num, columns),
+				   dim);
 		if (ret)
 			goto out_unlock;
 	}
-- 
2.36.0


  reply	other threads:[~2023-11-25 20:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-25 20:05 [PATCH v5 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-11-25 20:05 ` Dmitry Rokosov [this message]
2023-11-25 20:05 ` [PATCH v5 02/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-11-28 15:46   ` Andy Shevchenko
2023-11-25 20:05 ` [PATCH v5 03/11] dt-bindings: leds: aw200xx: introduce optional enable-gpios property Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 04/11] leds: aw200xx: calculate dts property display_rows in the driver Dmitry Rokosov
2023-11-28 15:47   ` Andy Shevchenko
2023-11-25 20:05 ` [PATCH v5 05/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 06/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 07/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 08/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 09/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 10/11] dt-bindings: leds: awinic,aw200xx: add AW20108 device Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints Dmitry Rokosov
2023-12-01 11:09 ` [PATCH v5 00/11] leds: aw200xx: several driver updates Lee Jones
2023-12-06 11:29   ` Dmitry Rokosov
2023-12-06 13:11     ` Lee Jones
2023-12-06 17:02       ` Dmitry Rokosov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231125200519.1750-2-ddrokosov@salutedevices.com \
    --to=ddrokosov@salutedevices.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@sberdevices.ru \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mmkurbanov@salutedevices.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rockosov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.