From: Yang Yingliang <yangyingliang@huaweicloud.com>
To: dri-devel@lists.freedesktop.org
Cc: neil.armstrong@linaro.org, mripard@kernel.org,
lujianhua000@gmail.com, tzimmermann@suse.de,
yangyingliang@huawei.com, quic_jesszhan@quicinc.com,
sam@ravnborg.org
Subject: [PATCH] drm/panel: nt36523: fix return value check in nt36523_probe()
Date: Wed, 29 Nov 2023 17:07:15 +0800 [thread overview]
Message-ID: <20231129090715.856263-1-yangyingliang@huaweicloud.com> (raw)
From: Yang Yingliang <yangyingliang@huawei.com>
mipi_dsi_device_register_full() never returns NULL pointer, it
will return ERR_PTR() when it fails, so replace the check with
IS_ERR().
Fixes: 0993234a0045 ("drm/panel: Add driver for Novatek NT36523")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/gpu/drm/panel/panel-novatek-nt36523.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
index 9b9a7eb1bc60..a189ce236328 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
@@ -1254,9 +1254,9 @@ static int nt36523_probe(struct mipi_dsi_device *dsi)
return dev_err_probe(dev, -EPROBE_DEFER, "cannot get secondary DSI host\n");
pinfo->dsi[1] = mipi_dsi_device_register_full(dsi1_host, info);
- if (!pinfo->dsi[1]) {
+ if (IS_ERR(pinfo->dsi[1])) {
dev_err(dev, "cannot get secondary DSI device\n");
- return -ENODEV;
+ return PTR_ERR(pinfo->dsi[1]);
}
}
--
2.25.1
next reply other threads:[~2023-11-29 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 9:07 Yang Yingliang [this message]
2023-11-29 15:52 ` [PATCH] drm/panel: nt36523: fix return value check in nt36523_probe() neil.armstrong
2023-11-29 15:56 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129090715.856263-1-yangyingliang@huaweicloud.com \
--to=yangyingliang@huaweicloud.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lujianhua000@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.