From: Barry Song <21cnbao@gmail.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org
Cc: david@redhat.com, shikemeng@huaweicloud.com, willy@infradead.org,
mgorman@techsingularity.net, hannes@cmpxchg.org,
baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org,
Barry Song <v-songbaohua@oppo.com>,
Zhanyuan Hu <huzhanyuan@oppo.com>
Subject: [RFC PATCH] mm: compaction: avoid fast_isolate_freepages blindly choose improper pageblock
Date: Wed, 29 Nov 2023 23:45:30 +1300 [thread overview]
Message-ID: <20231129104530.63787-1-v-songbaohua@oppo.com> (raw)
Testing shows fast_isolate_freepages can blindly choose an unsuitable
pageblock from time to time particularly while the min mark is used
from XXX path:
if (!page) {
cc->fast_search_fail++;
if (scan_start) {
/*
* Use the highest PFN found above min. If one was
* not found, be pessimistic for direct compaction
* and use the min mark.
*/
if (highest >= min_pfn) {
page = pfn_to_page(highest);
cc->free_pfn = highest;
} else {
if (cc->direct_compaction && pfn_valid(min_pfn)) { /* XXX */
page = pageblock_pfn_to_page(min_pfn,
min(pageblock_end_pfn(min_pfn),
zone_end_pfn(cc->zone)),
cc->zone);
cc->free_pfn = min_pfn;
}
}
}
}
In contrast, slow path is skipping unsuitable pageblocks in a decent way.
I don't know if it is an intended design or just an oversight. But
it seems more sensible to skip unsuitable pageblock.
Reported-by: Zhanyuan Hu <huzhanyuan@oppo.com>
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
---
mm/compaction.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mm/compaction.c b/mm/compaction.c
index 01ba298739dd..98c485a25614 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1625,6 +1625,12 @@ static void fast_isolate_freepages(struct compact_control *cc)
cc->total_free_scanned += nr_scanned;
if (!page)
return;
+ /*
+ * Otherwise, we can blindly choose an improper pageblock especially
+ * while using the min mark
+ */
+ if (!suitable_migration_target(cc, page))
+ return;
low_pfn = page_to_pfn(page);
fast_isolate_around(cc, low_pfn);
--
2.34.1
next reply other threads:[~2023-11-29 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 10:45 Barry Song [this message]
2023-12-06 9:54 ` [RFC PATCH] mm: compaction: avoid fast_isolate_freepages blindly choose improper pageblock Baolin Wang
2023-12-06 10:18 ` Barry Song
2023-12-07 1:50 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129104530.63787-1-v-songbaohua@oppo.com \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=huzhanyuan@oppo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=shikemeng@huaweicloud.com \
--cc=v-songbaohua@oppo.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.