From: Ding Hui <dinghui@sangfor.com.cn>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: zhuwei@sangfor.com.cn, thenzl@redhat.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ding Hui <dinghui@sangfor.com.cn>
Subject: [PATCH 1/2] scsi: ses: Fix slab-out-of-bounds in ses_get_power_status()
Date: Thu, 30 Nov 2023 22:28:34 +0800 [thread overview]
Message-ID: <20231130142835.18041-2-dinghui@sangfor.com.cn> (raw)
In-Reply-To: <20231130142835.18041-1-dinghui@sangfor.com.cn>
From: Zhu Wei <zhuwei@sangfor.com.cn>
A fix for:
BUG: KASAN: slab-out-of-bounds in ses_get_power_status+0x178/0x1a8 [ses]
Read of size 1 at addr ffffa5e3f9466a2b by task grep/102588
Call trace:
ses_get_power_status+0x178/0x1a8 [ses]
get_component_power_status+0x94/0x1f0 [enclosure]
dev_attr_show+0x5c/0xc8
sysfs_kf_seq_show+0x1b0/0x350
kernfs_seq_show+0x10c/0x160
seq_read+0x250/0xe28
If the page2 buffer is less than the number of elements indicated by page1,
that will cause desc_ptr to point to out-of-bounds.
The report occurs when we read sg power_status which iscsi target is a Dell
PowerVault MD3200i storage server.
Signed-off-by: Zhu Wei <zhuwei@sangfor.com.cn>
Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
---
drivers/scsi/ses.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
index d7d0c35c58b8..2a404e51b6db 100644
--- a/drivers/scsi/ses.c
+++ b/drivers/scsi/ses.c
@@ -165,6 +165,8 @@ static int ses_set_page2_descriptor(struct enclosure_device *edev,
for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) {
for (j = 0; j < type_ptr[1]; j++) {
desc_ptr += 4;
+ if (desc_ptr - ses_dev->page2 + 4 > ses_dev->page2_len)
+ break;
if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE &&
type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE)
continue;
@@ -196,6 +198,8 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev,
for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) {
for (j = 0; j < type_ptr[1]; j++) {
desc_ptr += 4;
+ if (desc_ptr - ses_dev->page2 + 4 > ses_dev->page2_len)
+ return NULL;
if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE &&
type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE)
continue;
--
2.17.1
next prev parent reply other threads:[~2023-11-30 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:28 [PATCH 0/2] scsi: ses: Fix out-of-bounds accesses Ding Hui
2023-11-30 14:28 ` Ding Hui [this message]
2023-11-30 14:28 ` [PATCH 2/2] scsi: ses: increase default init_alloc_size Ding Hui
2023-12-20 8:47 ` [PATCH 0/2] scsi: ses: Fix out-of-bounds accesses Ding Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130142835.18041-2-dinghui@sangfor.com.cn \
--to=dinghui@sangfor.com.cn \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
--cc=zhuwei@sangfor.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.