From: Nirmoy Das <nirmoy.das@intel.com> To: intel-gfx@lists.freedesktop.org Cc: Andrzej Hajda <andrzej.hajda@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@intel.com>, dri-devel@lists.freedesktop.org, Andi Shyti <andi.shyti@linux.intel.com>, John Harrison <John.C.Harrison@Intel.com>, Nirmoy Das <nirmoy.das@intel.com> Subject: [PATCH] drm/i915/gt: Reduce log severity on reset prepare. Date: Fri, 1 Dec 2023 16:44:43 +0100 [thread overview] Message-ID: <20231201154443.16660-1-nirmoy.das@intel.com> (raw) gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let the caller of gen8_engine_reset_prepare() decide if a failure in gen8_engine_reset_prepare is an error or not. Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: John Harrison <John.C.Harrison@Intel.com> Cc: Andi Shyti <andi.shyti@linux.intel.com> Cc: Andrzej Hajda <andrzej.hajda@intel.com> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591 Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/gt/intel_reset.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index d5ed904f355d..e6fbc6202c80 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -593,10 +593,10 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine) ret = __intel_wait_for_register_fw(uncore, reg, mask, ack, 700, 0, NULL); if (ret) - gt_err(engine->gt, - "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", - engine->name, request, - intel_uncore_read_fw(uncore, reg)); + GT_TRACE(engine->gt, + "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", + engine->name, request, + intel_uncore_read_fw(uncore, reg)); return ret; } -- 2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: Nirmoy Das <nirmoy.das@intel.com> To: intel-gfx@lists.freedesktop.org Cc: Andrzej Hajda <andrzej.hajda@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@intel.com>, dri-devel@lists.freedesktop.org, Nirmoy Das <nirmoy.das@intel.com> Subject: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare. Date: Fri, 1 Dec 2023 16:44:43 +0100 [thread overview] Message-ID: <20231201154443.16660-1-nirmoy.das@intel.com> (raw) gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let the caller of gen8_engine_reset_prepare() decide if a failure in gen8_engine_reset_prepare is an error or not. Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: John Harrison <John.C.Harrison@Intel.com> Cc: Andi Shyti <andi.shyti@linux.intel.com> Cc: Andrzej Hajda <andrzej.hajda@intel.com> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591 Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/gt/intel_reset.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index d5ed904f355d..e6fbc6202c80 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -593,10 +593,10 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine) ret = __intel_wait_for_register_fw(uncore, reg, mask, ack, 700, 0, NULL); if (ret) - gt_err(engine->gt, - "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", - engine->name, request, - intel_uncore_read_fw(uncore, reg)); + GT_TRACE(engine->gt, + "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", + engine->name, request, + intel_uncore_read_fw(uncore, reg)); return ret; } -- 2.42.0
next reply other threads:[~2023-12-01 15:57 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-01 15:44 Nirmoy Das [this message] 2023-12-01 15:44 ` [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare Nirmoy Das 2023-12-02 2:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2023-12-03 5:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2023-12-04 19:52 ` [PATCH] " Andi Shyti 2023-12-04 19:52 ` [Intel-gfx] " Andi Shyti 2023-12-05 1:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Reduce log severity on reset prepare. (rev2) Patchwork 2023-12-05 6:58 ` [PATCH] drm/i915/gt: Reduce log severity on reset prepare Andrzej Hajda 2023-12-05 6:58 ` [Intel-gfx] " Andrzej Hajda 2023-12-05 8:34 ` Tvrtko Ursulin 2023-12-05 8:50 ` Nirmoy Das 2023-12-05 10:05 ` Tvrtko Ursulin 2023-12-05 10:44 ` Nirmoy Das 2023-12-05 10:52 ` Tvrtko Ursulin 2023-12-05 9:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Reduce log severity on reset prepare. (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231201154443.16660-1-nirmoy.das@intel.com \ --to=nirmoy.das@intel.com \ --cc=John.C.Harrison@Intel.com \ --cc=andi.shyti@linux.intel.com \ --cc=andrzej.hajda@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=tvrtko.ursulin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.