From: vmolnaro@redhat.com
To: linux-perf-users@vger.kernel.org, acme@kernel.org,
acme@redhat.com, vmolnaro@redhat.com
Cc: mpetlan@redhat.com, leo.yan@linaro.org, james.clark@arm.com
Subject: [PATCH] perf test record user-regs: Fix mask for vg register
Date: Fri, 1 Dec 2023 20:46:17 +0100 [thread overview]
Message-ID: <20231201194617.13012-1-vmolnaro@redhat.com> (raw)
From: Veronika Molnarova <vmolnaro@redhat.com>
The 'vg' register for arm64 shows up in --user_regs as available when
masking the variable AT_HWCAP with 1 << 22 returns '1' as done in
perf_regs.c. However, in subtests for support of SVE, the check for
the 'vg' register is done by masking the variable AT_HWCAP with the value
0x200000 which is equals to 1 << 21 instead of 1 << 22. This results in
inconsistencies on certain systems where the test expects that the 'vg'
register is not operational when it is, and vice-versa.
During the testing on a machine that the test expected not to have the
'vg' register available, the perf record with option --user-regs showed
records for the 'vg' register together with all of the others, which
means that the mask for the subtest of perf_event_attr is off by one.
Change the value of the mask from 0x200000 to 0x400000 to correct it.
Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
---
tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64 | 2 +-
tools/perf/tests/attr/test-record-user-regs-sve-aarch64 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64 b/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
index fbb065842880..bed765450ca9 100644
--- a/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
+++ b/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
@@ -6,4 +6,4 @@ args = --no-bpf-event --user-regs=vg kill >/dev/null 2>&1
ret = 129
test_ret = true
arch = aarch64
-auxv = auxv["AT_HWCAP"] & 0x200000 == 0
+auxv = auxv["AT_HWCAP"] & 0x400000 == 0
diff --git a/tools/perf/tests/attr/test-record-user-regs-sve-aarch64 b/tools/perf/tests/attr/test-record-user-regs-sve-aarch64
index c598c803221d..a65113cd7311 100644
--- a/tools/perf/tests/attr/test-record-user-regs-sve-aarch64
+++ b/tools/perf/tests/attr/test-record-user-regs-sve-aarch64
@@ -6,7 +6,7 @@ args = --no-bpf-event --user-regs=vg kill >/dev/null 2>&1
ret = 1
test_ret = true
arch = aarch64
-auxv = auxv["AT_HWCAP"] & 0x200000 == 0x200000
+auxv = auxv["AT_HWCAP"] & 0x400000 == 0x400000
kernel_since = 6.1
[event:base-record]
--
2.41.0
next reply other threads:[~2023-12-01 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 19:46 vmolnaro [this message]
2023-12-03 6:13 ` [PATCH] perf test record user-regs: Fix mask for vg register Leo Yan
2023-12-04 19:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201194617.13012-1-vmolnaro@redhat.com \
--to=vmolnaro@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=james.clark@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.