From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "Andi Shyti" <andi.shyti@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, "Alim Akhtar" <alim.akhtar@samsung.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Jiri Slaby" <jirislaby@kernel.org>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Guenter Roeck" <linux@roeck-us.net>, linux-fsd@tesla.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/6] dt-bindings: i2c: exynos5: add specific compatible for Tesla FSD Date: Tue, 5 Dec 2023 10:22:24 +0100 [thread overview] Message-ID: <20231205092229.19135-2-krzysztof.kozlowski@linaro.org> (raw) In-Reply-To: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the others it reuses several devices from older designs. Historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add Tesla FSD compatible specific to be used with an existing fallback. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml index c1f5d2cb7709..df9c57bca2a8 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml @@ -29,6 +29,7 @@ properties: - items: - enum: - samsung,exynos5433-hsi2c + - tesla,fsd-hsi2c - const: samsung,exynos7-hsi2c - items: - enum: -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "Andi Shyti" <andi.shyti@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, "Alim Akhtar" <alim.akhtar@samsung.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Jiri Slaby" <jirislaby@kernel.org>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Guenter Roeck" <linux@roeck-us.net>, linux-fsd@tesla.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/6] dt-bindings: i2c: exynos5: add specific compatible for Tesla FSD Date: Tue, 5 Dec 2023 10:22:24 +0100 [thread overview] Message-ID: <20231205092229.19135-2-krzysztof.kozlowski@linaro.org> (raw) In-Reply-To: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the others it reuses several devices from older designs. Historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add Tesla FSD compatible specific to be used with an existing fallback. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml index c1f5d2cb7709..df9c57bca2a8 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml @@ -29,6 +29,7 @@ properties: - items: - enum: - samsung,exynos5433-hsi2c + - tesla,fsd-hsi2c - const: samsung,exynos7-hsi2c - items: - enum: -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-05 9:22 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-05 9:22 [PATCH 0/6] dt-bindings: samsung: continued - add specific compatibles for Tesla FSD Hi, Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski [this message] 2023-12-05 9:22 ` [PATCH 1/6] dt-bindings: i2c: exynos5: add specific compatible for Tesla FSD Krzysztof Kozlowski 2023-12-06 22:00 ` Rob Herring 2023-12-06 22:00 ` Rob Herring 2023-12-19 10:21 ` Wolfram Sang 2023-12-19 10:21 ` Wolfram Sang 2023-12-05 9:22 ` [PATCH 2/6] dt-bindings: pwm: samsung: " Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski 2023-12-05 9:41 ` Uwe Kleine-König 2023-12-05 9:41 ` Uwe Kleine-König 2023-12-06 16:16 ` Thierry Reding 2023-12-06 16:16 ` Thierry Reding 2023-12-06 17:35 ` Krzysztof Kozlowski 2023-12-06 17:35 ` Krzysztof Kozlowski 2023-12-06 22:02 ` Rob Herring 2023-12-06 22:02 ` Rob Herring 2023-12-05 9:22 ` [PATCH 3/6] dt-bindings: serial: " Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski 2023-12-06 22:04 ` Rob Herring 2023-12-06 22:04 ` Rob Herring 2023-12-05 9:22 ` [PATCH 4/6] dt-bindings: samsung: exynos-pmu: " Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski 2023-12-06 22:05 ` Rob Herring 2023-12-06 22:05 ` Rob Herring 2023-12-05 9:22 ` [PATCH 5/6] dt-bindings: watchdog: samsung: " Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski 2023-12-06 22:05 ` Rob Herring 2023-12-06 22:05 ` Rob Herring 2023-12-05 9:22 ` [PATCH 6/6] arm64: dts: fsd: add specific compatibles " Krzysztof Kozlowski 2023-12-05 9:22 ` Krzysztof Kozlowski 2023-12-05 16:41 ` [PATCH 0/6] dt-bindings: samsung: continued - add specific compatibles for Tesla FSD Hi, Conor Dooley 2023-12-05 16:41 ` Conor Dooley 2023-12-07 13:33 ` Krzysztof Kozlowski 2023-12-07 13:33 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231205092229.19135-2-krzysztof.kozlowski@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andi.shyti@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fsd@tesla.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.