[PATCH v2 1/2] um: net: Fix return type of uml_net_start_xmit()

From: Nathan Chancellor <nathan@kernel.org>
To: masahiroy@kernel.org
Cc: ndesaulniers@google.com, morbo@google.com,
	justinstitt@google.com,  keescook@chromium.org,
	samitolvanen@google.com, nicolas@fjasle.eu,
	 linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
	patches@lists.linux.dev,  kernel test robot <lkp@intel.com>,
	 Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	 Nathan Chancellor <nathan@kernel.org>,
	richard@nod.at,  johannes@sipsolutions.net,
	linux-um@lists.infradead.org
Subject: [PATCH v2 1/2] um: net: Fix return type of uml_net_start_xmit()
Date: Wed, 06 Dec 2023 09:49:46 -0700	[thread overview]
Message-ID: <20231206-enable-wincompatible-function-pointer-types-strict-w-1-v2-1-91311b4c37b0@kernel.org> (raw)
In-Reply-To: <20231206-enable-wincompatible-function-pointer-types-strict-w-1-v2-0-91311b4c37b0@kernel.org>

With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
indirect call targets are validated against the expected function
pointer prototype to make sure the call target is valid to help mitigate
ROP attacks. If they are not identical, there is a failure at run time,
which manifests as either a kernel panic or thread getting killed. A
warning in clang aims to catch these at compile time, which reveals:

  arch/um/drivers/net_kern.c:353:21: warning: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Wincompatible-function-pointer-types-strict]
    353 |         .ndo_start_xmit         = uml_net_start_xmit,
        |                                   ^~~~~~~~~~~~~~~~~~
  1 warning generated.

->ndo_start_xmit() in 'struct net_device_ops' expects a return type of
'netdev_tx_t', not 'int'. Adjust the return type of uml_net_start_xmit()
to match the prototype's to resolve the warning. While UML does not
currently implement support for kCFI, it could in the future, which
means this warning becomes a fatal CFI failure at run time.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310031340.v1vPh207-lkp@intel.com/
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Cc: richard@nod.at
Cc: johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org
---
 arch/um/drivers/net_kern.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 3d7836c46507..cabcc501b448 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -204,7 +204,7 @@ static int uml_net_close(struct net_device *dev)
 	return 0;
 }
 
-static int uml_net_start_xmit(struct sk_buff *skb, struct net_device *dev)
+static netdev_tx_t uml_net_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	struct uml_net_private *lp = netdev_priv(dev);
 	unsigned long flags;

-- 
2.43.0

