All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com,
	yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org,
	vitaly.wool@konsulko.com, mhocko@kernel.org,
	roman.gushchin@linux.dev, shakeelb@google.com,
	muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org,
	kernel-team@meta.com, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: [PATCH v8 3/6] zswap: make shrinking memcg-aware (fix 2)
Date: Tue,  5 Dec 2023 19:06:27 -0800	[thread overview]
Message-ID: <20231206030627.4155634-1-nphamcs@gmail.com> (raw)
In-Reply-To: <20231130194023.4102148-4-nphamcs@gmail.com>

Drop the pool's reference at the end of the writeback step. Apply on
top of the first fixlet:

https://lore.kernel.org/linux-mm/20231130203522.GC543908@cmpxchg.org/T/#m6ba8efd2205486b1b333a29f5a890563b45c7a7e

Signed-off-by: Nhat Pham <nphamcs@gmail.com>
---
 mm/zswap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zswap.c b/mm/zswap.c
index 7a84c1454988..56d4a8cc461d 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -859,6 +859,7 @@ static void shrink_worker(struct work_struct *w)
 resched:
 		cond_resched();
 	} while (!zswap_can_accept());
+	zswap_pool_put(pool);
 }
 
 static struct zswap_pool *zswap_pool_create(char *type, char *compressor)
-- 
2.34.1

  parent reply	other threads:[~2023-12-06  3:06 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 19:40 [PATCH v8 0/6] workload-specific and memory pressure-driven zswap writeback Nhat Pham
2023-11-30 19:40 ` [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection Nhat Pham
2023-11-30 19:57   ` Matthew Wilcox
2023-11-30 20:07     ` Nhat Pham
2023-11-30 20:35       ` Johannes Weiner
2023-12-04  8:30         ` Chengming Zhou
2023-12-04 17:48           ` Nhat Pham
2023-12-05  2:28             ` Chengming Zhou
2023-12-05  0:30         ` Chris Li
2023-12-05 17:17           ` Johannes Weiner
2023-11-30 19:40 ` [PATCH v8 2/6] memcontrol: implement mem_cgroup_tryget_online() Nhat Pham
2023-12-05  0:35   ` Chris Li
2023-12-05  1:39     ` Nhat Pham
2023-12-06  0:16       ` Chris Li
2023-12-06  1:30         ` Nhat Pham
2023-12-05 18:02   ` Yosry Ahmed
2023-12-05 19:55     ` Nhat Pham
2023-11-30 19:40 ` [PATCH v8 3/6] zswap: make shrinking memcg-aware Nhat Pham
2023-12-05 18:20   ` Yosry Ahmed
2023-12-05 18:49     ` Nhat Pham
2023-12-05 18:59       ` Yosry Ahmed
2023-12-05 19:09         ` Nhat Pham
2023-12-05 19:54   ` [PATCH v8 3/6] zswap: make shrinking memcg-aware (fix) Nhat Pham
2023-12-06  0:10   ` [PATCH v8 3/6] zswap: make shrinking memcg-aware Chris Li
2023-12-06  1:53     ` Nhat Pham
2023-12-06  3:03   ` Nhat Pham
2023-12-06  3:06   ` Nhat Pham [this message]
2023-11-30 19:40 ` [PATCH v8 4/6] mm: memcg: add per-memcg zswap writeback stat Nhat Pham
2023-12-05 18:21   ` Yosry Ahmed
2023-12-05 18:56     ` Nhat Pham
2023-12-05 19:33   ` [PATCH v8 4/6] mm: memcg: add per-memcg zswap writeback stat (fix) Nhat Pham
2023-12-05 20:05     ` Yosry Ahmed
2023-12-08  0:25     ` Chris Li
2023-11-30 19:40 ` [PATCH v8 5/6] selftests: cgroup: update per-memcg zswap writeback selftest Nhat Pham
2023-12-08  0:43   ` Chris Li
2023-11-30 19:40 ` [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure Nhat Pham
2023-12-06  5:51   ` Chengming Zhou
2023-12-06  5:59     ` Yosry Ahmed
2023-12-06  6:43       ` Chengming Zhou
2023-12-06  7:36         ` Yosry Ahmed
2023-12-06  7:39           ` Chengming Zhou
2023-12-06 16:56       ` Nhat Pham
2023-12-06 19:47         ` Nhat Pham
2023-12-06 21:13           ` Yosry Ahmed
2023-12-07  2:32           ` Chengming Zhou
2023-12-06 19:44   ` [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure (fix) Nhat Pham
2023-11-30 21:19 ` [PATCH v8 0/6] workload-specific and memory pressure-driven zswap writeback Andrew Morton
2023-12-06  4:10 ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206030627.4155634-1-nphamcs@gmail.com \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cerasuolodomenico@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=chrisl@kernel.org \
    --cc=ddstreet@ieee.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=shuah@kernel.org \
    --cc=sjenning@redhat.com \
    --cc=vitaly.wool@konsulko.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.