All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 11/25] drm: rcar-du: rzg2l_mipi_dsi: Reorder bridge attach
Date: Thu,  7 Dec 2023 14:24:48 +0000	[thread overview]
Message-ID: <20231207142502.401651-12-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20231207142502.401651-1-biju.das.jz@bp.renesas.com>

Add the drm_bridge_add() in probe and update rzg2l_mipi_dsi_attach()
to find the next bridge and attach the bridge. This allows DU to probe
with all the connected devices on 5.10 cip kernel.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
index aa95b85a2964..50777ed767a7 100644
--- a/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
+++ b/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
@@ -527,6 +527,15 @@ static int rzg2l_mipi_dsi_attach(struct drm_bridge *bridge,
 				 enum drm_bridge_attach_flags flags)
 {
 	struct rzg2l_mipi_dsi *dsi = bridge_to_rzg2l_mipi_dsi(bridge);
+	int ret;
+
+	dsi->next_bridge = devm_drm_of_get_bridge(dsi->dev, dsi->dev->of_node,
+						  1, 0);
+	if (IS_ERR(dsi->next_bridge)) {
+		ret = PTR_ERR(dsi->next_bridge);
+		dev_err(dsi->dev, "failed to get next bridge: %d\n", ret);
+		return ret;
+	}
 
 	return drm_bridge_attach(bridge->encoder, dsi->next_bridge, bridge,
 				 flags);
@@ -607,7 +616,6 @@ static int rzg2l_mipi_dsi_host_attach(struct mipi_dsi_host *host,
 				      struct mipi_dsi_device *device)
 {
 	struct rzg2l_mipi_dsi *dsi = host_to_rzg2l_mipi_dsi(host);
-	int ret;
 
 	if (device->lanes > dsi->num_data_lanes) {
 		dev_err(dsi->dev,
@@ -629,16 +637,6 @@ static int rzg2l_mipi_dsi_host_attach(struct mipi_dsi_host *host,
 	dsi->format = device->format;
 	dsi->mode_flags = device->mode_flags;
 
-	dsi->next_bridge = devm_drm_of_get_bridge(dsi->dev, dsi->dev->of_node,
-						  1, 0);
-	if (IS_ERR(dsi->next_bridge)) {
-		ret = PTR_ERR(dsi->next_bridge);
-		dev_err(dsi->dev, "failed to get next bridge: %d\n", ret);
-		return ret;
-	}
-
-	drm_bridge_add(&dsi->bridge);
-
 	return 0;
 }
 
@@ -772,6 +770,8 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
 	if (ret < 0)
 		goto err_pm_disable;
 
+	drm_bridge_add(&dsi->bridge);
+
 	return 0;
 
 err_phy:
-- 
2.25.1



  parent reply	other threads:[~2023-12-07 14:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 14:24 [PATCH 5.10.y-cip 00/25] Add RZ/G2L DSI support Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 01/25] drm/bridge: Add a function to abstract away panels Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 02/25] drm/bridge: Add stubs for devm_drm_of_get_bridge when OF is disabled Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 03/25] drm/bridge: Move devm_drm_of_get_bridge to bridge/panel.c Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 04/25] drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 05/25] drm: of: Mark empty drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep static Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 06/25] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 07/25] dt-bindings: display: bridge: renesas,rzg2l-mipi-dsi: Document RZ/V2L support Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 08/25] drm: rcar-du: Add RZ/G2L DSI driver Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 09/25] drm: rcar-du: Fix Kconfig dependency between DRM and RZG2L_MIPI_DSI Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 10/25] drm: rcar-du: rzg2l_mipi_dsi: Enhance device lanes check Biju Das
2023-12-07 14:24 ` Biju Das [this message]
2023-12-07 14:24 ` [PATCH 5.10.y-cip 12/25] arm64: defconfig: Enable Renesas RZ/G2L MIPI DSI driver Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 13/25] arm64: dts: renesas: r9a07g044: Add DSI node Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 14/25] arm64: dts: renesas: r9a07g054: " Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 15/25] arm64: dts: renesas: rzg2l-smarc: Link DSI with ADV7535 Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 16/25] arm64: dts: renesas: rzg2lc-smarc: " Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 17/25] arm64: dts: renesas: Drop ADV7535 IRQ Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 18/25] arm64: dts: renesas: r9a07g044: [HACK DO NOT APPLY] Add DU node Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 19/25] arm64: dts: renesas: r9a07g054: " Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 20/25] arm64: dts: renesas: rzg2l-smarc: [HACK DO NOT APPLY] Enable DU and link with DSI Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 21/25] arm64: dts: renesas: rzg2lc-smarc: " Biju Das
2023-12-07 14:24 ` [PATCH 5.10.y-cip 22/25] drm: [HACK DO NOT APPLY] add drmm_encoder_alloc() Biju Das
2023-12-07 14:25 ` [PATCH 5.10.y-cip 23/25] drm: [HACK DO NOT APPLY] Allow const struct drm_driver Biju Das
2023-12-07 14:25 ` [PATCH 5.10.y-cip 24/25] drm: [HACK DO NOT APPLY] Add RZ/G2L DU Support Biju Das
2023-12-07 14:25 ` [PATCH 5.10.y-cip 25/25] defconfig: [HACK DO NOT APPLY] Enable display on RZ/G2L SMARC EVK Biju Das
2023-12-07 19:41 ` [PATCH 5.10.y-cip 00/25] Add RZ/G2L DSI support Pavel Machek
2023-12-08 11:38 ` Pavel Machek
2023-12-08 12:09   ` Biju Das
     [not found]   ` <179ED9F671D9670E.16398@lists.cip-project.org>
2023-12-08 12:56     ` [cip-dev] " Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207142502.401651-12-biju.das.jz@bp.renesas.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=pavel@denx.de \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.