From: Shantur Rathore <i@shantur.com> Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Shantur Rathore <i@shantur.com> Subject: [PATCH v1] dts: rockpro64: Remove usb regulator-always-on Date: Sat, 9 Dec 2023 23:35:36 +0000 [thread overview] Message-ID: <20231209233536.350876-1-i@shantur.com> (raw) In-Reply-To: <20231209232109.348999-1-i@shantur.com> USB port regulators should be controlled by PHYs so we remove always-on property and let PHYs manage the regulator. Typec port has misconfugred phy-supply and now that we are removing regulator-always-on, we need to fix the phy-supply so the PHYs are able to turn power to type-c port. Signed-off-by: Shantur Rathore <i@shantur.com> --- + devicetree After this patch the ports were confirmed to power up and down in u-boot when doing usb start and usb stop. At boot the regulators were off, the devices connected weren't powered up, on usb start the PHYs are able to power on the ports and on usb stop they were powered down. At the boot, the ports were powered down which was again powered up by Linux kernel when booting up. arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi index bca2b50e0a..bd2824aa48 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi @@ -192,7 +192,6 @@ vcc5v0_host: vcc5v0-host-regulator { pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_host_en>; regulator-name = "vcc5v0_host"; - regulator-always-on; vin-supply = <&vcc5v0_usb>; }; @@ -203,7 +202,6 @@ vcc5v0_typec: vcc5v0-typec-regulator { pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_typec_en>; regulator-name = "vcc5v0_typec"; - regulator-always-on; vin-supply = <&vcc5v0_usb>; }; @@ -863,7 +861,7 @@ u2phy0_otg: otg-port { }; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; }; }; -- 2.40.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Shantur Rathore <i@shantur.com> Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Shantur Rathore <i@shantur.com> Subject: [PATCH v1] dts: rockpro64: Remove usb regulator-always-on Date: Sat, 9 Dec 2023 23:35:36 +0000 [thread overview] Message-ID: <20231209233536.350876-1-i@shantur.com> (raw) In-Reply-To: <20231209232109.348999-1-i@shantur.com> USB port regulators should be controlled by PHYs so we remove always-on property and let PHYs manage the regulator. Typec port has misconfugred phy-supply and now that we are removing regulator-always-on, we need to fix the phy-supply so the PHYs are able to turn power to type-c port. Signed-off-by: Shantur Rathore <i@shantur.com> --- + devicetree After this patch the ports were confirmed to power up and down in u-boot when doing usb start and usb stop. At boot the regulators were off, the devices connected weren't powered up, on usb start the PHYs are able to power on the ports and on usb stop they were powered down. At the boot, the ports were powered down which was again powered up by Linux kernel when booting up. arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi index bca2b50e0a..bd2824aa48 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi @@ -192,7 +192,6 @@ vcc5v0_host: vcc5v0-host-regulator { pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_host_en>; regulator-name = "vcc5v0_host"; - regulator-always-on; vin-supply = <&vcc5v0_usb>; }; @@ -203,7 +202,6 @@ vcc5v0_typec: vcc5v0-typec-regulator { pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_typec_en>; regulator-name = "vcc5v0_typec"; - regulator-always-on; vin-supply = <&vcc5v0_usb>; }; @@ -863,7 +861,7 @@ u2phy0_otg: otg-port { }; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; }; }; -- 2.40.1
next prev parent reply other threads:[~2023-12-09 23:37 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-09 23:21 [PATCH v1] dts: rockpro64: Remove usb regulator-always-on Shantur Rathore 2023-12-09 23:35 ` Shantur Rathore [this message] 2023-12-09 23:35 ` Shantur Rathore 2023-12-09 23:43 ` Dragan Simic 2023-12-09 23:43 ` Dragan Simic 2023-12-10 0:03 ` Shantur Rathore 2023-12-10 0:03 ` Shantur Rathore 2023-12-10 0:08 ` Dragan Simic 2023-12-10 0:08 ` Dragan Simic 2023-12-14 14:24 ` Shantur Rathore 2023-12-14 14:24 ` Shantur Rathore 2023-12-14 14:35 ` Dragan Simic 2023-12-14 14:35 ` Dragan Simic 2023-12-21 10:11 ` Shantur Rathore 2023-12-21 10:11 ` Shantur Rathore 2023-12-22 0:54 ` Dragan Simic 2023-12-22 0:54 ` Dragan Simic 2023-12-22 11:20 ` Hugh Cole-Baker 2023-12-22 11:20 ` Hugh Cole-Baker 2023-12-22 14:08 ` Shantur Rathore 2023-12-22 14:08 ` Shantur Rathore
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231209233536.350876-1-i@shantur.com \ --to=i@shantur.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linux-rockchip@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.