From: Arnd Bergmann <arnd@kernel.org> To: soc@kernel.org, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Ben Lok <ben.lok@mediatek.com>, Macpaul Lin <macpaul.lin@mediatek.com> Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] arm64: mediatek: remove broken pmic interrupt property Date: Tue, 12 Dec 2023 22:47:22 +0100 [thread overview] Message-ID: <20231212214737.230115-1-arnd@kernel.org> (raw) From: Arnd Bergmann <arnd@arndb.de> The pmic is connected to the GIC, which uses four-cell interrupt properties, but its interrupt is specified as two-cell that would only make sense for the GPIO irqchip: arch/arm64/boot/dts/mediatek/mt8195.dtsi:464.4-27: Warning (interrupts_property): /soc/i2c@11d01000/pmic@34:#interrupt-cells: size is (8), expected multiple of 16 Remove the interrupt for now to shut up the warning. When someone figures out what the correct interrupt and parent are, we can add it back. Fixes: f2b543a191b6 ("arm64: dts: mediatek: add device-tree for Genio 1200 EVK board") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts index 70b465f7c6a7..a409ef998746 100644 --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts @@ -238,8 +238,6 @@ &i2c6 { mt6360: pmic@34 { compatible = "mediatek,mt6360"; reg = <0x34>; - interrupts = <128 IRQ_TYPE_EDGE_FALLING>; - interrupt-names = "IRQB"; interrupt-controller; #interrupt-cells = <1>; pinctrl-0 = <&mt6360_pins>; -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org> To: soc@kernel.org, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Ben Lok <ben.lok@mediatek.com>, Macpaul Lin <macpaul.lin@mediatek.com> Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] arm64: mediatek: remove broken pmic interrupt property Date: Tue, 12 Dec 2023 22:47:22 +0100 [thread overview] Message-ID: <20231212214737.230115-1-arnd@kernel.org> (raw) From: Arnd Bergmann <arnd@arndb.de> The pmic is connected to the GIC, which uses four-cell interrupt properties, but its interrupt is specified as two-cell that would only make sense for the GPIO irqchip: arch/arm64/boot/dts/mediatek/mt8195.dtsi:464.4-27: Warning (interrupts_property): /soc/i2c@11d01000/pmic@34:#interrupt-cells: size is (8), expected multiple of 16 Remove the interrupt for now to shut up the warning. When someone figures out what the correct interrupt and parent are, we can add it back. Fixes: f2b543a191b6 ("arm64: dts: mediatek: add device-tree for Genio 1200 EVK board") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts index 70b465f7c6a7..a409ef998746 100644 --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts @@ -238,8 +238,6 @@ &i2c6 { mt6360: pmic@34 { compatible = "mediatek,mt6360"; reg = <0x34>; - interrupts = <128 IRQ_TYPE_EDGE_FALLING>; - interrupt-names = "IRQB"; interrupt-controller; #interrupt-cells = <1>; pinctrl-0 = <&mt6360_pins>; -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-12-12 21:47 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-12 21:47 Arnd Bergmann [this message] 2023-12-12 21:47 ` [PATCH] arm64: mediatek: remove broken pmic interrupt property Arnd Bergmann 2023-12-13 11:09 ` AngeloGioacchino Del Regno 2023-12-13 11:09 ` AngeloGioacchino Del Regno 2023-12-14 17:54 ` Macpaul Lin 2023-12-14 17:54 ` Macpaul Lin 2023-12-15 7:42 ` Macpaul Lin 2023-12-15 7:42 ` Macpaul Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231212214737.230115-1-arnd@kernel.org \ --to=arnd@kernel.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=arnd@arndb.de \ --cc=ben.lok@mediatek.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=macpaul.lin@mediatek.com \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=soc@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.