From: Aakarsh Jain <aakarsh.jain@samsung.com> To: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, conor+dt@kernel.org, linux-samsung-soc@vger.kernel.org, andi@etezian.org, gost.dev@samsung.com, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, ajaykumar.rs@samsung.com, aakarsh.jain@samsung.com, linux-fsd@tesla.com, Smitha T Murthy <smithatmurthy@gmail.com> Subject: [Patch v6 09/10] media: s5p-mfc: Load firmware for each run in MFCv12. Date: Wed, 13 Dec 2023 13:41:04 +0530 [thread overview] Message-ID: <20231213081105.25817-10-aakarsh.jain@samsung.com> (raw) In-Reply-To: <20231213081105.25817-1-aakarsh.jain@samsung.com> In MFCv12, some section of firmware gets updated at each MFC run. Hence we need to reload original firmware for each run at the start. Cc: linux-fsd@tesla.com Signed-off-by: Smitha T Murthy <smithatmurthy@gmail.com> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c index b49159142c53..503487f34a80 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c @@ -51,8 +51,14 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev) * into kernel. */ mfc_debug_enter(); - if (dev->fw_get_done) - return 0; + /* In case of MFC v12, RET_SYS_INIT response from hardware fails due to + * incorrect firmware transfer and therefore it is not able to initialize + * the hardware. This causes failed response for SYS_INIT command when + * MFC runs for second time. So, load the MFC v12 firmware for each run. + */ + if (!IS_MFCV12(dev)) + if (dev->fw_get_done) + return 0; for (i = MFC_FW_MAX_VERSIONS - 1; i >= 0; i--) { if (!dev->variant->fw_name[i]) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Aakarsh Jain <aakarsh.jain@samsung.com> To: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, conor+dt@kernel.org, linux-samsung-soc@vger.kernel.org, andi@etezian.org, gost.dev@samsung.com, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, ajaykumar.rs@samsung.com, aakarsh.jain@samsung.com, linux-fsd@tesla.com, Smitha T Murthy <smithatmurthy@gmail.com> Subject: [Patch v6 09/10] media: s5p-mfc: Load firmware for each run in MFCv12. Date: Wed, 13 Dec 2023 13:41:04 +0530 [thread overview] Message-ID: <20231213081105.25817-10-aakarsh.jain@samsung.com> (raw) In-Reply-To: <20231213081105.25817-1-aakarsh.jain@samsung.com> In MFCv12, some section of firmware gets updated at each MFC run. Hence we need to reload original firmware for each run at the start. Cc: linux-fsd@tesla.com Signed-off-by: Smitha T Murthy <smithatmurthy@gmail.com> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c index b49159142c53..503487f34a80 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_ctrl.c @@ -51,8 +51,14 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev) * into kernel. */ mfc_debug_enter(); - if (dev->fw_get_done) - return 0; + /* In case of MFC v12, RET_SYS_INIT response from hardware fails due to + * incorrect firmware transfer and therefore it is not able to initialize + * the hardware. This causes failed response for SYS_INIT command when + * MFC runs for second time. So, load the MFC v12 firmware for each run. + */ + if (!IS_MFCV12(dev)) + if (dev->fw_get_done) + return 0; for (i = MFC_FW_MAX_VERSIONS - 1; i >= 0; i--) { if (!dev->variant->fw_name[i]) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-13 11:02 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20231213081112epcas5p171f1b69376bc4b1e8ced03f8b56efe35@epcas5p1.samsung.com> 2023-12-13 8:10 ` [Patch v6 00/10] Add MFC v12 support Aakarsh Jain 2023-12-13 8:10 ` Aakarsh Jain [not found] ` <CGME20231213081115epcas5p395d6fd6fdcf7ce8e20c5b0aba400af12@epcas5p3.samsung.com> 2023-12-13 8:10 ` [Patch v6 01/10] dt-bindings: media: s5p-mfc: Add mfcv12 variant Aakarsh Jain 2023-12-13 8:10 ` Aakarsh Jain [not found] ` <CGME20231213081118epcas5p1bfa3f9790c9c48f1bac20c5683fed00d@epcas5p1.samsung.com> 2023-12-13 8:10 ` [Patch v6 02/10] media: s5p-mfc: Rename IS_MFCV10 macro Aakarsh Jain 2023-12-13 8:10 ` Aakarsh Jain [not found] ` <CGME20231213081121epcas5p1db0ef76c8ae06a2d1b195153c67acbb6@epcas5p1.samsung.com> 2023-12-13 8:10 ` [Patch v6 03/10] media: s5p-mfc: Add initial support for MFCv12 Aakarsh Jain 2023-12-13 8:10 ` Aakarsh Jain [not found] ` <CGME20231213081127epcas5p2555e322569ac3a239f097330d1450cf8@epcas5p2.samsung.com> 2023-12-13 8:10 ` [Patch v6 04/10] media: s5p-mfc: Add YV12 and I420 multiplanar format support Aakarsh Jain 2023-12-13 8:10 ` Aakarsh Jain [not found] ` <CGME20231213081131epcas5p181e1178375a69d021e138b4c16f8da67@epcas5p1.samsung.com> 2023-12-13 8:11 ` [Patch v6 05/10] media: s5p-mfc: Add support for rate controls in MFCv12 Aakarsh Jain 2023-12-13 8:11 ` Aakarsh Jain [not found] ` <CGME20231213081134epcas5p2fdbd2577fe46b848c87ea5d89cbb96f5@epcas5p2.samsung.com> 2023-12-13 8:11 ` [Patch v6 06/10] media: s5p-mfc: Add support for UHD encoding Aakarsh Jain 2023-12-13 8:11 ` Aakarsh Jain [not found] ` <CGME20231213081137epcas5p132baeb4789897e3386b9357b55cc63c4@epcas5p1.samsung.com> 2023-12-13 8:11 ` [Patch v6 07/10] media: s5p-mfc: Add support for DMABUF for encoder Aakarsh Jain 2023-12-13 8:11 ` Aakarsh Jain [not found] ` <CGME20231213081140epcas5p2bf0e2edea2d24224d775b348b1d5ca50@epcas5p2.samsung.com> 2023-12-13 8:11 ` [Patch v6 08/10] media: s5p-mfc: Set context for valid case before calling try_run Aakarsh Jain 2023-12-13 8:11 ` Aakarsh Jain [not found] ` <CGME20231213081143epcas5p1a3acbe09ca033b356a19e2acb2d9411f@epcas5p1.samsung.com> 2023-12-13 8:11 ` Aakarsh Jain [this message] 2023-12-13 8:11 ` [Patch v6 09/10] media: s5p-mfc: Load firmware for each run in MFCv12 Aakarsh Jain [not found] ` <CGME20231213081148epcas5p215061f6452b43e00dd20e5db6b50bbb9@epcas5p2.samsung.com> 2023-12-13 8:11 ` [Patch v6 10/10] media: s5p-mfc: DPB Count Independent of VIDIOC_REQBUF Aakarsh Jain 2023-12-13 8:11 ` Aakarsh Jain 2023-12-13 16:03 ` [Patch v6 00/10] Add MFC v12 support Alim Akhtar 2023-12-13 16:03 ` Alim Akhtar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231213081105.25817-10-aakarsh.jain@samsung.com \ --to=aakarsh.jain@samsung.com \ --cc=ajaykumar.rs@samsung.com \ --cc=alim.akhtar@samsung.com \ --cc=andi@etezian.org \ --cc=andrzej.hajda@intel.com \ --cc=aswani.reddy@samsung.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gost.dev@samsung.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fsd@tesla.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mchehab@kernel.org \ --cc=pankaj.dubey@samsung.com \ --cc=robh+dt@kernel.org \ --cc=smithatmurthy@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.