From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Daniel Mentz <danielmentz@google.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Jhu <chu.stanley@gmail.com>,
Avri Altman <avri.altman@wdc.com>,
Can Guo <quic_cang@quicinc.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Bean Huo <beanhuo@micron.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>
Subject: [PATCH 2/2] scsi: ufs: Remove the ufshcd_hba_exit() call from ufshcd_async_scan()
Date: Mon, 18 Dec 2023 14:52:15 -0800 [thread overview]
Message-ID: <20231218225229.2542156-3-bvanassche@acm.org> (raw)
In-Reply-To: <20231218225229.2542156-1-bvanassche@acm.org>
Calling ufshcd_hba_exit() from a function that is called asynchronously
from ufshcd_init() is wrong because this triggers multiple race
conditions. Instead of calling ufshcd_hba_exit(), log an error message.
Reported-by: Daniel Mentz <danielmentz@google.com>
Fixes: 1d337ec2f35e ("ufs: improve init sequence")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 0ad8bde39cd1..7c59d7a02243 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8982,12 +8982,9 @@ static void ufshcd_async_scan(void *data, async_cookie_t cookie)
out:
pm_runtime_put_sync(hba->dev);
- /*
- * If we failed to initialize the device or the device is not
- * present, turn off the power/clocks etc.
- */
+
if (ret)
- ufshcd_hba_exit(hba);
+ dev_err(hba->dev, "%s failed: %d\n", __func__, ret);
}
static enum scsi_timeout_action ufshcd_eh_timed_out(struct scsi_cmnd *scmd)
next prev parent reply other threads:[~2023-12-18 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:52 [PATCH 0/2] Fix the error path in ufshcd_async_scan() Bart Van Assche
2023-12-18 22:52 ` [PATCH 1/2] scsi: ufs: Simplify power management during async scan Bart Van Assche
2023-12-19 5:04 ` Can Guo
2023-12-20 14:42 ` Manivannan Sadhasivam
2023-12-20 16:36 ` Bart Van Assche
2023-12-20 16:59 ` Manivannan Sadhasivam
2023-12-18 22:52 ` Bart Van Assche [this message]
2023-12-19 5:05 ` [PATCH 2/2] scsi: ufs: Remove the ufshcd_hba_exit() call from ufshcd_async_scan() Can Guo
2023-12-20 14:48 ` Manivannan Sadhasivam
2023-12-20 16:44 ` Bart Van Assche
2023-12-20 16:56 ` Manivannan Sadhasivam
2024-01-04 4:03 ` [PATCH 0/2] Fix the error path in ufshcd_async_scan() Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218225229.2542156-3-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@wdc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=chu.stanley@gmail.com \
--cc=danielmentz@google.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.