From: Paul Cercueil <paul@crapouillou.net> To: "Jonathan Cameron" <jic23@kernel.org>, "Lars-Peter Clausen" <lars@metafoo.de>, "Sumit Semwal" <sumit.semwal@linaro.org>, "Christian König" <christian.koenig@amd.com>, "Vinod Koul" <vkoul@kernel.org>, "Jonathan Corbet" <corbet@lwn.net> Cc: "Paul Cercueil" <paul@crapouillou.net>, "Michael Hennerich" <Michael.Hennerich@analog.com>, linux-doc@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, "Nuno Sá" <noname.nuno@gmail.com>, dmaengine@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v5 3/8] dmaengine: Add API function dmaengine_prep_slave_dma_vec() Date: Tue, 19 Dec 2023 18:50:04 +0100 [thread overview] Message-ID: <20231219175009.65482-4-paul@crapouillou.net> (raw) In-Reply-To: <20231219175009.65482-1-paul@crapouillou.net> This function can be used to initiate a scatter-gather DMA transfer, where the address and size of each segment is located in one entry of the dma_vec array. The major difference with dmaengine_prep_slave_sg() is that it supports specifying the lengths of each DMA transfer; as trying to override the length of the transfer with dmaengine_prep_slave_sg() is a very tedious process. The introduction of a new API function is also justified by the fact that scatterlists are on their way out. Note that dmaengine_prep_interleaved_dma() is not helpful either in that case, as it assumes that the address of each segment will be higher than the one of the previous segment, which we just cannot guarantee in case of a scatter-gather transfer. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- v3: New patch v5: Replace with function dmaengine_prep_slave_dma_vec(), and struct 'dma_vec'. Note that at some point we will need to support cyclic transfers using dmaengine_prep_slave_dma_vec(). Maybe with a new "flags" parameter to the function? --- include/linux/dmaengine.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 3df70d6131c8..ee5931ddb42f 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -160,6 +160,16 @@ struct dma_interleaved_template { struct data_chunk sgl[]; }; +/** + * struct dma_vec - DMA vector + * @addr: Bus address of the start of the vector + * @len: Length in bytes of the DMA vector + */ +struct dma_vec { + dma_addr_t addr; + size_t len; +}; + /** * enum dma_ctrl_flags - DMA flags to augment operation preparation, * control completion, and communicate status. @@ -910,6 +920,10 @@ struct dma_device { struct dma_async_tx_descriptor *(*device_prep_dma_interrupt)( struct dma_chan *chan, unsigned long flags); + struct dma_async_tx_descriptor *(*device_prep_slave_dma_vec)( + struct dma_chan *chan, const struct dma_vec *vecs, + size_t nents, enum dma_transfer_direction direction, + unsigned long flags); struct dma_async_tx_descriptor *(*device_prep_slave_sg)( struct dma_chan *chan, struct scatterlist *sgl, unsigned int sg_len, enum dma_transfer_direction direction, @@ -972,6 +986,17 @@ static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_single( dir, flags, NULL); } +static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_dma_vec( + struct dma_chan *chan, const struct dma_vec *vecs, size_t nents, + enum dma_transfer_direction dir, unsigned long flags) +{ + if (!chan || !chan->device || !chan->device->device_prep_slave_dma_vec) + return NULL; + + return chan->device->device_prep_slave_dma_vec(chan, vecs, nents, + dir, flags); +} + static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_sg( struct dma_chan *chan, struct scatterlist *sgl, unsigned int sg_len, enum dma_transfer_direction dir, unsigned long flags) -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net> To: "Jonathan Cameron" <jic23@kernel.org>, "Lars-Peter Clausen" <lars@metafoo.de>, "Sumit Semwal" <sumit.semwal@linaro.org>, "Christian König" <christian.koenig@amd.com>, "Vinod Koul" <vkoul@kernel.org>, "Jonathan Corbet" <corbet@lwn.net> Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, "Nuno Sá" <noname.nuno@gmail.com>, "Michael Hennerich" <Michael.Hennerich@analog.com>, "Paul Cercueil" <paul@crapouillou.net> Subject: [PATCH v5 3/8] dmaengine: Add API function dmaengine_prep_slave_dma_vec() Date: Tue, 19 Dec 2023 18:50:04 +0100 [thread overview] Message-ID: <20231219175009.65482-4-paul@crapouillou.net> (raw) In-Reply-To: <20231219175009.65482-1-paul@crapouillou.net> This function can be used to initiate a scatter-gather DMA transfer, where the address and size of each segment is located in one entry of the dma_vec array. The major difference with dmaengine_prep_slave_sg() is that it supports specifying the lengths of each DMA transfer; as trying to override the length of the transfer with dmaengine_prep_slave_sg() is a very tedious process. The introduction of a new API function is also justified by the fact that scatterlists are on their way out. Note that dmaengine_prep_interleaved_dma() is not helpful either in that case, as it assumes that the address of each segment will be higher than the one of the previous segment, which we just cannot guarantee in case of a scatter-gather transfer. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- v3: New patch v5: Replace with function dmaengine_prep_slave_dma_vec(), and struct 'dma_vec'. Note that at some point we will need to support cyclic transfers using dmaengine_prep_slave_dma_vec(). Maybe with a new "flags" parameter to the function? --- include/linux/dmaengine.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 3df70d6131c8..ee5931ddb42f 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -160,6 +160,16 @@ struct dma_interleaved_template { struct data_chunk sgl[]; }; +/** + * struct dma_vec - DMA vector + * @addr: Bus address of the start of the vector + * @len: Length in bytes of the DMA vector + */ +struct dma_vec { + dma_addr_t addr; + size_t len; +}; + /** * enum dma_ctrl_flags - DMA flags to augment operation preparation, * control completion, and communicate status. @@ -910,6 +920,10 @@ struct dma_device { struct dma_async_tx_descriptor *(*device_prep_dma_interrupt)( struct dma_chan *chan, unsigned long flags); + struct dma_async_tx_descriptor *(*device_prep_slave_dma_vec)( + struct dma_chan *chan, const struct dma_vec *vecs, + size_t nents, enum dma_transfer_direction direction, + unsigned long flags); struct dma_async_tx_descriptor *(*device_prep_slave_sg)( struct dma_chan *chan, struct scatterlist *sgl, unsigned int sg_len, enum dma_transfer_direction direction, @@ -972,6 +986,17 @@ static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_single( dir, flags, NULL); } +static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_dma_vec( + struct dma_chan *chan, const struct dma_vec *vecs, size_t nents, + enum dma_transfer_direction dir, unsigned long flags) +{ + if (!chan || !chan->device || !chan->device->device_prep_slave_dma_vec) + return NULL; + + return chan->device->device_prep_slave_dma_vec(chan, vecs, nents, + dir, flags); +} + static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_sg( struct dma_chan *chan, struct scatterlist *sgl, unsigned int sg_len, enum dma_transfer_direction dir, unsigned long flags) -- 2.43.0
next prev parent reply other threads:[~2023-12-19 17:50 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-19 17:50 [PATCH v5 0/8] iio: new DMABUF based API, v5 Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-19 17:50 ` [PATCH v5 1/8] iio: buffer-dma: Get rid of outgoing queue Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-21 11:28 ` Jonathan Cameron 2023-12-21 11:28 ` Jonathan Cameron 2023-12-19 17:50 ` [PATCH v5 2/8] iio: buffer-dma: split iio_dma_buffer_fileio_free() function Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-21 11:31 ` Jonathan Cameron 2023-12-21 11:31 ` Jonathan Cameron 2023-12-19 17:50 ` Paul Cercueil [this message] 2023-12-19 17:50 ` [PATCH v5 3/8] dmaengine: Add API function dmaengine_prep_slave_dma_vec() Paul Cercueil 2023-12-21 11:40 ` Jonathan Cameron 2023-12-21 11:40 ` Jonathan Cameron 2023-12-21 15:14 ` Vinod Koul 2023-12-21 15:14 ` Vinod Koul 2023-12-21 15:29 ` Paul Cercueil 2023-12-21 15:29 ` Paul Cercueil 2024-01-08 12:20 ` Paul Cercueil 2024-01-08 12:20 ` Paul Cercueil 2024-01-22 11:06 ` [Linaro-mm-sig] " Vinod Koul 2024-01-22 11:06 ` Vinod Koul 2023-12-19 17:50 ` [PATCH v5 4/8] dmaengine: dma-axi-dmac: Implement device_prep_slave_dma_vec Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-19 17:50 ` [PATCH v5 5/8] iio: core: Add new DMABUF interface infrastructure Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-21 12:06 ` Jonathan Cameron 2023-12-21 12:06 ` Jonathan Cameron 2023-12-21 17:21 ` Paul Cercueil 2023-12-21 17:21 ` Paul Cercueil 2024-01-25 13:47 ` Paul Cercueil 2024-01-25 13:47 ` Paul Cercueil 2024-01-27 16:50 ` Jonathan Cameron 2024-01-27 16:50 ` Jonathan Cameron 2024-01-29 12:52 ` Christian König 2024-01-29 12:52 ` Christian König 2024-01-29 13:06 ` Paul Cercueil 2024-01-29 13:06 ` Paul Cercueil 2024-01-29 13:17 ` Christian König 2024-01-29 13:17 ` Christian König 2024-01-29 13:32 ` Paul Cercueil 2024-01-29 13:32 ` Paul Cercueil 2024-01-29 14:15 ` Paul Cercueil 2024-01-29 14:15 ` Paul Cercueil 2024-01-08 13:20 ` Daniel Vetter 2024-01-08 13:20 ` Daniel Vetter 2023-12-19 17:50 ` [PATCH v5 6/8] iio: buffer-dma: Enable support for DMABUFs Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-21 16:04 ` Jonathan Cameron 2023-12-21 16:04 ` Jonathan Cameron 2023-12-22 8:56 ` Nuno Sá 2023-12-22 8:56 ` Nuno Sá 2023-12-26 15:30 ` Jonathan Cameron 2023-12-26 15:30 ` Jonathan Cameron 2023-12-19 17:50 ` [PATCH v5 7/8] iio: buffer-dmaengine: Support new DMABUF based userspace API Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-21 16:12 ` Jonathan Cameron 2023-12-21 16:12 ` Jonathan Cameron 2023-12-21 17:30 ` Paul Cercueil 2023-12-21 17:30 ` Paul Cercueil 2023-12-22 8:58 ` Nuno Sá 2023-12-22 8:58 ` Nuno Sá 2023-12-26 15:31 ` Jonathan Cameron 2023-12-26 15:31 ` Jonathan Cameron 2023-12-19 17:50 ` [PATCH v5 8/8] Documentation: iio: Document high-speed DMABUF based API Paul Cercueil 2023-12-19 17:50 ` Paul Cercueil 2023-12-21 16:15 ` Jonathan Cameron 2023-12-21 16:15 ` Jonathan Cameron 2023-12-21 16:30 ` [PATCH v5 0/8] iio: new DMABUF based API, v5 Jonathan Cameron 2023-12-21 16:30 ` Jonathan Cameron 2023-12-21 17:56 ` Paul Cercueil 2023-12-21 17:56 ` Paul Cercueil 2023-12-26 15:37 ` Jonathan Cameron 2023-12-26 15:37 ` Jonathan Cameron 2024-01-08 21:12 ` Andrew Davis 2024-01-11 9:20 ` Paul Cercueil 2024-01-11 17:30 ` Andrew Davis 2024-01-12 11:33 ` Paul Cercueil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231219175009.65482-4-paul@crapouillou.net \ --to=paul@crapouillou.net \ --cc=Michael.Hennerich@analog.com \ --cc=christian.koenig@amd.com \ --cc=corbet@lwn.net \ --cc=dmaengine@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jic23@kernel.org \ --cc=lars@metafoo.de \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=noname.nuno@gmail.com \ --cc=sumit.semwal@linaro.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.