From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: jdelvare@suse.com, linux@roeck-us.net
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] hwmon: (acpi_power_meter) Install IPMI handler for Dell systems
Date: Wed, 20 Dec 2023 13:13:50 +0800 [thread overview]
Message-ID: <20231220051350.392350-1-kai.heng.feng@canonical.com> (raw)
The following error can be observed at boot:
[ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130)
[ 3.717928] ACPI Error: Region IPMI (ID=7) has no handler (20230628/exfldio-261)
[ 3.717936] No Local Variables are initialized for Method [_GHL]
[ 3.717938] No Arguments are initialized for method [_GHL]
[ 3.717940] ACPI Error: Aborting method \_SB.PMI0._GHL due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
[ 3.717949] ACPI Error: Aborting method \_SB.PMI0._PMC due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
[ 3.717957] ACPI: \_SB_.PMI0: _PMC evaluation failed: AE_NOT_EXIST
On Dell systems several methods of acpi_power_meter access variables in
IPMI region [0], so request module 'ipmi_si' which will load 'acpi_ipmi'
and install the region handler accordingly.
[0] https://www.dell.com/support/manuals/en-us/redhat-enterprise-linux-v8.0/rhel8_rn_pub/advanced-configuration-and-power-interface-acpi-error-messages-displayed-in-dmesg?guid=guid-0d5ae482-1977-42cf-b417-3ed5c3f5ee62
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/hwmon/acpi_power_meter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
index 703666b95bf4..b9db53166bc9 100644
--- a/drivers/hwmon/acpi_power_meter.c
+++ b/drivers/hwmon/acpi_power_meter.c
@@ -882,6 +882,8 @@ static int acpi_power_meter_add(struct acpi_device *device)
strcpy(acpi_device_name(device), ACPI_POWER_METER_DEVICE_NAME);
strcpy(acpi_device_class(device), ACPI_POWER_METER_CLASS);
device->driver_data = resource;
+ if (dmi_match(DMI_SYS_VENDOR, "Dell Inc."))
+ request_module("ipmi_si");
res = read_capabilities(resource);
if (res)
--
2.34.1
next reply other threads:[~2023-12-20 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 5:13 Kai-Heng Feng [this message]
2023-12-20 15:09 ` [PATCH] hwmon: (acpi_power_meter) Install IPMI handler for Dell systems Armin Wolf
2023-12-20 22:12 ` Kai-Heng Feng
2023-12-20 23:49 ` Guenter Roeck
2023-12-22 3:57 ` Kai-Heng Feng
2023-12-22 12:08 ` Armin Wolf
2023-12-27 3:39 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220051350.392350-1-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.