From: Jason-JH.Lin <jason-jh.lin@mediatek.com> To: Jassi Brar <jassisinghbrar@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-media@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, Jason-ch Chen <jason-ch.chen@mediatek.com>, Johnson Wang <johnson.wang@mediatek.com>, "Jason-JH . Lin" <jason-jh.lin@mediatek.com>, Singo Chang <singo.chang@mediatek.com>, Nancy Lin <nancy.lin@mediatek.com>, Shawn Sung <shawn.sung@mediatek.com>, <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: [PATCH v3 5/9] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler Date: Fri, 22 Dec 2023 12:52:24 +0800 [thread overview] Message-ID: <20231222045228.27826-6-jason-jh.lin@mediatek.com> (raw) In-Reply-To: <20231222045228.27826-1-jason-jh.lin@mediatek.com> 1. Add a loop flag for CMDQ packet struct. CMDQ helper will use a loop flag to mark CMDQ packet as lopping command and make current command buffer jumps to the beginning when GCE executes to the end of command buffer. 2. Add a looping task handle flow in irq handler. GCE irq occurs when GCE executes to the end of command(EOC) instruction. If the CMDQ packet is a loopping command, GCE irq handler can not delete the CMDQ task and disable the GCE thread. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++++++++++ include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 27ff3a3ccf2f..5390b6488ebc 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -267,6 +267,17 @@ static void cmdq_thread_irq_handler(struct cmdq *cmdq, curr_pa = readl(thread->base + CMDQ_THR_CURR_ADDR) << cmdq->pdata->shift; + task = list_first_entry_or_null(&thread->task_busy_list, + struct cmdq_task, list_entry); + if (task && task->pkt->loop) { + struct cmdq_cb_data data; + + data.sta = err; + data.pkt = task->pkt; + mbox_chan_received_data(task->thread->chan, &data); + return; + } + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, list_entry) { task_end_pa = task->pa_base + task->pkt->cmd_buf_size; diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h index a8f0070c7aa9..f78a08e7c6ed 100644 --- a/include/linux/mailbox/mtk-cmdq-mailbox.h +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h @@ -76,6 +76,7 @@ struct cmdq_pkt { size_t cmd_buf_size; /* command occupied size */ size_t buf_size; /* real buffer size */ void *cl; + bool loop; }; u8 cmdq_get_shift_pa(struct mbox_chan *chan); -- 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Jason-JH.Lin <jason-jh.lin@mediatek.com> To: Jassi Brar <jassisinghbrar@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-media@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, Jason-ch Chen <jason-ch.chen@mediatek.com>, Johnson Wang <johnson.wang@mediatek.com>, "Jason-JH . Lin" <jason-jh.lin@mediatek.com>, Singo Chang <singo.chang@mediatek.com>, Nancy Lin <nancy.lin@mediatek.com>, Shawn Sung <shawn.sung@mediatek.com>, <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: [PATCH v3 5/9] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler Date: Fri, 22 Dec 2023 12:52:24 +0800 [thread overview] Message-ID: <20231222045228.27826-6-jason-jh.lin@mediatek.com> (raw) In-Reply-To: <20231222045228.27826-1-jason-jh.lin@mediatek.com> 1. Add a loop flag for CMDQ packet struct. CMDQ helper will use a loop flag to mark CMDQ packet as lopping command and make current command buffer jumps to the beginning when GCE executes to the end of command buffer. 2. Add a looping task handle flow in irq handler. GCE irq occurs when GCE executes to the end of command(EOC) instruction. If the CMDQ packet is a loopping command, GCE irq handler can not delete the CMDQ task and disable the GCE thread. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++++++++++ include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 27ff3a3ccf2f..5390b6488ebc 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -267,6 +267,17 @@ static void cmdq_thread_irq_handler(struct cmdq *cmdq, curr_pa = readl(thread->base + CMDQ_THR_CURR_ADDR) << cmdq->pdata->shift; + task = list_first_entry_or_null(&thread->task_busy_list, + struct cmdq_task, list_entry); + if (task && task->pkt->loop) { + struct cmdq_cb_data data; + + data.sta = err; + data.pkt = task->pkt; + mbox_chan_received_data(task->thread->chan, &data); + return; + } + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, list_entry) { task_end_pa = task->pa_base + task->pkt->cmd_buf_size; diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h index a8f0070c7aa9..f78a08e7c6ed 100644 --- a/include/linux/mailbox/mtk-cmdq-mailbox.h +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h @@ -76,6 +76,7 @@ struct cmdq_pkt { size_t cmd_buf_size; /* command occupied size */ size_t buf_size; /* real buffer size */ void *cl; + bool loop; }; u8 cmdq_get_shift_pa(struct mbox_chan *chan); -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-22 4:52 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-22 4:52 [PATCH v3 0/9] Add CMDQ secure driver for SVP Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 4:52 ` [PATCH v3 1/9] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 4:52 ` [PATCH v3 2/9] dt-bindings: mailbox: Add mboxes property for CMDQ secure driver Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 15:07 ` Conor Dooley 2023-12-22 15:07 ` Conor Dooley 2023-12-23 18:38 ` Jason-JH Lin (林睿祥) 2023-12-23 18:38 ` Jason-JH Lin (林睿祥) 2023-12-22 4:52 ` [PATCH v3 3/9] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 4:52 ` [PATCH v3 4/9] soc: mediatek: cmdq: Add cmdq_pkt_write_s_reg_value to support write value to reg Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin [this message] 2023-12-22 4:52 ` [PATCH v3 5/9] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler Jason-JH.Lin 2023-12-22 4:52 ` [PATCH v3 6/9] soc: mediatek: cmdq: Add cmdq_pkt_finalize_loop for looping cmd with irq Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 4:52 ` [PATCH v3 7/9] mailbox: mediatek: Move reuseable definition to header for secure driver Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-22 4:52 ` [PATCH v3 8/9] mailbox: mediatek: Add CMDQ secure mailbox driver Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin 2023-12-26 6:15 ` CK Hu (胡俊光) 2023-12-26 6:15 ` CK Hu (胡俊光) 2023-12-27 3:40 ` Jason-JH Lin (林睿祥) 2023-12-27 3:40 ` Jason-JH Lin (林睿祥) 2023-12-26 6:46 ` CK Hu (胡俊光) 2023-12-26 6:46 ` CK Hu (胡俊光) 2023-12-27 6:13 ` Jason-JH Lin (林睿祥) 2023-12-27 6:13 ` Jason-JH Lin (林睿祥) 2023-12-28 2:02 ` CK Hu (胡俊光) 2023-12-28 2:02 ` CK Hu (胡俊光) 2024-01-03 6:51 ` Jason-JH Lin (林睿祥) 2024-01-03 6:51 ` Jason-JH Lin (林睿祥) 2023-12-26 7:57 ` CK Hu (胡俊光) 2023-12-26 7:57 ` CK Hu (胡俊光) 2023-12-27 6:15 ` Jason-JH Lin (林睿祥) 2023-12-27 6:15 ` Jason-JH Lin (林睿祥) 2023-12-26 8:28 ` CK Hu (胡俊光) 2023-12-26 8:28 ` CK Hu (胡俊光) 2023-12-27 7:26 ` Jason-JH Lin (林睿祥) 2023-12-27 7:26 ` Jason-JH Lin (林睿祥) 2023-12-26 8:58 ` CK Hu (胡俊光) 2023-12-26 8:58 ` CK Hu (胡俊光) 2023-12-27 7:25 ` Jason-JH Lin (林睿祥) 2023-12-27 7:25 ` Jason-JH Lin (林睿祥) 2023-12-28 1:38 ` CK Hu (胡俊光) 2023-12-28 1:38 ` CK Hu (胡俊光) 2024-01-03 6:53 ` Jason-JH Lin (林睿祥) 2024-01-03 6:53 ` Jason-JH Lin (林睿祥) 2023-12-26 9:18 ` CK Hu (胡俊光) 2023-12-26 9:18 ` CK Hu (胡俊光) 2023-12-27 7:20 ` Jason-JH Lin (林睿祥) 2023-12-27 7:20 ` Jason-JH Lin (林睿祥) 2023-12-28 5:31 ` CK Hu (胡俊光) 2023-12-28 5:31 ` CK Hu (胡俊光) 2024-01-03 6:54 ` Jason-JH Lin (林睿祥) 2024-01-03 6:54 ` Jason-JH Lin (林睿祥) 2023-12-28 7:35 ` CK Hu (胡俊光) 2023-12-28 7:35 ` CK Hu (胡俊光) 2024-01-03 6:55 ` Jason-JH Lin (林睿祥) 2024-01-03 6:55 ` Jason-JH Lin (林睿祥) 2023-12-28 7:37 ` CK Hu (胡俊光) 2023-12-28 7:37 ` CK Hu (胡俊光) 2024-01-03 7:03 ` Jason-JH Lin (林睿祥) 2024-01-03 7:03 ` Jason-JH Lin (林睿祥) 2024-01-04 5:42 ` CK Hu (胡俊光) 2024-01-04 5:42 ` CK Hu (胡俊光) 2024-01-05 6:37 ` Jason-JH Lin (林睿祥) 2024-01-05 6:37 ` Jason-JH Lin (林睿祥) 2023-12-29 1:27 ` CK Hu (胡俊光) 2023-12-29 1:27 ` CK Hu (胡俊光) 2024-01-03 7:14 ` Jason-JH Lin (林睿祥) 2024-01-03 7:14 ` Jason-JH Lin (林睿祥) 2023-12-22 4:52 ` [PATCH v3 9/9] mailbox: mediatek: Add secure CMDQ driver support for CMDQ driver Jason-JH.Lin 2023-12-22 4:52 ` Jason-JH.Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231222045228.27826-6-jason-jh.lin@mediatek.com \ --to=jason-jh.lin@mediatek.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=chunkuang.hu@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jason-ch.chen@mediatek.com \ --cc=jassisinghbrar@gmail.com \ --cc=johnson.wang@mediatek.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=nancy.lin@mediatek.com \ --cc=robh+dt@kernel.org \ --cc=shawn.sung@mediatek.com \ --cc=singo.chang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.