All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Bee <knaerzche@gmail.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Alex Bee <knaerzche@gmail.com>,
	linux-rockchip@lists.infradead.org,
	David Airlie <airlied@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting
Date: Fri, 22 Dec 2023 18:42:12 +0100	[thread overview]
Message-ID: <20231222174220.55249-22-knaerzche@gmail.com> (raw)
In-Reply-To: <20231222174220.55249-1-knaerzche@gmail.com>

inno_hdmi_reset is only ever called when initializing the controller. At
this point it’s completely uneccessary to power up the PHY, since all
what has to work at this point is the DDC bus. The phy will be powered up
correctly when a mode is set in inno_hdmi_encoder_enable and disabled in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
changes in v3:
 - new patch

changes in v4:
 - none

 drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index f3b90b479ab9..52b49f44a4f4 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -202,7 +202,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi)
 	val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH;
 	hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val);
 
-	inno_hdmi_set_pwr_mode(hdmi, NORMAL);
+	inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR);
 }
 
 static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Alex Bee <knaerzche@gmail.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Alex Bee <knaerzche@gmail.com>
Subject: [PATCH v4 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting
Date: Fri, 22 Dec 2023 18:42:12 +0100	[thread overview]
Message-ID: <20231222174220.55249-22-knaerzche@gmail.com> (raw)
In-Reply-To: <20231222174220.55249-1-knaerzche@gmail.com>

inno_hdmi_reset is only ever called when initializing the controller. At
this point it’s completely uneccessary to power up the PHY, since all
what has to work at this point is the DDC bus. The phy will be powered up
correctly when a mode is set in inno_hdmi_encoder_enable and disabled in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
changes in v3:
 - new patch

changes in v4:
 - none

 drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index f3b90b479ab9..52b49f44a4f4 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -202,7 +202,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi)
 	val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH;
 	hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val);
 
-	inno_hdmi_set_pwr_mode(hdmi, NORMAL);
+	inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR);
 }
 
 static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Alex Bee <knaerzche@gmail.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Alex Bee <knaerzche@gmail.com>
Subject: [PATCH v4 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting
Date: Fri, 22 Dec 2023 18:42:12 +0100	[thread overview]
Message-ID: <20231222174220.55249-22-knaerzche@gmail.com> (raw)
In-Reply-To: <20231222174220.55249-1-knaerzche@gmail.com>

inno_hdmi_reset is only ever called when initializing the controller. At
this point it’s completely uneccessary to power up the PHY, since all
what has to work at this point is the DDC bus. The phy will be powered up
correctly when a mode is set in inno_hdmi_encoder_enable and disabled in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
changes in v3:
 - new patch

changes in v4:
 - none

 drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index f3b90b479ab9..52b49f44a4f4 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -202,7 +202,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi)
 	val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH;
 	hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val);
 
-	inno_hdmi_set_pwr_mode(hdmi, NORMAL);
+	inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR);
 }
 
 static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Alex Bee <knaerzche@gmail.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Alex Bee <knaerzche@gmail.com>
Subject: [PATCH v4 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting
Date: Fri, 22 Dec 2023 18:42:12 +0100	[thread overview]
Message-ID: <20231222174220.55249-22-knaerzche@gmail.com> (raw)
In-Reply-To: <20231222174220.55249-1-knaerzche@gmail.com>

inno_hdmi_reset is only ever called when initializing the controller. At
this point it’s completely uneccessary to power up the PHY, since all
what has to work at this point is the DDC bus. The phy will be powered up
correctly when a mode is set in inno_hdmi_encoder_enable and disabled in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
changes in v3:
 - new patch

changes in v4:
 - none

 drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index f3b90b479ab9..52b49f44a4f4 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -202,7 +202,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi)
 	val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH;
 	hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val);
 
-	inno_hdmi_set_pwr_mode(hdmi, NORMAL);
+	inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR);
 }
 
 static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-12-22 17:42 UTC|newest]

Thread overview: 160+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 17:41 [PATCH v4 00/29] Add HDMI support for RK3128 Alex Bee
2023-12-22 17:41 ` Alex Bee
2023-12-22 17:41 ` Alex Bee
2023-12-22 17:41 ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 01/29] dt-bindings: display: rockchip, inno-hdmi: Document RK3128 compatible Alex Bee
2023-12-22 17:41   ` [PATCH v4 01/29] dt-bindings: display: rockchip,inno-hdmi: " Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-29 23:26   ` [PATCH v4 01/29] dt-bindings: display: rockchip, inno-hdmi: " Heiko Stübner
2023-12-29 23:26     ` [PATCH v4 01/29] dt-bindings: display: rockchip,inno-hdmi: " Heiko Stübner
2023-12-29 23:26     ` Heiko Stübner
2023-12-29 23:26     ` Heiko Stübner
2024-01-02 18:54   ` Rob Herring
2024-01-02 18:54     ` Rob Herring
2024-01-02 18:54     ` Rob Herring
2024-01-02 18:54     ` Rob Herring
2023-12-22 17:41 ` [PATCH v4 02/29] drm/rockchip: vop: Add output selection registers for RK312x Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 03/29] drm/rockchip: inno_hdmi: Fix video timing Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 04/29] drm/rockchip: inno_hdmi: Remove useless mode_fixup Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 05/29] drm/rockchip: inno_hdmi: Remove useless copy of drm_display_mode Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 06/29] drm/rockchip: inno_hdmi: Switch encoder hooks to atomic Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 07/29] drm/rockchip: inno_hdmi: Get rid of mode_set Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41 ` [PATCH v4 08/29] drm/rockchip: inno_hdmi: no need to store vic Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:41   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 09/29] drm/rockchip: inno_hdmi: Remove unneeded has audio flag Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 10/29] drm/rockchip: inno_hdmi: Remove useless input format Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 11/29] drm/rockchip: inno_hdmi: Remove YUV-based csc coefficents Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 12/29] drm/rockchip: inno_hdmi: Remove tmds rate from structure Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 13/29] drm/rockchip: inno_hdmi: Drop HDMI Vendor Infoframe support Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 14/29] drm/rockchip: inno_hdmi: Move infoframe disable to separate function Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 15/29] drm/rockchip: inno_hdmi: Switch to infoframe type Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 16/29] drm/rockchip: inno_hdmi: Remove unused drm device pointer Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 17/29] drm/rockchip: inno_hdmi: Drop irq struct member Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 18/29] drm/rockchip: inno_hdmi: Remove useless include Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 19/29] drm/rockchip: inno_hdmi: Subclass connector state Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 20/29] drm/rockchip: inno_hdmi: Correctly setup HDMI quantization range Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` Alex Bee [this message]
2023-12-22 17:42   ` [PATCH v4 21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 22/29] drm/rockchip: inno_hdmi: Split power mode setting Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 23/29] drm/rockchip: inno_hdmi: Add variant support Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 24/29] drm/rockchip: inno_hdmi: Add RK3128 support Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 25/29] drm/rockchip: inno_hdmi: Add basic mode validation Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 26/29] drm/rockchip: inno_hdmi: Drop custom fill_modes hook Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 27/29] ARM: dts: rockchip: Add display subsystem for RK3128 Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 28/29] ARM: dts: rockchip: Add HDMI node " Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42 ` [PATCH v4 29/29] ARM: dts: rockchip: Enable HDMI output for XPI-3128 Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-22 17:42   ` Alex Bee
2023-12-29 23:36 ` (subset) [PATCH v4 00/29] Add HDMI support for RK3128 Heiko Stuebner
2023-12-29 23:36   ` Heiko Stuebner
2023-12-29 23:36   ` Heiko Stuebner
2023-12-29 23:36   ` Heiko Stuebner
2023-12-29 23:42 ` Heiko Stuebner
2023-12-29 23:42   ` Heiko Stuebner
2023-12-29 23:42   ` Heiko Stuebner
2023-12-29 23:42   ` Heiko Stuebner
2024-01-04  8:14 ` Heiko Stuebner
2024-01-04  8:14   ` Heiko Stuebner
2024-01-04  8:14   ` Heiko Stuebner
2024-01-04  8:14   ` Heiko Stuebner
2024-01-05 16:47   ` Alex Bee
2024-01-05 16:47     ` Alex Bee
2024-01-05 16:47     ` Alex Bee
2024-01-05 16:47     ` Alex Bee
2024-01-05 17:02     ` Heiko Stübner
2024-01-05 17:02       ` Heiko Stübner
2024-01-05 17:02       ` Heiko Stübner
2024-01-05 17:02       ` Heiko Stübner
2024-01-05 17:33       ` Alex Bee
2024-01-05 17:33         ` Alex Bee
2024-01-05 17:33         ` Alex Bee
2024-01-05 17:33         ` Alex Bee
2024-01-05 17:50         ` Heiko Stübner
2024-01-05 17:50           ` Heiko Stübner
2024-01-05 17:50           ` Heiko Stübner
2024-01-05 17:50           ` Heiko Stübner
2024-01-25 21:12 ` Heiko Stuebner
2024-01-25 21:12   ` Heiko Stuebner
2024-01-25 21:12   ` Heiko Stuebner
2024-01-25 21:12   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231222174220.55249-22-knaerzche@gmail.com \
    --to=knaerzche@gmail.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.