All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	 Andrzej Hajda <andrzej.hajda@intel.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Aakarsh Jain <aakarsh.jain@samsung.com>,
	linux-fsd@tesla.coma,  linux-samsung-soc@vger.kernel.org,
	 Smitha T Murthy <smithatmurthy@gmail.com>,
	 linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org,  linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops
Date: Sun, 24 Dec 2023 16:44:01 +0100	[thread overview]
Message-ID: <20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org> (raw)
In-Reply-To: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>

File-scope static variable "s5p_mfc_ops" is not read after assignment,
thus it can be dropped entirely.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
index 673962301173..5ba791fa3676 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
@@ -14,18 +14,15 @@
 #include "s5p_mfc_opr_v5.h"
 #include "s5p_mfc_opr_v6.h"
 
-static struct s5p_mfc_hw_ops *s5p_mfc_ops;
-
 void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev)
 {
 	if (IS_MFCV6_PLUS(dev)) {
-		s5p_mfc_ops = s5p_mfc_init_hw_ops_v6();
+		dev->mfc_ops = s5p_mfc_init_hw_ops_v6();
 		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6;
 	} else {
-		s5p_mfc_ops = s5p_mfc_init_hw_ops_v5();
+		dev->mfc_ops = s5p_mfc_init_hw_ops_v5();
 		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START;
 	}
-	dev->mfc_ops = s5p_mfc_ops;
 }
 
 void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	 Andrzej Hajda <andrzej.hajda@intel.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Aakarsh Jain <aakarsh.jain@samsung.com>,
	linux-fsd@tesla.coma,  linux-samsung-soc@vger.kernel.org,
	 Smitha T Murthy <smithatmurthy@gmail.com>,
	 linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org,  linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops
Date: Sun, 24 Dec 2023 16:44:01 +0100	[thread overview]
Message-ID: <20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org> (raw)
In-Reply-To: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>

File-scope static variable "s5p_mfc_ops" is not read after assignment,
thus it can be dropped entirely.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
index 673962301173..5ba791fa3676 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
@@ -14,18 +14,15 @@
 #include "s5p_mfc_opr_v5.h"
 #include "s5p_mfc_opr_v6.h"
 
-static struct s5p_mfc_hw_ops *s5p_mfc_ops;
-
 void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev)
 {
 	if (IS_MFCV6_PLUS(dev)) {
-		s5p_mfc_ops = s5p_mfc_init_hw_ops_v6();
+		dev->mfc_ops = s5p_mfc_init_hw_ops_v6();
 		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6;
 	} else {
-		s5p_mfc_ops = s5p_mfc_init_hw_ops_v5();
+		dev->mfc_ops = s5p_mfc_init_hw_ops_v5();
 		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START;
 	}
-	dev->mfc_ops = s5p_mfc_ops;
 }
 
 void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)

-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-12-24 15:44 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-24 15:43 [PATCH 00/15] media: s5p-mfc: cleanups Krzysztof Kozlowski
2023-12-24 15:43 ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 01/15] media: s5p-mfc: drop unused static s5p_mfc_cmds Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  5:10   ` Aakarsh Jain
2023-12-26  5:10     ` Aakarsh Jain
2023-12-24 15:44 ` Krzysztof Kozlowski [this message]
2023-12-24 15:44   ` [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops Krzysztof Kozlowski
2023-12-26  5:12   ` Aakarsh Jain
2023-12-26  5:12     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 03/15] media: s5p-mfc: drop unused get_*_def_fmt declarations Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  5:18   ` Aakarsh Jain
2023-12-26  5:18     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 04/15] media: s5p-mfc: constify fw_name strings Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  8:53   ` Aakarsh Jain
2023-12-26  8:53     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 05/15] media: s5p-mfc: constify s5p_mfc_buf_size structures Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  5:43   ` Aakarsh Jain
2023-12-26  5:43     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 06/15] media: s5p-mfc: constify s5p_mfc_variant structures Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  5:44   ` Aakarsh Jain
2023-12-26  5:44     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 07/15] media: s5p-mfc: constify s5p_mfc_hw_cmds structures Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  9:02   ` Aakarsh Jain
2023-12-26  9:02     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 08/15] media: s5p-mfc: constify s5p_mfc_hw_ops structures Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 09/15] media: s5p-mfc: constify s5p_mfc_fmt structures Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  6:27   ` Aakarsh Jain
2023-12-26  6:27     ` Aakarsh Jain
2023-12-24 15:44 ` [PATCH 10/15] media: s5p-mfc: constify struct structures Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 11/15] media: s5p-mfc: constify pointers to s5p_mfc_cmd_args Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 12/15] media: s5p-mfc: constify local pointers to s5p_mfc_enc_params Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 13/15] media: s5p-mfc: drop useless clock refcnt debugging Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 14/15] media: s5p-mfc: drop useless static s5p_mfc_dev in s5p_mfc_pm.c Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-24 15:44 ` [PATCH 15/15] media: s5p-mfc: drop static device variable " Krzysztof Kozlowski
2023-12-24 15:44   ` Krzysztof Kozlowski
2023-12-26  6:21   ` Aakarsh Jain
2023-12-26  6:21     ` Aakarsh Jain
2023-12-26  9:06     ` Krzysztof Kozlowski
2023-12-26  9:06       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=aakarsh.jain@samsung.com \
    --cc=andrzej.hajda@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsd@tesla.coma \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=smithatmurthy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.