From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Justin Sanders <justin@coraid.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org
Subject: [PATCH 2/4] aoe: don't abuse BLK_DEF_MAX_SECTORS
Date: Wed, 27 Dec 2023 09:23:03 +0000 [thread overview]
Message-ID: <20231227092305.279567-3-hch@lst.de> (raw)
In-Reply-To: <20231227092305.279567-1-hch@lst.de>
BLK_DEF_MAX_SECTORS despite the confusing name is the default cap for
the max_sectors limits. Don't use it to initialize max_hw_setors, which
is a hardware / driver capacility.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/aoe/aoeblk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
index cf6883756155a3..d2dbf8aaccb5b1 100644
--- a/drivers/block/aoe/aoeblk.c
+++ b/drivers/block/aoe/aoeblk.c
@@ -383,7 +383,8 @@ aoeblk_gdalloc(void *vp)
WARN_ON(d->flags & DEVFL_TKILL);
WARN_ON(d->gd);
WARN_ON(d->flags & DEVFL_UP);
- blk_queue_max_hw_sectors(gd->queue, BLK_DEF_MAX_SECTORS);
+ /* random number picked from the history block max_sectors cap */
+ blk_queue_max_hw_sectors(gd->queue, 2560u);
blk_queue_io_opt(gd->queue, SZ_2M);
d->bufpool = mp;
d->blkq = gd->queue;
--
2.39.2
next prev parent reply other threads:[~2023-12-27 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 9:23 make BLK_DEF_MAX_SECTORS less confusing Christoph Hellwig
2023-12-27 9:23 ` [PATCH 1/4] null_blk: don't cap max_hw_sectors to BLK_DEF_MAX_SECTORS Christoph Hellwig
2023-12-27 9:23 ` Christoph Hellwig [this message]
2023-12-27 9:23 ` [PATCH 3/4] loop: don't abuse BLK_DEF_MAX_SECTORS Christoph Hellwig
2023-12-27 9:23 ` [PATCH 4/4] block: rename and document BLK_DEF_MAX_SECTORS Christoph Hellwig
2023-12-27 17:46 ` make BLK_DEF_MAX_SECTORS less confusing Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227092305.279567-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.