From: Eugen Hristev <eugen.hristev@collabora.com> To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-mediatek@lists.infradead.org Cc: eugen.hristev@collabora.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, kernel@collabora.com, Rob Herring <robh@kernel.org> Subject: [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name Date: Thu, 28 Dec 2023 13:32:41 +0200 [thread overview] Message-ID: <20231228113245.174706-3-eugen.hristev@collabora.com> (raw) In-Reply-To: <20231228113245.174706-1-eugen.hristev@collabora.com> Looking at the binding it makes sense that the `-vp8` compatible has the `venc_lt_sel` while the other bindings have the `venc_sel` as name for the clock. This was also mentioned in the txt version of the binding before the conversion: ` clock-names: avc encoder must contain "venc_sel", vp8 encoder must contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2", ` So it is easier to check for compatible that includes vp8, since that's just one, to have the requirement for the clock name property as `venc_lt_sel`, rather than for all the others, some of which are missing, thus for them, the requirement is wrongly `venc_lt_sel`. Reordered the if/then/else to match `-vp8` and have all the rest of the compatibles using the other clock name (`venc_sel`). Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes in v3: - collect R-B Changes in v2: - new patch. .../bindings/media/mediatek,vcodec-encoder.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index a2051b31fa29..849721c0571a 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -109,10 +109,7 @@ allOf: properties: compatible: enum: - - mediatek,mt8173-vcodec-enc - - mediatek,mt8188-vcodec-enc - - mediatek,mt8192-vcodec-enc - - mediatek,mt8195-vcodec-enc + - mediatek,mt8173-vcodec-enc-vp8 then: properties: @@ -122,8 +119,8 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_sel - else: # for vp8 hw encoder + - const: venc_lt_sel + else: properties: clock: items: @@ -131,7 +128,7 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_lt_sel + - const: venc_sel additionalProperties: false -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Eugen Hristev <eugen.hristev@collabora.com> To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-mediatek@lists.infradead.org Cc: eugen.hristev@collabora.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, kernel@collabora.com, Rob Herring <robh@kernel.org> Subject: [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name Date: Thu, 28 Dec 2023 13:32:41 +0200 [thread overview] Message-ID: <20231228113245.174706-3-eugen.hristev@collabora.com> (raw) In-Reply-To: <20231228113245.174706-1-eugen.hristev@collabora.com> Looking at the binding it makes sense that the `-vp8` compatible has the `venc_lt_sel` while the other bindings have the `venc_sel` as name for the clock. This was also mentioned in the txt version of the binding before the conversion: ` clock-names: avc encoder must contain "venc_sel", vp8 encoder must contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2", ` So it is easier to check for compatible that includes vp8, since that's just one, to have the requirement for the clock name property as `venc_lt_sel`, rather than for all the others, some of which are missing, thus for them, the requirement is wrongly `venc_lt_sel`. Reordered the if/then/else to match `-vp8` and have all the rest of the compatibles using the other clock name (`venc_sel`). Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes in v3: - collect R-B Changes in v2: - new patch. .../bindings/media/mediatek,vcodec-encoder.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index a2051b31fa29..849721c0571a 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -109,10 +109,7 @@ allOf: properties: compatible: enum: - - mediatek,mt8173-vcodec-enc - - mediatek,mt8188-vcodec-enc - - mediatek,mt8192-vcodec-enc - - mediatek,mt8195-vcodec-enc + - mediatek,mt8173-vcodec-enc-vp8 then: properties: @@ -122,8 +119,8 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_sel - else: # for vp8 hw encoder + - const: venc_lt_sel + else: properties: clock: items: @@ -131,7 +128,7 @@ allOf: maxItems: 1 clock-names: items: - - const: venc_lt_sel + - const: venc_sel additionalProperties: false -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-28 11:32 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-28 11:32 [PATCH v3 0/6] video encoder on mt8186 Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev 2023-12-28 11:32 ` [PATCH v3 1/6] media: mediatek: vcodec: fix possible unbalanced PM counter Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev [this message] 2023-12-28 11:32 ` [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name Eugen Hristev 2024-01-02 9:13 ` AngeloGioacchino Del Regno 2024-01-02 9:13 ` AngeloGioacchino Del Regno 2023-12-28 11:32 ` [PATCH v3 3/6] arm64: dts: mediatek: mt8192: fix vencoder " Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev 2024-01-02 9:13 ` AngeloGioacchino Del Regno 2024-01-02 9:13 ` AngeloGioacchino Del Regno 2023-12-28 11:32 ` [PATCH v3 4/6] dt-bindings: media: mtk-vcodec-encoder: add compatible for mt8186 Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev 2024-01-02 9:14 ` AngeloGioacchino Del Regno 2024-01-02 9:14 ` AngeloGioacchino Del Regno 2023-12-28 11:32 ` [PATCH v3 5/6] arm64: dts: mediatek: mt8186: fix VENC power domain clocks Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev 2024-01-02 9:14 ` AngeloGioacchino Del Regno 2024-01-02 9:14 ` AngeloGioacchino Del Regno 2023-12-28 11:32 ` [PATCH v3 6/6] arm64: dts: mediatek: mt8186: Add venc node Eugen Hristev 2023-12-28 11:32 ` Eugen Hristev 2024-01-02 9:14 ` AngeloGioacchino Del Regno 2024-01-02 9:14 ` AngeloGioacchino Del Regno 2024-01-29 10:41 ` (subset) [PATCH v3 0/6] video encoder on mt8186 AngeloGioacchino Del Regno 2024-01-29 10:41 ` AngeloGioacchino Del Regno 2024-01-29 10:47 ` AngeloGioacchino Del Regno 2024-01-29 10:47 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231228113245.174706-3-eugen.hristev@collabora.com \ --to=eugen.hristev@collabora.com \ --cc=andrew-ct.chen@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=kernel@collabora.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=tiffany.lin@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.