From: Thomas Richard <thomas.richard@bootlin.com> To: "Linus Walleij" <linus.walleij@linaro.org>, "Bartosz Golaszewski" <brgl@bgdev.pl>, "Tony Lindgren" <tony@atomide.com>, "Aaro Koskinen" <aaro.koskinen@iki.fi>, "Janusz Krzysztofik" <jmkrzyszt@gmail.com>, "Vignesh R" <vigneshr@ti.com>, "Andi Shyti" <andi.shyti@kernel.org>, "Peter Rosin" <peda@axentia.se>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Rob Herring" <robh@kernel.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Siddharth Vadapalli" <s-vadapalli@ti.com> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com, Thomas Richard <thomas.richard@bootlin.com>, Wolfram Sang <wsa+renesas@sang-engineering.com> Subject: [PATCH v5 02/11] i2c: omap: wakeup the controller during suspend() callback Date: Tue, 16 Apr 2024 15:29:51 +0200 [thread overview] Message-ID: <20240102-j7200-pcie-s2r-v5-2-4b8c46711ded@bootlin.com> (raw) In-Reply-To: <20240102-j7200-pcie-s2r-v5-0-4b8c46711ded@bootlin.com> A device may need the controller up during suspend_noirq() or resume_noirq(). But if the controller is autosuspended, there is no way to wakeup it during suspend_noirq() or resume_noirq() because runtime pm is disabled at this time. The suspend() callback wakes up the controller, so it is available until its suspend_noirq() callback (pm_runtime_force_suspend()). During the resume, it's restored by resume_noirq() callback (pm_runtime_force_resume()). Then resume() callback enables autosuspend. So the controller is up during a little time slot in suspend and resume sequences even if it's not used. Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> --- drivers/i2c/busses/i2c-omap.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 42165ef57946..28417b2a18b0 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1575,9 +1575,31 @@ static int __maybe_unused omap_i2c_runtime_resume(struct device *dev) return 0; } +static int omap_i2c_suspend(struct device *dev) +{ + /* + * If the controller is autosuspended, there is no way to wakeup it once + * runtime pm is disabled (in suspend_late()). + * But a device may need the controller up during suspend_noirq() or + * resume_noirq(). + * Wakeup the controller while runtime pm is enabled, so it is available + * until its suspend_noirq(), and from resume_noirq(). + */ + return pm_runtime_resume_and_get(dev); +} + +static int omap_i2c_resume(struct device *dev) +{ + pm_runtime_mark_last_busy(dev); + pm_runtime_put_autosuspend(dev); + + return 0; +} + static const struct dev_pm_ops omap_i2c_pm_ops = { SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(omap_i2c_suspend, omap_i2c_resume) SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend, omap_i2c_runtime_resume, NULL) }; -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Richard <thomas.richard@bootlin.com> To: "Linus Walleij" <linus.walleij@linaro.org>, "Bartosz Golaszewski" <brgl@bgdev.pl>, "Tony Lindgren" <tony@atomide.com>, "Aaro Koskinen" <aaro.koskinen@iki.fi>, "Janusz Krzysztofik" <jmkrzyszt@gmail.com>, "Vignesh R" <vigneshr@ti.com>, "Andi Shyti" <andi.shyti@kernel.org>, "Peter Rosin" <peda@axentia.se>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Rob Herring" <robh@kernel.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Siddharth Vadapalli" <s-vadapalli@ti.com> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com, Thomas Richard <thomas.richard@bootlin.com>, Wolfram Sang <wsa+renesas@sang-engineering.com> Subject: [PATCH v5 02/11] i2c: omap: wakeup the controller during suspend() callback Date: Tue, 16 Apr 2024 15:29:51 +0200 [thread overview] Message-ID: <20240102-j7200-pcie-s2r-v5-2-4b8c46711ded@bootlin.com> (raw) In-Reply-To: <20240102-j7200-pcie-s2r-v5-0-4b8c46711ded@bootlin.com> A device may need the controller up during suspend_noirq() or resume_noirq(). But if the controller is autosuspended, there is no way to wakeup it during suspend_noirq() or resume_noirq() because runtime pm is disabled at this time. The suspend() callback wakes up the controller, so it is available until its suspend_noirq() callback (pm_runtime_force_suspend()). During the resume, it's restored by resume_noirq() callback (pm_runtime_force_resume()). Then resume() callback enables autosuspend. So the controller is up during a little time slot in suspend and resume sequences even if it's not used. Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> --- drivers/i2c/busses/i2c-omap.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 42165ef57946..28417b2a18b0 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1575,9 +1575,31 @@ static int __maybe_unused omap_i2c_runtime_resume(struct device *dev) return 0; } +static int omap_i2c_suspend(struct device *dev) +{ + /* + * If the controller is autosuspended, there is no way to wakeup it once + * runtime pm is disabled (in suspend_late()). + * But a device may need the controller up during suspend_noirq() or + * resume_noirq(). + * Wakeup the controller while runtime pm is enabled, so it is available + * until its suspend_noirq(), and from resume_noirq(). + */ + return pm_runtime_resume_and_get(dev); +} + +static int omap_i2c_resume(struct device *dev) +{ + pm_runtime_mark_last_busy(dev); + pm_runtime_put_autosuspend(dev); + + return 0; +} + static const struct dev_pm_ops omap_i2c_pm_ops = { SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(omap_i2c_suspend, omap_i2c_resume) SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend, omap_i2c_runtime_resume, NULL) }; -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-16 13:30 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-16 13:29 [PATCH v5 00/11] Add suspend to ram support for PCIe on J7200 Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 01/11] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-23 9:42 ` Geert Uytterhoeven 2024-04-23 9:42 ` Geert Uytterhoeven 2024-04-23 10:34 ` Andy Shevchenko 2024-04-23 10:34 ` Andy Shevchenko 2024-04-23 10:53 ` Thomas Richard 2024-04-23 10:53 ` Thomas Richard 2024-04-23 15:31 ` Geert Uytterhoeven 2024-04-23 15:31 ` Geert Uytterhoeven 2024-04-16 13:29 ` Thomas Richard [this message] 2024-04-16 13:29 ` [PATCH v5 02/11] i2c: omap: wakeup the controller during suspend() callback Thomas Richard 2024-04-19 8:47 ` Andi Shyti 2024-04-19 8:47 ` Andi Shyti 2024-04-22 9:40 ` Thomas Richard 2024-04-22 9:40 ` Thomas Richard 2024-04-22 19:44 ` Bjorn Helgaas 2024-04-22 19:44 ` Bjorn Helgaas 2024-04-24 10:24 ` Thomas Richard 2024-04-24 10:24 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 03/11] mux: add mux_chip_resume() function Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 04/11] mux: mmio: add resume support Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 05/11] PCI: cadence: Extract link setup sequence from cdns_pcie_host_setup() Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 14:16 ` Dan Carpenter 2024-04-16 14:16 ` Dan Carpenter 2024-04-16 16:01 ` Thomas Richard 2024-04-16 16:01 ` Thomas Richard 2024-05-14 13:15 ` Thomas Richard 2024-05-14 13:15 ` Thomas Richard 2024-05-15 7:05 ` Dan Carpenter 2024-05-15 7:05 ` Dan Carpenter 2024-04-16 13:29 ` [PATCH v5 06/11] PCI: cadence: Set cdns_pcie_host_init() global Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 07/11] PCI: j721e: Use dev_err_probe() in the probe() function Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 08/11] PCI: j721e: Add reset GPIO to struct j721e_pcie Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 09/11] PCI: Add T_PERST_CLK_US macro Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:29 ` [PATCH v5 10/11] PCI: j721e: Use " Thomas Richard 2024-04-16 13:29 ` Thomas Richard 2024-04-16 13:30 ` [PATCH v5 11/11] PCI: j721e: Add suspend and resume support Thomas Richard 2024-04-16 13:30 ` Thomas Richard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240102-j7200-pcie-s2r-v5-2-4b8c46711ded@bootlin.com \ --to=thomas.richard@bootlin.com \ --cc=aaro.koskinen@iki.fi \ --cc=andi.shyti@kernel.org \ --cc=bhelgaas@google.com \ --cc=brgl@bgdev.pl \ --cc=gregory.clement@bootlin.com \ --cc=jmkrzyszt@gmail.com \ --cc=kw@linux.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lpieralisi@kernel.org \ --cc=peda@axentia.se \ --cc=robh@kernel.org \ --cc=s-vadapalli@ti.com \ --cc=theo.lebrun@bootlin.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=tony@atomide.com \ --cc=u-kumar1@ti.com \ --cc=vigneshr@ti.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.