All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	 linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Dikshita Agarwal <quic_dikshita@quicinc.com>,
	 Vikash Garodia <quic_vgarodia@quicinc.com>,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH v2 02/18] clk: qcom: reset: Commonize the de/assert functions
Date: Tue, 06 Feb 2024 19:43:35 +0100	[thread overview]
Message-ID: <20240105-topic-venus_reset-v2-2-c37eba13b5ce@linaro.org> (raw)
In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org>

They do the same thing, except the last argument of the last function
call differs. Commonize them.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/clk/qcom/reset.c | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

diff --git a/drivers/clk/qcom/reset.c b/drivers/clk/qcom/reset.c
index e45e32804d2c..20d1d35aaf22 100644
--- a/drivers/clk/qcom/reset.c
+++ b/drivers/clk/qcom/reset.c
@@ -22,8 +22,8 @@ static int qcom_reset(struct reset_controller_dev *rcdev, unsigned long id)
 	return 0;
 }
 
-static int
-qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
+static int qcom_reset_set_assert(struct reset_controller_dev *rcdev,
+				 unsigned long id, bool assert)
 {
 	struct qcom_reset_controller *rst;
 	const struct qcom_reset_map *map;
@@ -33,21 +33,17 @@ qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
 	map = &rst->reset_map[id];
 	mask = map->bitmask ? map->bitmask : BIT(map->bit);
 
-	return regmap_update_bits(rst->regmap, map->reg, mask, mask);
+	return regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0);
 }
 
-static int
-qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id)
+static int qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
 {
-	struct qcom_reset_controller *rst;
-	const struct qcom_reset_map *map;
-	u32 mask;
-
-	rst = to_qcom_reset_controller(rcdev);
-	map = &rst->reset_map[id];
-	mask = map->bitmask ? map->bitmask : BIT(map->bit);
+	return qcom_reset_set_assert(rcdev, id, true);
+}
 
-	return regmap_update_bits(rst->regmap, map->reg, mask, 0);
+static int qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id)
+{
+	return qcom_reset_set_assert(rcdev, id, false);
 }
 
 const struct reset_control_ops qcom_reset_ops = {

-- 
2.43.0


  parent reply	other threads:[~2024-02-06 18:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 18:43 [PATCH v2 00/18] Qualcomm GCC/VIDEOCC reset overhaul for Venus Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 01/18] clk: qcom: reset: Increase max reset delay Konrad Dybcio
2024-02-06 18:43 ` Konrad Dybcio [this message]
2024-02-06 18:43 ` [PATCH v2 03/18] clk: qcom: reset: Ensure write completion on reset de/assertion Konrad Dybcio
2024-02-07  9:07   ` Johan Hovold
2024-02-07 11:52     ` Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 04/18] clk: qcom: gcc-sa8775p: Set delay for Venus CLK resets Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 05/18] clk: qcom: gcc-sc8180x: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 06/18] clk: qcom: gcc-sc8280xp: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 07/18] clk: qcom: gcc-sm4450: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 08/18] clk: qcom: gcc-sm7150: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 09/18] clk: qcom: gcc-sm8250: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 10/18] clk: qcom: gcc-sm8350: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 11/18] clk: qcom: gcc-sm8450: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 12/18] clk: qcom: gcc-sm8550: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 13/18] clk: qcom: gcc-sm8650: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 14/18] clk: qcom: videocc-sm8150: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 15/18] clk: qcom: videocc-sm8250: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 16/18] clk: qcom: videocc-sm8350: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 17/18] clk: qcom: videocc-sm8450: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 18/18] clk: qcom: videocc-sm8550: " Konrad Dybcio
2024-02-07  4:46 ` [PATCH v2 00/18] Qualcomm GCC/VIDEOCC reset overhaul for Venus Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105-topic-venus_reset-v2-2-c37eba13b5ce@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.