All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudiu <claudiu.beznea@tuxon.dev>
To: s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com,
	p.zabel@pengutronix.de, yoshihiro.shimoda.uh@renesas.com,
	wsa+renesas@sang-engineering.com
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org, claudiu.beznea@tuxon.dev,
	geert+renesas@glider.be,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: [PATCH net-next v3 06/19] net: ravb: Assert/de-assert reset on suspend/resume
Date: Fri,  5 Jan 2024 10:23:26 +0200	[thread overview]
Message-ID: <20240105082339.1468817-7-claudiu.beznea.uj@bp.renesas.com> (raw)
In-Reply-To: <20240105082339.1468817-1-claudiu.beznea.uj@bp.renesas.com>

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

RZ/G3S can go to deep sleep states where power to most of the SoC parts is
off. When resuming from such a state, the Ethernet controller needs to be
reinitialized. De-asserting the reset signal for it should also be done.
Thus, add reset assert/de-assert on suspend/resume functions.

On the resume function, the de-assert was not reverted in case of failures
to give the user a chance to restore the interface (e.g., bringing down/up
the interface) in case suspend/resume failed.

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---

Changes in v3:
- collected tags

Changes in v2:
- fixed typos in patch description and subject
- on ravb_suspend() assert the reset signal in case interface is down;
  due to this the Sergey's Rb tag was left aside in this version
  
 drivers/net/ethernet/renesas/ravb_main.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 0731857c2a0c..844ac3306e93 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2978,7 +2978,7 @@ static int ravb_suspend(struct device *dev)
 	int ret;
 
 	if (!netif_running(ndev))
-		return 0;
+		goto reset_assert;
 
 	netif_device_detach(ndev);
 
@@ -2990,7 +2990,11 @@ static int ravb_suspend(struct device *dev)
 	if (priv->info->ccc_gac)
 		ravb_ptp_stop(ndev);
 
-	return ret;
+	if (priv->wol_enabled)
+		return ret;
+
+reset_assert:
+	return reset_control_assert(priv->rstc);
 }
 
 static int ravb_resume(struct device *dev)
@@ -2998,7 +3002,11 @@ static int ravb_resume(struct device *dev)
 	struct net_device *ndev = dev_get_drvdata(dev);
 	struct ravb_private *priv = netdev_priv(ndev);
 	const struct ravb_hw_info *info = priv->info;
-	int ret = 0;
+	int ret;
+
+	ret = reset_control_deassert(priv->rstc);
+	if (ret)
+		return ret;
 
 	/* If WoL is enabled set reset mode to rearm the WoL logic */
 	if (priv->wol_enabled) {
-- 
2.39.2


  parent reply	other threads:[~2024-01-05  8:24 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05  8:23 [PATCH net-next v3 00/19] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 01/19] net: ravb: Let IP-specific receive function to interrogate descriptors Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 02/19] net: ravb: Rely on PM domain to enable gptp_clk Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 03/19] net: ravb: Make reset controller support mandatory Claudiu
2024-01-05  9:38   ` Geert Uytterhoeven
2024-01-08  7:05     ` claudiu beznea
2024-01-05  8:23 ` [PATCH net-next v3 04/19] net: ravb: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr() Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 05/19] net: ravb: Use tabs instead of spaces Claudiu
2024-01-05  8:23 ` Claudiu [this message]
2024-01-05  8:23 ` [PATCH net-next v3 07/19] net: ravb: Move reference clock enable/disable on runtime PM APIs Claudiu
2024-01-05 19:52   ` Sergey Shtylyov
2024-01-08  8:03     ` claudiu beznea
2024-01-23 20:06       ` Sergey Shtylyov
2024-01-05  8:23 ` [PATCH net-next v3 08/19] net: ravb: Move the IRQs get and request in the probe function Claudiu
2024-01-05 20:57   ` Sergey Shtylyov
2024-01-08  8:23     ` claudiu beznea
2024-01-07 18:24   ` Sergey Shtylyov
2024-01-08  8:58     ` claudiu beznea
2024-01-09 20:47       ` Sergey Shtylyov
2024-01-10 11:55         ` claudiu beznea
2024-01-14 18:07           ` Sergey Shtylyov
2024-01-15  7:10             ` claudiu beznea
2024-01-05  8:23 ` [PATCH net-next v3 09/19] net: ravb: Split GTI computation and set operations Claudiu
2024-01-06 19:58   ` Sergey Shtylyov
2024-01-05  8:23 ` [PATCH net-next v3 10/19] net: ravb: Move delay mode set in the driver's ndo_open API Claudiu
2024-01-06 20:26   ` Sergey Shtylyov
2024-01-05  8:23 ` [PATCH net-next v3 11/19] net: ravb: Move DBAT configuration to " Claudiu
2024-01-06 20:34   ` Sergey Shtylyov
2024-01-05  8:23 ` [PATCH net-next v3 12/19] net: ravb: Move PTP initialization in the driver's ndo_open API for ccc_gac platorms Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 13/19] net: ravb: Set config mode in ndo_open and reset mode in ndo_close Claudiu
2024-01-08 19:28   ` Sergey Shtylyov
2024-01-09  5:42     ` claudiu beznea
2024-01-05  8:23 ` [PATCH net-next v3 14/19] net: ravb: Simplify ravb_suspend() Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 15/19] net: ravb: Simplify ravb_resume() Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 16/19] net: ravb: Keep the reverse order of operations in ravb_close() Claudiu
2024-01-05  8:23 ` [PATCH net-next v3 17/19] net: ravb: Return cached statistics if the interface is down Claudiu
2024-01-08 20:22   ` Sergey Shtylyov
2024-01-10 13:17     ` claudiu beznea
2024-01-14 12:22       ` Sergey Shtylyov
2024-01-15  6:08         ` claudiu beznea
2024-01-05  8:23 ` [PATCH net-next v3 18/19] net: ravb: Do not apply RX CSUM settings to hardware " Claudiu
2024-01-08 20:34   ` Sergey Shtylyov
2024-01-08 20:36     ` Sergey Shtylyov
2024-01-08 20:49   ` Sergey Shtylyov
2024-01-05  8:23 ` [PATCH net-next v3 19/19] net: ravb: Add runtime PM support Claudiu
2024-01-09 19:53   ` Sergey Shtylyov
2024-01-10 13:23     ` claudiu beznea
2024-01-05  9:58 ` [PATCH net-next v3 00/19] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105082339.1468817-7-claudiu.beznea.uj@bp.renesas.com \
    --to=claudiu.beznea@tuxon.dev \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=s.shtylyov@omp.ru \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.