From: Kemeng Shi <shikemeng@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
ojaswin@linux.ibm.com
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/9] ext4: remove unneeded return value of ext4_mb_release_context
Date: Fri, 5 Jan 2024 17:20:56 +0800 [thread overview]
Message-ID: <20240105092102.496631-4-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20240105092102.496631-1-shikemeng@huaweicloud.com>
Function ext4_mb_release_context always return 0 and the return value is
never used. Just remove unneeded return value of ext4_mb_release_context.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/mballoc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 765b62729..f79e87ad3 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -5939,7 +5939,7 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac)
/*
* release all resource we used in allocation
*/
-static int ext4_mb_release_context(struct ext4_allocation_context *ac)
+static void ext4_mb_release_context(struct ext4_allocation_context *ac)
{
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
struct ext4_prealloc_space *pa = ac->ac_pa;
@@ -5976,7 +5976,6 @@ static int ext4_mb_release_context(struct ext4_allocation_context *ac)
if (ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC)
mutex_unlock(&ac->ac_lg->lg_mutex);
ext4_mb_collect_stats(ac);
- return 0;
}
static int ext4_mb_discard_preallocations(struct super_block *sb, int needed)
--
2.30.0
next prev parent reply other threads:[~2024-01-05 1:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 9:20 [PATCH v3 0/9] Some random cleanups to mballoc Kemeng Shi
2024-01-05 9:20 ` [PATCH v3 1/9] ext4: remove unused return value of __mb_check_buddy Kemeng Shi
2024-01-05 9:20 ` [PATCH v3 2/9] ext4: remove unused parameter ngroup in ext4_mb_choose_next_group_*() Kemeng Shi
2024-01-05 9:20 ` Kemeng Shi [this message]
2024-01-05 9:20 ` [PATCH v3 4/9] ext4: remove unused ext4_allocation_context::ac_groups_considered Kemeng Shi
2024-01-05 9:20 ` [PATCH v3 5/9] ext4: remove unused return value of ext4_mb_release Kemeng Shi
2024-01-05 9:20 ` [PATCH v3 6/9] ext4: remove unused return value of ext4_mb_release_inode_pa Kemeng Shi
2024-01-05 9:21 ` [PATCH v3 7/9] ext4: remove unused return value of ext4_mb_release_group_pa Kemeng Shi
2024-01-05 9:21 ` [PATCH v3 8/9] ext4: remove unnecessary parameter "needed" in ext4_discard_preallocations Kemeng Shi
2024-01-05 9:21 ` [PATCH v3 9/9] ext4: remove 'needed' in trace_ext4_discard_preallocations Kemeng Shi
2024-02-04 4:57 ` [PATCH v3 0/9] Some random cleanups to mballoc Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105092102.496631-4-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.