From: "Christian Göttsche" <cgzones@googlemail.com>
To: selinux@vger.kernel.org
Subject: [PATCH 3/4] sandbox: do not override warning CFLAGS
Date: Fri, 5 Jan 2024 19:35:33 +0100 [thread overview]
Message-ID: <20240105183534.1110639-3-cgzones@googlemail.com> (raw)
In-Reply-To: <20240105183534.1110639-1-cgzones@googlemail.com>
Do not unconditionally add warning flags and especially -Werror to
CFLAGS, only when CFLAGS is empty.
This helps when building with noisy warning flags, like -Weverything.
Also drop -W, since it is an alias for -Wextra.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
sandbox/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sandbox/Makefile b/sandbox/Makefile
index 360a8bc5..0799ab7c 100644
--- a/sandbox/Makefile
+++ b/sandbox/Makefile
@@ -8,7 +8,8 @@ BINDIR ?= $(PREFIX)/bin
SBINDIR ?= $(PREFIX)/sbin
MANDIR ?= $(PREFIX)/share/man
SHAREDIR ?= $(PREFIX)/share/sandbox
-override CFLAGS += -DPACKAGE="\"policycoreutils\"" -Wall -Werror -Wextra -W
+CFLAGS ?= -Werror -Wall -Wextra
+override CFLAGS += -DPACKAGE="\"policycoreutils\""
override LDLIBS += -lselinux -lcap-ng
SEUNSHARE_OBJS = seunshare.o
--
2.43.0
next prev parent reply other threads:[~2024-01-05 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 18:35 [PATCH 1/4] libsepol: reorder calloc(3) arguments Christian Göttsche
2024-01-05 18:35 ` [PATCH 2/4] libselinux: " Christian Göttsche
2024-01-05 18:35 ` Christian Göttsche [this message]
2024-01-05 18:35 ` [PATCH 4/4] mcstrans: check memory allocations Christian Göttsche
2024-01-05 19:56 ` [PATCH 1/4] libsepol: reorder calloc(3) arguments James Carter
2024-01-25 19:56 ` James Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105183534.1110639-3-cgzones@googlemail.com \
--to=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.