From: Hongbo Li <lihongbo22@huawei.com>
To: <patchwork@huawei.com>, <willy@infradead.org>,
<akpm@linux-foundation.org>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<ruanjinjie@huawei.com>, <lihongbo22@huawei.com>
Subject: [PATCH -next] mm/filemap: avoid type conversion
Date: Mon, 8 Jan 2024 12:48:15 +0800 [thread overview]
Message-ID: <20240108044815.3291487-1-lihongbo22@huawei.com> (raw)
The return type of function folio_test_hugetlb is bool type, there is no
need to assign it to an integer type.
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 750e779c23db..0d7e20edf46f 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -843,7 +843,7 @@ noinline int __filemap_add_folio(struct address_space *mapping,
struct folio *folio, pgoff_t index, gfp_t gfp, void **shadowp)
{
XA_STATE(xas, &mapping->i_pages, index);
- int huge = folio_test_hugetlb(folio);
+ bool huge = folio_test_hugetlb(folio);
bool charged = false;
long nr = 1;
--
2.34.1
next reply other threads:[~2024-01-08 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 4:48 Hongbo Li [this message]
2024-01-08 5:01 ` [PATCH -next] mm/filemap: avoid type conversion Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108044815.3291487-1-lihongbo22@huawei.com \
--to=lihongbo22@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patchwork@huawei.com \
--cc=ruanjinjie@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.