From: Tudor Ambarus <tudor.ambarus@linaro.org> To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH 13/18] tty: serial: samsung: return bool for s3c24xx_serial_txempty_nofifo() Date: Wed, 10 Jan 2024 10:20:57 +0000 [thread overview] Message-ID: <20240110102102.61587-14-tudor.ambarus@linaro.org> (raw) In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> s3c24xx_serial_txempty_nofifo() returned either 0 or BIT(2), which is counterintuitive. Make the method return bool, and return true when TX is empty and false otherwise. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/tty/serial/samsung_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 46fba70f3d77..63e993bed296 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -236,9 +236,9 @@ static inline const char *s3c24xx_serial_portname(const struct uart_port *port) return to_platform_device(port->dev)->name; } -static int s3c24xx_serial_txempty_nofifo(const struct uart_port *port) +static bool s3c24xx_serial_txempty_nofifo(const struct uart_port *port) { - return rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE; + return !!(rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE); } static void s3c24xx_serial_rx_enable(struct uart_port *port) @@ -782,7 +782,7 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport) ch = rd_reg(port, S3C2410_URXH); if (port->flags & UPF_CONS_FLOW) { - int txe = s3c24xx_serial_txempty_nofifo(port); + bool txe = s3c24xx_serial_txempty_nofifo(port); if (ourport->rx_enabled) { if (!txe) { -- 2.43.0.472.g3155946c3a-goog
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@linaro.org> To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH 13/18] tty: serial: samsung: return bool for s3c24xx_serial_txempty_nofifo() Date: Wed, 10 Jan 2024 10:20:57 +0000 [thread overview] Message-ID: <20240110102102.61587-14-tudor.ambarus@linaro.org> (raw) In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> s3c24xx_serial_txempty_nofifo() returned either 0 or BIT(2), which is counterintuitive. Make the method return bool, and return true when TX is empty and false otherwise. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/tty/serial/samsung_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 46fba70f3d77..63e993bed296 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -236,9 +236,9 @@ static inline const char *s3c24xx_serial_portname(const struct uart_port *port) return to_platform_device(port->dev)->name; } -static int s3c24xx_serial_txempty_nofifo(const struct uart_port *port) +static bool s3c24xx_serial_txempty_nofifo(const struct uart_port *port) { - return rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE; + return !!(rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE); } static void s3c24xx_serial_rx_enable(struct uart_port *port) @@ -782,7 +782,7 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport) ch = rd_reg(port, S3C2410_URXH); if (port->flags & UPF_CONS_FLOW) { - int txe = s3c24xx_serial_txempty_nofifo(port); + bool txe = s3c24xx_serial_txempty_nofifo(port); if (ourport->rx_enabled) { if (!txe) { -- 2.43.0.472.g3155946c3a-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-10 10:21 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-10 10:20 [PATCH 00/18] serial: samsung: gs101 updates and winter cleanup Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-10 10:20 ` [PATCH 01/18] tty: serial: samsung: prepare for different IO types Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:12 ` Sam Protsenko 2024-01-16 18:12 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 02/18] tty: serial: samsung: set UPIO_MEM32 iotype for gs101 Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:12 ` Sam Protsenko 2024-01-16 18:12 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 03/18] tty: serial: samsung: add gs101 earlycon support Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:14 ` Sam Protsenko 2024-01-16 18:14 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 04/18] tty: serial: samsung: sort headers alphabetically Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:13 ` Sam Protsenko 2024-01-16 18:13 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 05/18] tty: serial: samsung: explicitly include <linux/types.h> Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:14 ` Sam Protsenko 2024-01-16 18:14 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 06/18] tty: serial: samsung: use u32 for register interactions Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:17 ` Sam Protsenko 2024-01-16 18:17 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 07/18] tty: serial: samsung: remove braces on single statement block Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:17 ` Sam Protsenko 2024-01-16 18:17 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 08/18] tty: serial: samsung: move open brace '{' on the next line Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:18 ` Sam Protsenko 2024-01-16 18:18 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 09/18] tty: serial: samsung: drop superfluous comment Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:18 ` Sam Protsenko 2024-01-16 18:18 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 10/18] tty: serial: samsung: make max_count unsigned int Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:21 ` Sam Protsenko 2024-01-16 18:21 ` Sam Protsenko 2024-01-17 15:21 ` Tudor Ambarus 2024-01-17 15:21 ` Tudor Ambarus 2024-01-17 15:38 ` André Draszik 2024-01-17 15:38 ` André Draszik 2024-01-17 15:54 ` Tudor Ambarus 2024-01-17 15:54 ` Tudor Ambarus 2024-01-17 16:27 ` Sam Protsenko 2024-01-17 16:27 ` Sam Protsenko 2024-01-17 16:26 ` Sam Protsenko 2024-01-17 16:26 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 11/18] tty: serial: samsung: don't compare with zero an if (bitwise expression) Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:38 ` Sam Protsenko 2024-01-16 18:38 ` Sam Protsenko 2024-01-17 15:41 ` Tudor Ambarus 2024-01-17 15:41 ` Tudor Ambarus 2024-01-17 16:24 ` Sam Protsenko 2024-01-17 16:24 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 12/18] tty: serial: samsung: use TIOCSER_TEMT for tx_empty() Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:46 ` Sam Protsenko 2024-01-16 18:46 ` Sam Protsenko 2024-01-10 10:20 ` Tudor Ambarus [this message] 2024-01-10 10:20 ` [PATCH 13/18] tty: serial: samsung: return bool for s3c24xx_serial_txempty_nofifo() Tudor Ambarus 2024-01-16 18:52 ` Sam Protsenko 2024-01-16 18:52 ` Sam Protsenko 2024-01-10 10:20 ` [PATCH 14/18] tty: serial: samsung: return bool for s3c24xx_serial_console_txrdy() Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:54 ` Sam Protsenko 2024-01-16 18:54 ` Sam Protsenko 2024-01-17 15:57 ` Tudor Ambarus 2024-01-17 15:57 ` Tudor Ambarus 2024-01-10 10:20 ` [PATCH 15/18] tty: serial: samsung: change return type for s3c24xx_serial_rx_fifocnt() Tudor Ambarus 2024-01-10 10:20 ` Tudor Ambarus 2024-01-16 18:58 ` Sam Protsenko 2024-01-16 18:58 ` Sam Protsenko 2024-01-10 10:21 ` [PATCH 16/18] tty: serial: samsung: shrink the clock selection to 8 clocks Tudor Ambarus 2024-01-10 10:21 ` Tudor Ambarus 2024-01-16 19:09 ` Sam Protsenko 2024-01-16 19:09 ` Sam Protsenko 2024-01-17 16:26 ` Tudor Ambarus 2024-01-17 16:26 ` Tudor Ambarus 2024-01-17 16:31 ` Sam Protsenko 2024-01-17 16:31 ` Sam Protsenko 2024-01-10 10:21 ` [PATCH 17/18] tty: serial: samsung: shrink port feature flags to u8 Tudor Ambarus 2024-01-10 10:21 ` Tudor Ambarus 2024-01-16 19:03 ` Sam Protsenko 2024-01-16 19:03 ` Sam Protsenko 2024-01-19 8:56 ` Tudor Ambarus 2024-01-19 8:56 ` Tudor Ambarus 2024-01-19 9:07 ` Jiri Slaby 2024-01-19 9:07 ` Jiri Slaby 2024-01-19 9:43 ` Tudor Ambarus 2024-01-19 9:43 ` Tudor Ambarus 2024-01-19 9:54 ` Jiri Slaby 2024-01-19 9:54 ` Jiri Slaby 2024-01-19 10:02 ` Tudor Ambarus 2024-01-19 10:02 ` Tudor Ambarus 2024-01-10 10:21 ` [PATCH 18/18] tty: serial: samsung: shrink memory footprint of ``struct s3c24xx_uart_info`` Tudor Ambarus 2024-01-10 10:21 ` Tudor Ambarus 2024-01-16 19:14 ` Sam Protsenko 2024-01-16 19:14 ` Sam Protsenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240110102102.61587-14-tudor.ambarus@linaro.org \ --to=tudor.ambarus@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andre.draszik@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.