From: Lucas De Marchi <lucas.demarchi@intel.com> To: linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org Cc: Brendan Higgins <brendan.higgins@linux.dev>, Lucas De Marchi <lucas.demarchi@intel.com>, intel-xe@lists.freedesktop.org, David Gow <davidgow@google.com> Subject: [PATCH] kunit: Mark filter_glob param as rw Date: Thu, 11 Jan 2024 16:12:40 -0800 [thread overview] Message-ID: <20240112001240.1710962-1-lucas.demarchi@intel.com> (raw) By allowing the filter_glob parameter to be written to, it's possible to tweak the testsuites that will be executed on new module loads. This makes it easier to run specific tests without having to reload kunit and provides a way to filter tests on real HW even if kunit is builtin. Example for xe driver: 1) Run just 1 test # echo -n xe_bo > /sys/module/kunit/parameters/filter_glob # modprobe -r xe_live_test # modprobe xe_live_test # ls /sys/kernel/debug/kunit/ xe_bo 2) Run all tests # echo \* > /sys/module/kunit/parameters/filter_glob # modprobe -r xe_live_test # modprobe xe_live_test # ls /sys/kernel/debug/kunit/ xe_bo xe_dma_buf xe_migrate xe_mocs References: https://lore.kernel.org/intel-xe/dzacvbdditbneiu3e3fmstjmttcbne44yspumpkd6sjn56jqpk@vxu7sksbqrp6/ Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- lib/kunit/executor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c index 1236b3cd2fbb..30ed9d321c19 100644 --- a/lib/kunit/executor.c +++ b/lib/kunit/executor.c @@ -31,7 +31,7 @@ static char *filter_glob_param; static char *filter_param; static char *filter_action_param; -module_param_named(filter_glob, filter_glob_param, charp, 0400); +module_param_named(filter_glob, filter_glob_param, charp, 0600); MODULE_PARM_DESC(filter_glob, "Filter which KUnit test suites/tests run at boot-time, e.g. list* or list*.*del_test"); module_param_named(filter, filter_param, charp, 0400); -- 2.40.1
WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com> To: linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org Cc: David Gow <davidgow@google.com>, Brendan Higgins <brendan.higgins@linux.dev>, <intel-xe@lists.freedesktop.org>, Lucas De Marchi <lucas.demarchi@intel.com> Subject: [PATCH] kunit: Mark filter_glob param as rw Date: Thu, 11 Jan 2024 16:12:40 -0800 [thread overview] Message-ID: <20240112001240.1710962-1-lucas.demarchi@intel.com> (raw) By allowing the filter_glob parameter to be written to, it's possible to tweak the testsuites that will be executed on new module loads. This makes it easier to run specific tests without having to reload kunit and provides a way to filter tests on real HW even if kunit is builtin. Example for xe driver: 1) Run just 1 test # echo -n xe_bo > /sys/module/kunit/parameters/filter_glob # modprobe -r xe_live_test # modprobe xe_live_test # ls /sys/kernel/debug/kunit/ xe_bo 2) Run all tests # echo \* > /sys/module/kunit/parameters/filter_glob # modprobe -r xe_live_test # modprobe xe_live_test # ls /sys/kernel/debug/kunit/ xe_bo xe_dma_buf xe_migrate xe_mocs References: https://lore.kernel.org/intel-xe/dzacvbdditbneiu3e3fmstjmttcbne44yspumpkd6sjn56jqpk@vxu7sksbqrp6/ Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- lib/kunit/executor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c index 1236b3cd2fbb..30ed9d321c19 100644 --- a/lib/kunit/executor.c +++ b/lib/kunit/executor.c @@ -31,7 +31,7 @@ static char *filter_glob_param; static char *filter_param; static char *filter_action_param; -module_param_named(filter_glob, filter_glob_param, charp, 0400); +module_param_named(filter_glob, filter_glob_param, charp, 0600); MODULE_PARM_DESC(filter_glob, "Filter which KUnit test suites/tests run at boot-time, e.g. list* or list*.*del_test"); module_param_named(filter, filter_param, charp, 0400); -- 2.40.1
next reply other threads:[~2024-01-12 0:13 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-12 0:12 Lucas De Marchi [this message] 2024-01-12 0:12 ` [PATCH] kunit: Mark filter_glob param as rw Lucas De Marchi 2024-01-12 1:36 ` ✓ CI.Patch_applied: success for " Patchwork 2024-01-12 1:37 ` ✗ CI.checkpatch: warning " Patchwork 2024-01-12 1:37 ` ✓ CI.KUnit: success " Patchwork 2024-01-12 1:45 ` ✓ CI.Build: " Patchwork 2024-01-12 1:45 ` ✓ CI.Hooks: " Patchwork 2024-01-12 1:46 ` ✓ CI.checksparse: " Patchwork 2024-01-12 2:11 ` ✓ CI.BAT: " Patchwork 2024-01-18 22:23 ` [PATCH] " Rae Moar 2024-01-18 22:23 ` Rae Moar 2024-01-18 23:29 ` Lucas De Marchi 2024-01-18 23:29 ` Lucas De Marchi 2024-01-22 10:28 ` Krzysztofik, Janusz 2024-01-22 10:28 ` Krzysztofik, Janusz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240112001240.1710962-1-lucas.demarchi@intel.com \ --to=lucas.demarchi@intel.com \ --cc=brendan.higgins@linux.dev \ --cc=davidgow@google.com \ --cc=intel-xe@lists.freedesktop.org \ --cc=kunit-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.