From: Su Hui <suhui@nfschina.com>
To: artur.paszkiewicz@intel.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, nathan@kernel.org,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com
Cc: Su Hui <suhui@nfschina.com>,
dan.j.williams@intel.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
kernel-janitors@vger.kernel.org
Subject: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
Date: Fri, 12 Jan 2024 12:19:27 +0800 [thread overview]
Message-ID: <20240112041926.3924315-1-suhui@nfschina.com> (raw)
Clang static complains that Value stored to 'status' is never read.
Return 'status' rather than 'SCI_SUCCESS'.
Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/scsi/isci/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index 71f711cb0628..355a0bc0828e 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost,
return SCI_FAILURE;
}
- return SCI_SUCCESS;
+ return status;
}
static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)
--
2.30.2
next reply other threads:[~2024-01-12 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 4:19 Su Hui [this message]
2024-01-15 8:45 ` [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build Artur Paszkiewicz
2024-01-17 19:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112041926.3924315-1-suhui@nfschina.com \
--to=suhui@nfschina.com \
--cc=artur.paszkiewicz@intel.com \
--cc=dan.j.williams@intel.com \
--cc=jejb@linux.ibm.com \
--cc=justinstitt@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.