All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Gondois <pierre.gondois@arm.com>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Pierre Gondois <pierre.gondois@arm.com>
Subject: [PATCH 1/5] trace-cmd: split: Small fixes
Date: Fri, 12 Jan 2024 09:39:41 +0100	[thread overview]
Message-ID: <20240112083945.1361293-2-pierre.gondois@arm.com> (raw)
In-Reply-To: <20240112083945.1361293-1-pierre.gondois@arm.com>

Small fixes:
- Remove a useless assignment to 'current' variable.
- Fix returned type of parse_file()

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 tracecmd/trace-split.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index 4fda7813..6ccda2fc 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -347,11 +347,12 @@ static int parse_cpu(struct tracecmd_input *handle,
 	return 0;
 }
 
-static double parse_file(struct tracecmd_input *handle,
-			 const char *output_file,
-			 unsigned long long start,
-			 unsigned long long end, int percpu, int only_cpu,
-			 int count, enum split_types type)
+static unsigned long long parse_file(struct tracecmd_input *handle,
+				     const char *output_file,
+				     unsigned long long start,
+				     unsigned long long end, int percpu,
+				     int only_cpu, int count,
+				     enum split_types type)
 {
 	unsigned long long current;
 	struct tracecmd_output *ohandle;
@@ -551,7 +552,6 @@ void trace_split (int argc, char **argv)
 		strcat(output, ".1");
 	}
 
-	current = start_ns;
 	output_file = malloc(strlen(output) + 50);
 	if (!output_file)
 		die("Failed to allocate for %s", output);
-- 
2.25.1


  reply	other threads:[~2024-01-12  8:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  8:39 [PATCH 0/5] trace-cmd: split: Handle splitting files with multiple instances Pierre Gondois
2024-01-12  8:39 ` Pierre Gondois [this message]
2024-01-12  8:39 ` [PATCH 2/5] trace-cmd: usage: Update usage for trace-cmd split Pierre Gondois
2024-01-12 15:37   ` Steven Rostedt
2024-01-15 17:22     ` Pierre Gondois
2024-01-19 17:31       ` Steven Rostedt
2024-01-12  8:39 ` [PATCH 3/5] trace-cmd: split: Store instances in local list Pierre Gondois
2024-01-12  8:39 ` [PATCH 4/5] trace-cmd: split: Add functions to generate temp files Pierre Gondois
2024-01-12  8:39 ` [PATCH 5/5] trace-cmd: split: Handle splitting files with multiple instances Pierre Gondois
2024-01-12 16:18   ` Steven Rostedt
2024-01-15 17:25     ` Pierre Gondois
2024-01-15 18:56       ` Steven Rostedt
2024-01-19 16:41     ` Pierre Gondois
2024-01-19 17:06       ` Pierre Gondois
2024-01-19 17:25         ` Steven Rostedt
2024-01-12 15:36 ` [PATCH 0/5] " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112083945.1361293-2-pierre.gondois@arm.com \
    --to=pierre.gondois@arm.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.