All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elias El Yandouzi <eliasely@amazon.com>
To: <xen-devel@lists.xenproject.org>
Cc: julien@xen.org, pdurrant@amazon.com, dwmw@amazon.com,
	"Julien Grall" <jgrall@amazon.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"Elias El Yandouzi" <eliasely@amazon.com>
Subject: [PATCH v2] xen/x86: Add support for the PMAP
Date: Tue, 16 Jan 2024 18:50:44 +0000	[thread overview]
Message-ID: <20240116185056.15000-16-eliasely@amazon.com> (raw)
In-Reply-To: <20240116185056.15000-1-eliasely@amazon.com>

From: Julien Grall <jgrall@amazon.com>

PMAP will be used in a follow-up patch to bootstrap map domain
page infrastructure -- we need some way to map pages to setup the
mapcache without a direct map.

The functions pmap_{map, unmap} open code {set, clear}_fixmap to break
the loop.

Signed-off-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Elias El Yandouzi <eliasely@amazon.com>

----

    The PMAP infrastructure was upstream separately for Arm since
    Hongyan sent the secret-free hypervisor series. So this is a new
    patch to plumb the feature on x86.

    Changes in v2:
        * Declare PMAP entries earlier in fixed_addresses
        * Reword the commit message

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 350f41b832..16b2a32469 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -25,6 +25,7 @@ config X86
 	select HAS_PASSTHROUGH
 	select HAS_PCI
 	select HAS_PCI_MSI
+	select HAS_PMAP
 	select HAS_SCHED_GRANULARITY
 	select HAS_UBSAN
 	select HAS_VPCI if HVM
diff --git a/xen/arch/x86/include/asm/fixmap.h b/xen/arch/x86/include/asm/fixmap.h
index 516ec3fa6c..a7ac365fc6 100644
--- a/xen/arch/x86/include/asm/fixmap.h
+++ b/xen/arch/x86/include/asm/fixmap.h
@@ -21,6 +21,8 @@
 
 #include <xen/acpi.h>
 #include <xen/pfn.h>
+#include <xen/pmap.h>
+
 #include <asm/apicdef.h>
 #include <asm/msi.h>
 #include <acpi/apei.h>
@@ -53,6 +55,8 @@ enum fixed_addresses {
     FIX_PV_CONSOLE,
     FIX_XEN_SHARED_INFO,
 #endif /* CONFIG_XEN_GUEST */
+    FIX_PMAP_BEGIN,
+    FIX_PMAP_END = FIX_PMAP_BEGIN + NUM_FIX_PMAP,
     /* Everything else should go further down. */
     FIX_APIC_BASE,
     FIX_IO_APIC_BASE_0,
diff --git a/xen/arch/x86/include/asm/pmap.h b/xen/arch/x86/include/asm/pmap.h
new file mode 100644
index 0000000000..62746e191d
--- /dev/null
+++ b/xen/arch/x86/include/asm/pmap.h
@@ -0,0 +1,25 @@
+#ifndef __ASM_PMAP_H__
+#define __ASM_PMAP_H__
+
+#include <asm/fixmap.h>
+
+static inline void arch_pmap_map(unsigned int slot, mfn_t mfn)
+{
+    unsigned long linear = (unsigned long)fix_to_virt(slot);
+    l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)];
+
+    ASSERT(!(l1e_get_flags(*pl1e) & _PAGE_PRESENT));
+
+    l1e_write_atomic(pl1e, l1e_from_mfn(mfn, PAGE_HYPERVISOR));
+}
+
+static inline void arch_pmap_unmap(unsigned int slot)
+{
+    unsigned long linear = (unsigned long)fix_to_virt(slot);
+    l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)];
+
+    l1e_write_atomic(pl1e, l1e_empty());
+    flush_tlb_one_local(linear);
+}
+
+#endif /* __ASM_PMAP_H__ */
-- 
2.40.1



  parent reply	other threads:[~2024-01-16 18:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16 18:50 [PATCH v2] Remove the directmap Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/vmap: Check the page has been mapped in vm_init_type() Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: Move vm_init() before acpi calls Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/vmap: Introduce vmap_size() and use it Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] acpi: vmap pages in acpi_os_alloc_memory Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/numa: vmap the pages for memnodemap Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/srat: vmap the pages for acpi_slit Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86: Map/unmap pages in restore_all_guests Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/pv: Domheap pages should be mapped while relocating initrd Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/pv: Rewrite how building PV dom0 handles domheap mappings Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/pv: Map L4 page table for shim domain Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86: Lift mapcache variable to the arch level Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/mapcache: Initialise the mapcache for the idle domain Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86: Add a boot option to enable and disable the direct map Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm: fixmap: Rename the fixmap slots to follow the x86 convention Elias El Yandouzi
2024-01-16 18:50 ` Elias El Yandouzi [this message]
2024-01-16 18:50 ` [PATCH v2] xen/x86: Add build assertion for fixmap entries Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/domain_page: Remove the fast paths when mfn is not in the directmap Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/page_alloc: Add a path for xenheap when there is no direct map Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: Leave early boot slightly earlier Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: vmap heap nodes when they are outside the direct map Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: Do not create valid mappings when directmap=no Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] Rename mfn_to_virt() calls Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] Rename maddr_to_virt() calls Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm32: mm: Rename 'first' to 'root' in init_secondary_pagetables() Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm64: mm: Use per-pCPU page-tables Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm64: Implement a mapcache for arm64 Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm64: Allow the admin to enable/disable the directmap Elias El Yandouzi
2024-01-16 19:22 ` [PATCH v2] Remove " Elias El Yandouzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116185056.15000-16-eliasely@amazon.com \
    --to=eliasely@amazon.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dwmw@amazon.com \
    --cc=jbeulich@suse.com \
    --cc=jgrall@amazon.com \
    --cc=julien@xen.org \
    --cc=pdurrant@amazon.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.