All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elias El Yandouzi <eliasely@amazon.com>
To: <xen-devel@lists.xenproject.org>
Cc: julien@xen.org, pdurrant@amazon.com, dwmw@amazon.com,
	"Hongyan Xia" <hongyxia@amazon.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"Julien Grall" <jgrall@amazon.com>,
	"Elias El Yandouzi" <eliasely@amazon.com>
Subject: [PATCH v2] x86/srat: vmap the pages for acpi_slit
Date: Tue, 16 Jan 2024 18:50:35 +0000	[thread overview]
Message-ID: <20240116185056.15000-7-eliasely@amazon.com> (raw)
In-Reply-To: <20240116185056.15000-1-eliasely@amazon.com>

From: Hongyan Xia <hongyxia@amazon.com>

This avoids the assumption that boot pages are in the direct map.

Signed-off-by: Hongyan Xia <hongyxia@amazon.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Elias El Yandouzi <eliasely@amazon.com>

----

    There was a discussion with Jan regarding early failure vs
    disable NUMA. I am strongly in favor of the latter because
    it is more obvious that something went wrong.

    From my understanding, Jan seems to be in favor of turning off NUMA
    and then continue to boot. But then implied that a panic() would be
    fine.

    So I went with the panic() version. I am happy to rework it to another
    approach if there is a consensus.

    Changes in v2:
        * vmap_contig_pages() was renamed to vmap_contig()
        * Use a panic() rather than BUG_ON()

    Changes since Hongyan's version:
        * vmap_boot_pages() was renamed to vmap_contig_pages()

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index 3f70338e6e..688f410287 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -135,7 +135,9 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit)
 		return;
 	}
 	mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1);
-	acpi_slit = mfn_to_virt(mfn_x(mfn));
+	acpi_slit = vmap_contig(mfn, PFN_UP(slit->header.length));
+	if ( !acpi_slit )
+		panic("Unable to map the ACPI SLIT. Retry with numa=off");
 	memcpy(acpi_slit, slit, slit->header.length);
 }
 
-- 
2.40.1



  parent reply	other threads:[~2024-01-16 18:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16 18:50 [PATCH v2] Remove the directmap Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/vmap: Check the page has been mapped in vm_init_type() Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: Move vm_init() before acpi calls Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/vmap: Introduce vmap_size() and use it Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] acpi: vmap pages in acpi_os_alloc_memory Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/numa: vmap the pages for memnodemap Elias El Yandouzi
2024-01-16 18:50 ` Elias El Yandouzi [this message]
2024-01-16 18:50 ` [PATCH v2] x86: Map/unmap pages in restore_all_guests Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/pv: Domheap pages should be mapped while relocating initrd Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/pv: Rewrite how building PV dom0 handles domheap mappings Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/pv: Map L4 page table for shim domain Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86: Lift mapcache variable to the arch level Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/mapcache: Initialise the mapcache for the idle domain Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86: Add a boot option to enable and disable the direct map Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm: fixmap: Rename the fixmap slots to follow the x86 convention Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/x86: Add support for the PMAP Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/x86: Add build assertion for fixmap entries Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/domain_page: Remove the fast paths when mfn is not in the directmap Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/page_alloc: Add a path for xenheap when there is no direct map Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: Leave early boot slightly earlier Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: vmap heap nodes when they are outside the direct map Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] x86/setup: Do not create valid mappings when directmap=no Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] Rename mfn_to_virt() calls Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] Rename maddr_to_virt() calls Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm32: mm: Rename 'first' to 'root' in init_secondary_pagetables() Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm64: mm: Use per-pCPU page-tables Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm64: Implement a mapcache for arm64 Elias El Yandouzi
2024-01-16 18:50 ` [PATCH v2] xen/arm64: Allow the admin to enable/disable the directmap Elias El Yandouzi
2024-01-16 19:22 ` [PATCH v2] Remove " Elias El Yandouzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116185056.15000-7-eliasely@amazon.com \
    --to=eliasely@amazon.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dwmw@amazon.com \
    --cc=hongyxia@amazon.com \
    --cc=jbeulich@suse.com \
    --cc=jgrall@amazon.com \
    --cc=julien@xen.org \
    --cc=pdurrant@amazon.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.