From: kernel test robot <lkp@intel.com>
To: Babu Moger <babu.moger@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
x86@kernel.org, "Borislav Petkov (AMD)" <bp@alien8.de>,
Reinette Chatre <reinette.chatre@intel.com>
Subject: [tip:x86/cache 3/3] arch/x86/kernel/cpu/resctrl/rdtgroup.c:1621:5-8: Unneeded variable: "ret". Return " 0" on line 1655
Date: Wed, 24 Jan 2024 18:31:41 +0800 [thread overview]
Message-ID: <202401241810.jbd8Ipa1-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cache
head: 54e35eb8611cce5550d3d7689679b1a91c864f28
commit: 54e35eb8611cce5550d3d7689679b1a91c864f28 [3/3] x86/resctrl: Read supported bandwidth sources from CPUID
config: x86_64-randconfig-102-20240124 (https://download.01.org/0day-ci/archive/20240124/202401241810.jbd8Ipa1-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401241810.jbd8Ipa1-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/resctrl/rdtgroup.c:1621:5-8: Unneeded variable: "ret". Return " 0" on line 1655
vim +1621 arch/x86/kernel/cpu/resctrl/rdtgroup.c
92bd5a1390335b Babu Moger 2023-01-13 1616
92bd5a1390335b Babu Moger 2023-01-13 1617 static int mbm_config_write_domain(struct rdt_resource *r,
92bd5a1390335b Babu Moger 2023-01-13 1618 struct rdt_domain *d, u32 evtid, u32 val)
92bd5a1390335b Babu Moger 2023-01-13 1619 {
92bd5a1390335b Babu Moger 2023-01-13 1620 struct mon_config_info mon_info = {0};
92bd5a1390335b Babu Moger 2023-01-13 @1621 int ret = 0;
92bd5a1390335b Babu Moger 2023-01-13 1622
92bd5a1390335b Babu Moger 2023-01-13 1623 /*
92bd5a1390335b Babu Moger 2023-01-13 1624 * Read the current config value first. If both are the same then
92bd5a1390335b Babu Moger 2023-01-13 1625 * no need to write it again.
92bd5a1390335b Babu Moger 2023-01-13 1626 */
92bd5a1390335b Babu Moger 2023-01-13 1627 mon_info.evtid = evtid;
92bd5a1390335b Babu Moger 2023-01-13 1628 mondata_config_read(d, &mon_info);
92bd5a1390335b Babu Moger 2023-01-13 1629 if (mon_info.mon_config == val)
92bd5a1390335b Babu Moger 2023-01-13 1630 goto out;
92bd5a1390335b Babu Moger 2023-01-13 1631
92bd5a1390335b Babu Moger 2023-01-13 1632 mon_info.mon_config = val;
92bd5a1390335b Babu Moger 2023-01-13 1633
92bd5a1390335b Babu Moger 2023-01-13 1634 /*
92bd5a1390335b Babu Moger 2023-01-13 1635 * Update MSR_IA32_EVT_CFG_BASE MSR on one of the CPUs in the
92bd5a1390335b Babu Moger 2023-01-13 1636 * domain. The MSRs offset from MSR MSR_IA32_EVT_CFG_BASE
92bd5a1390335b Babu Moger 2023-01-13 1637 * are scoped at the domain level. Writing any of these MSRs
92bd5a1390335b Babu Moger 2023-01-13 1638 * on one CPU is observed by all the CPUs in the domain.
92bd5a1390335b Babu Moger 2023-01-13 1639 */
92bd5a1390335b Babu Moger 2023-01-13 1640 smp_call_function_any(&d->cpu_mask, mon_event_config_write,
92bd5a1390335b Babu Moger 2023-01-13 1641 &mon_info, 1);
92bd5a1390335b Babu Moger 2023-01-13 1642
92bd5a1390335b Babu Moger 2023-01-13 1643 /*
92bd5a1390335b Babu Moger 2023-01-13 1644 * When an Event Configuration is changed, the bandwidth counters
92bd5a1390335b Babu Moger 2023-01-13 1645 * for all RMIDs and Events will be cleared by the hardware. The
92bd5a1390335b Babu Moger 2023-01-13 1646 * hardware also sets MSR_IA32_QM_CTR.Unavailable (bit 62) for
92bd5a1390335b Babu Moger 2023-01-13 1647 * every RMID on the next read to any event for every RMID.
92bd5a1390335b Babu Moger 2023-01-13 1648 * Subsequent reads will have MSR_IA32_QM_CTR.Unavailable (bit 62)
92bd5a1390335b Babu Moger 2023-01-13 1649 * cleared while it is tracked by the hardware. Clear the
92bd5a1390335b Babu Moger 2023-01-13 1650 * mbm_local and mbm_total counts for all the RMIDs.
92bd5a1390335b Babu Moger 2023-01-13 1651 */
92bd5a1390335b Babu Moger 2023-01-13 1652 resctrl_arch_reset_rmid_all(r, d);
92bd5a1390335b Babu Moger 2023-01-13 1653
92bd5a1390335b Babu Moger 2023-01-13 1654 out:
92bd5a1390335b Babu Moger 2023-01-13 @1655 return ret;
92bd5a1390335b Babu Moger 2023-01-13 1656 }
92bd5a1390335b Babu Moger 2023-01-13 1657
:::::: The code at line 1621 was first introduced by commit
:::::: 92bd5a1390335bb3cc76bdf1b4356edbc94d408d x86/resctrl: Add interface to write mbm_total_bytes_config
:::::: TO: Babu Moger <babu.moger@amd.com>
:::::: CC: Borislav Petkov (AMD) <bp@alien8.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-01-24 10:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 10:31 kernel test robot [this message]
2024-01-24 10:55 ` [tip:x86/cache 3/3] arch/x86/kernel/cpu/resctrl/rdtgroup.c:1621:5-8: Unneeded variable: "ret". Return " 0" on line 1655 Borislav Petkov
2024-01-24 14:58 ` Moger, Babu
2024-01-24 16:00 ` Borislav Petkov
2024-01-24 17:52 ` [PATCH] x86/resctrl: Fix unneeded variable warning reported by kernel test robot Babu Moger
2024-01-24 18:25 ` Reinette Chatre
2024-01-24 18:31 ` Borislav Petkov
2024-01-24 18:51 ` Reinette Chatre
2024-01-24 19:14 ` Borislav Petkov
2024-01-24 19:39 ` Moger, Babu
2024-01-24 20:48 ` Borislav Petkov
2024-01-24 20:04 ` Reinette Chatre
2024-01-24 20:45 ` Borislav Petkov
2024-01-24 21:31 ` Reinette Chatre
2024-01-24 22:46 ` Borislav Petkov
2024-01-24 23:03 ` Reinette Chatre
2024-01-24 23:34 ` Borislav Petkov
2024-01-24 23:41 ` Borislav Petkov
2024-01-25 0:12 ` Reinette Chatre
2024-01-24 23:50 ` [tip: x86/cache] x86/resctrl: Remove redundant variable in mbm_config_write_domain() tip-bot2 for Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401241810.jbd8Ipa1-lkp@intel.com \
--to=lkp@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.