All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sandeep C S <sandeep.cs@samsung.com>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: gaudium.lee@samsung.com, ih0923.kim@samsung.com,
	suhyun_.kim@samsung.com, jitender.s21@samsung.com,
	junwan.cho@samsung.com, sandeep.cs@samsung.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [HID Patchsets for Samsung driver v4 1/6] HID Samsung : Broaden device compatibility in samsung driver.
Date: Thu, 25 Jan 2024 10:06:24 +0530	[thread overview]
Message-ID: <20240125043630.4031634-2-sandeep.cs@samsung.com> (raw)
In-Reply-To: <20240125043630.4031634-1-sandeep.cs@samsung.com>

The USB validation check has been moved wherever its required.

Earlier Samsung driver only handles USB HID devices and returns an error if it encounters a Bluetooth type of HID device.
This changes improves driver compatibility and extends its support for a wide range of devices.

Signed-off-by: Sandeep C S <sandeep.cs@samsung.com>
Signed-off-by: Junwan Cho <junwan.cho@samsung.com>
Signed-off-by: Jitender Sajwan <jitender.s21@samsung.com>
---
 drivers/hid/hid-samsung.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
index cf5992e97094..3a8756232731 100644
--- a/drivers/hid/hid-samsung.c
+++ b/drivers/hid/hid-samsung.c
@@ -128,7 +128,7 @@ static int samsung_kbd_mouse_input_mapping(struct hid_device *hdev,
 static __u8 *samsung_report_fixup(struct hid_device *hdev, __u8 *rdesc,
 	unsigned int *rsize)
 {
-	if (USB_DEVICE_ID_SAMSUNG_IR_REMOTE == hdev->product)
+	if (USB_DEVICE_ID_SAMSUNG_IR_REMOTE == hdev->product && hid_is_usb(hdev))
 		rdesc = samsung_irda_report_fixup(hdev, rdesc, rsize);
 	return rdesc;
 }
@@ -139,7 +139,7 @@ static int samsung_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 {
 	int ret = 0;
 
-	if (USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE == hdev->product)
+	if (USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE == hdev->product && hid_is_usb(hdev))
 		ret = samsung_kbd_mouse_input_mapping(hdev,
 			hi, field, usage, bit, max);
 
@@ -152,9 +152,6 @@ static int samsung_probe(struct hid_device *hdev,
 	int ret;
 	unsigned int cmask = HID_CONNECT_DEFAULT;
 
-	if (!hid_is_usb(hdev))
-		return -EINVAL;
-
 	ret = hid_parse(hdev);
 	if (ret) {
 		hid_err(hdev, "parse failed\n");
@@ -162,6 +159,10 @@ static int samsung_probe(struct hid_device *hdev,
 	}
 
 	if (USB_DEVICE_ID_SAMSUNG_IR_REMOTE == hdev->product) {
+		if (!hid_is_usb(hdev)) {
+			ret = -EINVAL;
+			goto err_free;
+		}
 		if (hdev->rsize == 184) {
 			/* disable hidinput, force hiddev */
 			cmask = (cmask & ~HID_CONNECT_HIDINPUT) |
-- 
2.34.1


  parent reply	other threads:[~2024-01-25  4:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240125043646epcas5p1d599fecff0fc37926295fc5260a80682@epcas5p1.samsung.com>
2024-01-25  4:36 ` [HID Patchsets for Samsung driver v4 0/6] Patchsets for Samsung driver Sandeep C S
     [not found]   ` <CGME20240125043654epcas5p10aa2da156c494bbaebd0bd63a37c87aa@epcas5p1.samsung.com>
2024-01-25  4:36     ` Sandeep C S [this message]
     [not found]   ` <CGME20240125043702epcas5p33d9ef989dc51276185972d4517ba80fd@epcas5p3.samsung.com>
2024-01-25  4:36     ` [HID Patchsets for Samsung driver v4 2/6] HID: Samsung : Fix the checkpatch complain. Rewritten code using memcmp where applicable Sandeep C S
2024-01-25 21:54       ` Joe Perches
     [not found]   ` <CGME20240125043713epcas5p29fff47db75cec104be21265031128bf4@epcas5p2.samsung.com>
2024-01-25  4:36     ` [HID Patchsets for Samsung driver v4 3/6] HID: Samsung : Add Samsung wireless keyboard support Sandeep C S
     [not found]   ` <CGME20240125043720epcas5p26d753bd642085849574b82af5c60ecb1@epcas5p2.samsung.com>
2024-01-25  4:36     ` [HID Patchsets for Samsung driver v4 4/6] HID: Samsung : Add Samsung wireless gamepad support Sandeep C S
     [not found]   ` <CGME20240125043727epcas5p2cb925e28e453a870eaa0efa248942f0f@epcas5p2.samsung.com>
2024-01-25  4:36     ` [HID Patchsets for Samsung driver v4 5/6] HID: Samsung : Add Samsung wireless action mouse support Sandeep C S
     [not found]   ` <CGME20240125043736epcas5p3e42a8c2513e9ee271221df2ee5128240@epcas5p3.samsung.com>
2024-01-25  4:36     ` [HID Patchsets for Samsung driver v4 6/6] HID: Samsung : Add Samsung wireless bookcover and universal keyboard support Sandeep C S
2024-01-25  8:24   ` [HID Patchsets for Samsung driver v4 0/6] Patchsets for Samsung driver Jiri Kosina
2024-01-25  9:39     ` sandeep.cs
2024-01-25  9:41     ` sandeep.cs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240125043630.4031634-2-sandeep.cs@samsung.com \
    --to=sandeep.cs@samsung.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=gaudium.lee@samsung.com \
    --cc=ih0923.kim@samsung.com \
    --cc=jikos@kernel.org \
    --cc=jitender.s21@samsung.com \
    --cc=junwan.cho@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suhyun_.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.