From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, andi.shyti@kernel.org, arnd@arndb.de Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, semen.protsenko@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH v2 24/28] spi: s3c64xx: mark fifo_lvl_mask as deprecated Date: Thu, 25 Jan 2024 14:50:02 +0000 [thread overview] Message-ID: <20240125145007.748295-25-tudor.ambarus@linaro.org> (raw) In-Reply-To: <20240125145007.748295-1-tudor.ambarus@linaro.org> The SPI of_alias was used as an index into the fifo_lvl_mask to determine the FIFO depth of the SPI node. Changing the alias ID into the device tree would make the driver choose a wrong FIFO size configuration, if not accessing past the fifo_lvl_mask array boundaries. Not specifying an SPI alias would make the driver fail to probe, which is also wrong. We now have the infrastructure to correctly determine the FIFO size. SoCs that use the same FIFO size across all the instances of the SPI IP shall infer the FIFO size from the compatible, thus by setting ``s3c64xx_spi_port_config.fifosize``. SoCs that have instances of the SPI IP with different FIFO sizes shall specify the FIFO size to each SPI device tree node by using the ``samsung,spi-fifosize`` property. Mark fifo_lvl_mask as deprecated. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 3e7797d915c5..fa70c6aab7c2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -127,7 +127,8 @@ struct s3c64xx_spi_dma_data { /** * struct s3c64xx_spi_port_config - SPI Controller hardware info - * @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register. + * @fifo_lvl_mask: [DEPRECATED] Bit-mask for {TX|RX}_FIFO_LVL bits in + * SPI_STATUS register. * @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter. * @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter. * @clk_div: Internal clock divider @@ -1415,6 +1416,7 @@ static const struct s3c64xx_spi_port_config s3c6410_spi_port_config = { }; static const struct s3c64xx_spi_port_config s5pv210_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7F }, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1423,6 +1425,7 @@ static const struct s3c64xx_spi_port_config s5pv210_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynos4_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7F, 0x7F }, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1433,6 +1436,7 @@ static const struct s3c64xx_spi_port_config exynos4_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynos7_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7F, 0x7F, 0x7F, 0x7F, 0x1ff}, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1443,6 +1447,7 @@ static const struct s3c64xx_spi_port_config exynos7_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynos5433_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7f, 0x7f, 0x7f, 0x7f, 0x1ff}, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1465,6 +1470,7 @@ static const struct s3c64xx_spi_port_config exynos850_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynosautov9_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x1ff, 0x7f, 0x7f, 0x7f, 0x7f, 0x1ff, 0x7f, 0x7f, 0x7f, 0x7f, 0x7f}, .rx_lvl_offset = 15, -- 2.43.0.429.g432eaa2c6b-goog
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, andi.shyti@kernel.org, arnd@arndb.de Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, semen.protsenko@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH v2 24/28] spi: s3c64xx: mark fifo_lvl_mask as deprecated Date: Thu, 25 Jan 2024 14:50:02 +0000 [thread overview] Message-ID: <20240125145007.748295-25-tudor.ambarus@linaro.org> (raw) In-Reply-To: <20240125145007.748295-1-tudor.ambarus@linaro.org> The SPI of_alias was used as an index into the fifo_lvl_mask to determine the FIFO depth of the SPI node. Changing the alias ID into the device tree would make the driver choose a wrong FIFO size configuration, if not accessing past the fifo_lvl_mask array boundaries. Not specifying an SPI alias would make the driver fail to probe, which is also wrong. We now have the infrastructure to correctly determine the FIFO size. SoCs that use the same FIFO size across all the instances of the SPI IP shall infer the FIFO size from the compatible, thus by setting ``s3c64xx_spi_port_config.fifosize``. SoCs that have instances of the SPI IP with different FIFO sizes shall specify the FIFO size to each SPI device tree node by using the ``samsung,spi-fifosize`` property. Mark fifo_lvl_mask as deprecated. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 3e7797d915c5..fa70c6aab7c2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -127,7 +127,8 @@ struct s3c64xx_spi_dma_data { /** * struct s3c64xx_spi_port_config - SPI Controller hardware info - * @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register. + * @fifo_lvl_mask: [DEPRECATED] Bit-mask for {TX|RX}_FIFO_LVL bits in + * SPI_STATUS register. * @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter. * @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter. * @clk_div: Internal clock divider @@ -1415,6 +1416,7 @@ static const struct s3c64xx_spi_port_config s3c6410_spi_port_config = { }; static const struct s3c64xx_spi_port_config s5pv210_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7F }, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1423,6 +1425,7 @@ static const struct s3c64xx_spi_port_config s5pv210_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynos4_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7F, 0x7F }, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1433,6 +1436,7 @@ static const struct s3c64xx_spi_port_config exynos4_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynos7_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7F, 0x7F, 0x7F, 0x7F, 0x1ff}, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1443,6 +1447,7 @@ static const struct s3c64xx_spi_port_config exynos7_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynos5433_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x7f, 0x7f, 0x7f, 0x7f, 0x1ff}, .rx_lvl_offset = 15, .tx_st_done = 25, @@ -1465,6 +1470,7 @@ static const struct s3c64xx_spi_port_config exynos850_spi_port_config = { }; static const struct s3c64xx_spi_port_config exynosautov9_spi_port_config = { + /* fifo_lvl_mask is deprecated. */ .fifo_lvl_mask = { 0x1ff, 0x1ff, 0x7f, 0x7f, 0x7f, 0x7f, 0x1ff, 0x7f, 0x7f, 0x7f, 0x7f, 0x7f}, .rx_lvl_offset = 15, -- 2.43.0.429.g432eaa2c6b-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-25 14:50 UTC|newest] Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-25 14:49 [PATCH v2 00/28] spi: s3c64xx: winter cleanup and gs101 support Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 01/28] spi: s3c64xx: explicitly include <linux/io.h> Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 18:58 ` Sam Protsenko 2024-01-25 18:58 ` Sam Protsenko 2024-01-26 14:40 ` Tudor Ambarus 2024-01-26 14:40 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 02/28] spi: s3c64xx: explicitly include <linux/bits.h> Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 03/28] spi: s3c64xx: avoid possible negative array index Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 18:50 ` Sam Protsenko 2024-01-25 18:50 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 04/28] spi: dt-bindings: samsung: add google,gs101-spi compatible Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 05/28] spi: dt-bindings: samsung: add samsung,spi-fifosize property Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 16:16 ` Mark Brown 2024-01-25 16:16 ` Mark Brown 2024-01-25 16:38 ` Tudor Ambarus 2024-01-25 16:38 ` Tudor Ambarus 2024-01-25 17:26 ` Mark Brown 2024-01-25 17:26 ` Mark Brown 2024-01-25 17:30 ` Tudor Ambarus 2024-01-25 17:30 ` Tudor Ambarus 2024-01-25 17:45 ` Mark Brown 2024-01-25 17:45 ` Mark Brown 2024-01-25 19:01 ` Tudor Ambarus 2024-01-25 19:01 ` Tudor Ambarus 2024-01-30 22:25 ` Rob Herring 2024-01-30 22:25 ` Rob Herring 2024-02-05 9:42 ` Tudor Ambarus 2024-02-05 9:42 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 06/28] spi: s3c64xx: sort headers alphabetically Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 07/28] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 19:04 ` Sam Protsenko 2024-01-25 19:04 ` Sam Protsenko 2024-01-26 8:24 ` Tudor Ambarus 2024-01-26 8:24 ` Tudor Ambarus 2024-01-26 19:40 ` Sam Protsenko 2024-01-26 19:40 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 08/28] spi: s3c64xx: remove else after return Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 09/28] spi: s3c64xx: use bitfield access macros Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 19:50 ` Sam Protsenko 2024-01-25 19:50 ` Sam Protsenko 2024-01-26 8:49 ` Tudor Ambarus 2024-01-26 8:49 ` Tudor Ambarus 2024-01-26 19:55 ` Sam Protsenko 2024-01-26 19:55 ` Sam Protsenko 2024-01-26 16:01 ` Tudor Ambarus 2024-01-26 16:01 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 10/28] spi: s3c64xx: use full mask for {RX, TX}_FIFO_LVL Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:03 ` Sam Protsenko 2024-01-25 20:03 ` Sam Protsenko 2024-01-25 21:48 ` Mark Brown 2024-01-25 21:48 ` Mark Brown 2024-01-26 8:51 ` Tudor Ambarus 2024-01-26 8:51 ` Tudor Ambarus 2024-01-26 8:12 ` Tudor Ambarus 2024-01-26 8:12 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 11/28] spi: s3c64xx: move common code outside if else Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:09 ` Sam Protsenko 2024-01-25 20:09 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 12/28] spi: s3c64xx: check return code of dmaengine_slave_config() Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:19 ` Sam Protsenko 2024-01-25 20:19 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 13/28] spi: s3c64xx: propagate the dma_submit_error() error code Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:23 ` Sam Protsenko 2024-01-25 20:23 ` Sam Protsenko 2024-01-26 7:42 ` Tudor Ambarus 2024-01-26 7:42 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 14/28] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:24 ` Sam Protsenko 2024-01-25 20:24 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 15/28] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:30 ` Sam Protsenko 2024-01-25 20:30 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 16/28] spi: s3c64xx: simplify s3c64xx_wait_for_pio() Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:43 ` Sam Protsenko 2024-01-25 20:43 ` Sam Protsenko 2024-01-26 7:56 ` Tudor Ambarus 2024-01-26 7:56 ` Tudor Ambarus 2024-01-26 19:31 ` Sam Protsenko 2024-01-26 19:31 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 17/28] spi: s3c64xx: drop blank line between declarations Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:38 ` Sam Protsenko 2024-01-25 20:38 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 18/28] spi: s3c64xx: fix typo, s/configuartion/configuration Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:39 ` Sam Protsenko 2024-01-25 20:39 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 19/28] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 20:40 ` Sam Protsenko 2024-01-25 20:40 ` Sam Protsenko 2024-01-25 14:49 ` [PATCH v2 20/28] spi: s3c64xx: add support for inferring fifosize from the compatible Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 14:49 ` [PATCH v2 21/28] spi: s3c64xx: infer " Tudor Ambarus 2024-01-25 14:49 ` Tudor Ambarus 2024-01-25 17:18 ` Mark Brown 2024-01-25 17:18 ` Mark Brown 2024-01-25 18:44 ` Tudor Ambarus 2024-01-25 18:44 ` Tudor Ambarus 2024-01-25 22:28 ` Sam Protsenko 2024-01-25 22:28 ` Sam Protsenko 2024-01-26 7:27 ` Tudor Ambarus 2024-01-26 7:27 ` Tudor Ambarus 2024-01-25 14:50 ` [PATCH v2 22/28] spi: s3c64xx: drop dependency on of_alias where possible Tudor Ambarus 2024-01-25 14:50 ` Tudor Ambarus 2024-01-25 14:50 ` [PATCH v2 23/28] spi: s3c64xx: retrieve the FIFO size from the device tree Tudor Ambarus 2024-01-25 14:50 ` Tudor Ambarus 2024-01-25 17:33 ` Mark Brown 2024-01-25 17:33 ` Mark Brown 2024-01-26 19:23 ` Sam Protsenko 2024-01-26 19:23 ` Sam Protsenko 2024-01-26 20:16 ` Arnd Bergmann 2024-01-26 20:16 ` Arnd Bergmann 2024-01-26 20:20 ` Sam Protsenko 2024-01-26 20:20 ` Sam Protsenko 2024-02-05 9:54 ` Tudor Ambarus 2024-02-05 9:54 ` Tudor Ambarus 2024-01-26 21:19 ` Mark Brown 2024-01-26 21:19 ` Mark Brown 2024-01-25 14:50 ` Tudor Ambarus [this message] 2024-01-25 14:50 ` [PATCH v2 24/28] spi: s3c64xx: mark fifo_lvl_mask as deprecated Tudor Ambarus 2024-01-25 14:50 ` [PATCH v2 25/28] asm-generic/io.h: add iowrite{8,16}_32 accessors Tudor Ambarus 2024-01-25 14:50 ` Tudor Ambarus 2024-01-25 17:41 ` Mark Brown 2024-01-25 17:41 ` Mark Brown 2024-01-25 21:23 ` Arnd Bergmann 2024-01-25 21:23 ` Arnd Bergmann 2024-01-26 7:21 ` Tudor Ambarus 2024-01-26 7:21 ` Tudor Ambarus 2024-01-25 14:50 ` [PATCH v2 26/28] spi: s3c64xx: add iowrite{8,16}_32_rep accessors Tudor Ambarus 2024-01-25 14:50 ` Tudor Ambarus 2024-01-25 14:50 ` [PATCH v2 27/28] spi: s3c64xx: add support for google,gs101-spi Tudor Ambarus 2024-01-25 14:50 ` Tudor Ambarus 2024-01-25 20:45 ` Sam Protsenko 2024-01-25 20:45 ` Sam Protsenko 2024-01-25 14:50 ` [PATCH v2 28/28] MAINTAINERS: add Tudor Ambarus as R for the samsung SPI driver Tudor Ambarus 2024-01-25 14:50 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240125145007.748295-25-tudor.ambarus@linaro.org \ --to=tudor.ambarus@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andi.shyti@kernel.org \ --cc=andre.draszik@linaro.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=robh+dt@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.