All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: kernel-dev@igalia.com, alexander.deucher@amd.com,
	christian.koenig@amd.com, "Simon Ser" <contact@emersion.fr>,
	"Pekka Paalanen" <ppaalanen@gmail.com>,
	daniel@ffwll.ch, "Daniel Stone" <daniel@fooishbar.org>,
	"'Marek Olšák'" <maraeo@gmail.com>,
	"Dave Airlie" <airlied@gmail.com>,
	ville.syrjala@linux.intel.com,
	"Xaver Hugl" <xaver.hugl@gmail.com>,
	"Joshua Ashton" <joshua@froggi.es>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v3 2/3] drm/atomic: Allow userspace to use explicit sync with atomic async flips
Date: Sun, 28 Jan 2024 18:25:14 -0300	[thread overview]
Message-ID: <20240128212515.630345-3-andrealmeid@igalia.com> (raw)
In-Reply-To: <20240128212515.630345-1-andrealmeid@igalia.com>

Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.

Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
v3: new patch

 drivers/gpu/drm/drm_atomic_uapi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 6d5b9fec90c7..edae7924ad69 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1060,7 +1060,8 @@ static int drm_atomic_check_plane_changes(struct drm_property *prop,
 	 * change will be either rejected or ignored, so we can stop the check
 	 * here
 	 */
-	if (prop != config->prop_fb_id) {
+	if (prop != config->prop_fb_id &&
+	    prop != config->prop_in_fence_fd) {
 		ret = drm_atomic_plane_get_property(plane, plane_state,
 						    prop, &old_val);
 		return drm_atomic_check_prop_changes(ret, old_val, prop_value, prop);
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: "André Almeida" <andrealmeid@igalia.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "André Almeida" <andrealmeid@igalia.com>,
	daniel@ffwll.ch, "'Marek Olšák'" <maraeo@gmail.com>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	"Xaver Hugl" <xaver.hugl@gmail.com>,
	"Pekka Paalanen" <ppaalanen@gmail.com>,
	"Joshua Ashton" <joshua@froggi.es>,
	kernel-dev@igalia.com, alexander.deucher@amd.com,
	"Dave Airlie" <airlied@gmail.com>,
	christian.koenig@amd.com
Subject: [PATCH v3 2/3] drm/atomic: Allow userspace to use explicit sync with atomic async flips
Date: Sun, 28 Jan 2024 18:25:14 -0300	[thread overview]
Message-ID: <20240128212515.630345-3-andrealmeid@igalia.com> (raw)
In-Reply-To: <20240128212515.630345-1-andrealmeid@igalia.com>

Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.

Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
v3: new patch

 drivers/gpu/drm/drm_atomic_uapi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 6d5b9fec90c7..edae7924ad69 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1060,7 +1060,8 @@ static int drm_atomic_check_plane_changes(struct drm_property *prop,
 	 * change will be either rejected or ignored, so we can stop the check
 	 * here
 	 */
-	if (prop != config->prop_fb_id) {
+	if (prop != config->prop_fb_id &&
+	    prop != config->prop_in_fence_fd) {
 		ret = drm_atomic_plane_get_property(plane, plane_state,
 						    prop, &old_val);
 		return drm_atomic_check_prop_changes(ret, old_val, prop_value, prop);
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: "André Almeida" <andrealmeid@igalia.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "André Almeida" <andrealmeid@igalia.com>,
	daniel@ffwll.ch, "'Marek Olšák'" <maraeo@gmail.com>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	"Simon Ser" <contact@emersion.fr>,
	"Xaver Hugl" <xaver.hugl@gmail.com>,
	"Daniel Stone" <daniel@fooishbar.org>,
	"Pekka Paalanen" <ppaalanen@gmail.com>,
	"Joshua Ashton" <joshua@froggi.es>,
	kernel-dev@igalia.com, alexander.deucher@amd.com,
	"Dave Airlie" <airlied@gmail.com>,
	christian.koenig@amd.com, ville.syrjala@linux.intel.com
Subject: [PATCH v3 2/3] drm/atomic: Allow userspace to use explicit sync with atomic async flips
Date: Sun, 28 Jan 2024 18:25:14 -0300	[thread overview]
Message-ID: <20240128212515.630345-3-andrealmeid@igalia.com> (raw)
In-Reply-To: <20240128212515.630345-1-andrealmeid@igalia.com>

Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.

Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
v3: new patch

 drivers/gpu/drm/drm_atomic_uapi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 6d5b9fec90c7..edae7924ad69 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1060,7 +1060,8 @@ static int drm_atomic_check_plane_changes(struct drm_property *prop,
 	 * change will be either rejected or ignored, so we can stop the check
 	 * here
 	 */
-	if (prop != config->prop_fb_id) {
+	if (prop != config->prop_fb_id &&
+	    prop != config->prop_in_fence_fd) {
 		ret = drm_atomic_plane_get_property(plane, plane_state,
 						    prop, &old_val);
 		return drm_atomic_check_prop_changes(ret, old_val, prop_value, prop);
-- 
2.43.0


  parent reply	other threads:[~2024-01-28 21:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 21:25 [PATCH v3 0/3] drm/atomic: Allow drivers to write their own plane check for async André Almeida
2024-01-28 21:25 ` André Almeida
2024-01-28 21:25 ` André Almeida
2024-01-28 21:25 ` [PATCH v3 1/3] drm/atomic: Allow drivers to write their own plane check for async flips André Almeida
2024-01-28 21:25   ` André Almeida
2024-01-28 21:25   ` André Almeida
2024-01-29  8:49   ` Pekka Paalanen
2024-01-29  8:49     ` Pekka Paalanen
2024-01-29  8:49     ` Pekka Paalanen
2024-02-01 18:42     ` André Almeida
2024-01-28 21:25 ` André Almeida [this message]
2024-01-28 21:25   ` [PATCH v3 2/3] drm/atomic: Allow userspace to use explicit sync with atomic " André Almeida
2024-01-28 21:25   ` André Almeida
2024-01-28 21:25 ` [PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes André Almeida
2024-01-28 21:25   ` André Almeida
2024-01-28 21:25   ` André Almeida
2024-01-30 10:56   ` Daniel Vetter
2024-01-30 10:56     ` Daniel Vetter
2024-01-30 10:56     ` Daniel Vetter
2024-01-30 11:02     ` Simon Ser
2024-01-30 11:02       ` Simon Ser
2024-01-30 11:02       ` Simon Ser
2024-02-01 18:45     ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240128212515.630345-3-andrealmeid@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=contact@emersion.fr \
    --cc=daniel@ffwll.ch \
    --cc=daniel@fooishbar.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joshua@froggi.es \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maraeo@gmail.com \
    --cc=michel.daenzer@mailbox.org \
    --cc=ppaalanen@gmail.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=xaver.hugl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.