From: Brett Creeley <brett.creeley@amd.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <shannon.nelson@amd.com>, <brett.creeley@amd.com>
Subject: [PATCH net 0/6] pds_core: Various fixes
Date: Mon, 29 Jan 2024 15:40:29 -0800 [thread overview]
Message-ID: <20240129234035.69802-1-brett.creeley@amd.com> (raw)
This series includes the following changes:
There can be many users of the pds_core's adminq. This includes
pds_core's uses and any clients that depend on it. When the pds_core
device goes through a reset for any reason the adminq is freed
and reconfigured. There are some gaps in the current implementation
that will cause crashes during reset if any of the previously mentioned
users of the adminq attempt to use it after it's been freed.
Issues around how resets are handled, specifically regarding the driver's
error handlers.
Originally these patches were aimed at net-next, but it was requested to
push the fixes patches to net. The original patches can be found here:
https://lore.kernel.org/netdev/20240126174255.17052-1-brett.creeley@amd.com/
Also, the Reviewed-by tags were left in place from net-next reviews as the
patches didn't change.
Brett Creeley (6):
pds_core: Prevent health thread from running during reset/remove
pds_core: Cancel AQ work on teardown
pds_core: Use struct pdsc for the pdsc_adminq_isr private data
pds_core: Prevent race issues involving the adminq
pds_core: Clear BARs on reset
pds_core: Rework teardown/setup flow to be more common
drivers/net/ethernet/amd/pds_core/adminq.c | 64 +++++++++++++++------
drivers/net/ethernet/amd/pds_core/core.c | 46 +++++++++++----
drivers/net/ethernet/amd/pds_core/core.h | 2 +-
drivers/net/ethernet/amd/pds_core/debugfs.c | 4 ++
drivers/net/ethernet/amd/pds_core/dev.c | 16 +++---
drivers/net/ethernet/amd/pds_core/devlink.c | 3 +-
drivers/net/ethernet/amd/pds_core/fw.c | 3 +
drivers/net/ethernet/amd/pds_core/main.c | 26 +++++++--
8 files changed, 124 insertions(+), 40 deletions(-)
--
2.17.1
next reply other threads:[~2024-01-29 23:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 23:40 Brett Creeley [this message]
2024-01-29 23:40 ` [PATCH net 1/6] pds_core: Prevent health thread from running during reset/remove Brett Creeley
2024-01-29 23:40 ` [PATCH net 2/6] pds_core: Cancel AQ work on teardown Brett Creeley
2024-01-29 23:40 ` [PATCH net 3/6] pds_core: Use struct pdsc for the pdsc_adminq_isr private data Brett Creeley
2024-01-29 23:40 ` [PATCH net 4/6] pds_core: Prevent race issues involving the adminq Brett Creeley
2024-01-29 23:40 ` [PATCH net 5/6] pds_core: Clear BARs on reset Brett Creeley
2024-01-29 23:40 ` [PATCH net 6/6] pds_core: Rework teardown/setup flow to be more common Brett Creeley
2024-02-01 2:30 ` [PATCH net 0/6] pds_core: Various fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129234035.69802-1-brett.creeley@amd.com \
--to=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.