From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: daniel.lezcano@linaro.org Cc: miquel.raynal@bootlin.com, rafael@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, support.opensource@diasemi.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, andersson@kernel.org, konrad.dybcio@linaro.org, amitk@kernel.org, thara.gopinath@gmail.com, niklas.soderlund@ragnatech.se, srinivas.pandruvada@linux.intel.com, angelogioacchino.delregno@collabora.com, baolin.wang@linux.alibaba.com, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, d-gole@ti.com, linus.walleij@linaro.org, DLG-Adam.Ward.opensource@dm.renesas.com, error27@gmail.com, heiko@sntech.de, hdegoede@redhat.com, jernej.skrabec@gmail.com, f.fainelli@gmail.com, bchihi@baylibre.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v1 01/18] thermal: core: Change governor name to const char pointer Date: Tue, 30 Jan 2024 12:12:33 +0100 [thread overview] Message-ID: <20240130111250.185718-2-angelogioacchino.delregno@collabora.com> (raw) In-Reply-To: <20240130111250.185718-1-angelogioacchino.delregno@collabora.com> All users are already assigning a const char * to the `governor_name` member of struct thermal_zone_params and to the `name` member of struct thermal_governor. Even if users are technically wrong, it just makes more sense to change this member to be a const char pointer instead of doing the other way around. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- include/linux/thermal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/thermal.h b/include/linux/thermal.h index b7a3deb372fd..65d8f92a9a0d 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -214,7 +214,7 @@ struct thermal_zone_device { * @governor_list: node in thermal_governor_list (in thermal_core.c) */ struct thermal_governor { - char name[THERMAL_NAME_LENGTH]; + const char *name; int (*bind_to_tz)(struct thermal_zone_device *tz); void (*unbind_from_tz)(struct thermal_zone_device *tz); int (*throttle)(struct thermal_zone_device *tz, @@ -226,7 +226,7 @@ struct thermal_governor { /* Structure to define Thermal Zone parameters */ struct thermal_zone_params { - char governor_name[THERMAL_NAME_LENGTH]; + const char *governor_name; /* * a boolean to indicate if the thermal to hwmon sysfs interface -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: daniel.lezcano@linaro.org Cc: miquel.raynal@bootlin.com, rafael@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, support.opensource@diasemi.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, andersson@kernel.org, konrad.dybcio@linaro.org, amitk@kernel.org, thara.gopinath@gmail.com, niklas.soderlund@ragnatech.se, srinivas.pandruvada@linux.intel.com, angelogioacchino.delregno@collabora.com, baolin.wang@linux.alibaba.com, u.kleine-koenig@pengutronix.de, hayashi.kunihiko@socionext.com, d-gole@ti.com, linus.walleij@linaro.org, DLG-Adam.Ward.opensource@dm.renesas.com, error27@gmail.com, heiko@sntech.de, hdegoede@redhat.com, jernej.skrabec@gmail.com, f.fainelli@gmail.com, bchihi@baylibre.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@collabora.com Subject: [PATCH v1 01/18] thermal: core: Change governor name to const char pointer Date: Tue, 30 Jan 2024 12:12:33 +0100 [thread overview] Message-ID: <20240130111250.185718-2-angelogioacchino.delregno@collabora.com> (raw) In-Reply-To: <20240130111250.185718-1-angelogioacchino.delregno@collabora.com> All users are already assigning a const char * to the `governor_name` member of struct thermal_zone_params and to the `name` member of struct thermal_governor. Even if users are technically wrong, it just makes more sense to change this member to be a const char pointer instead of doing the other way around. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- include/linux/thermal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/thermal.h b/include/linux/thermal.h index b7a3deb372fd..65d8f92a9a0d 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -214,7 +214,7 @@ struct thermal_zone_device { * @governor_list: node in thermal_governor_list (in thermal_core.c) */ struct thermal_governor { - char name[THERMAL_NAME_LENGTH]; + const char *name; int (*bind_to_tz)(struct thermal_zone_device *tz); void (*unbind_from_tz)(struct thermal_zone_device *tz); int (*throttle)(struct thermal_zone_device *tz, @@ -226,7 +226,7 @@ struct thermal_governor { /* Structure to define Thermal Zone parameters */ struct thermal_zone_params { - char governor_name[THERMAL_NAME_LENGTH]; + const char *governor_name; /* * a boolean to indicate if the thermal to hwmon sysfs interface -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-30 11:13 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-30 11:12 [PATCH v1 00/18] Thermal: Part 1 - Introduce new structs and registration AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno [this message] 2024-01-30 11:12 ` [PATCH v1 01/18] thermal: core: Change governor name to const char pointer AngeloGioacchino Del Regno 2024-02-01 18:37 ` Rafael J. Wysocki 2024-02-01 18:37 ` Rafael J. Wysocki 2024-02-02 10:01 ` AngeloGioacchino Del Regno 2024-02-02 10:01 ` AngeloGioacchino Del Regno 2024-02-02 18:14 ` Rafael J. Wysocki 2024-02-02 18:14 ` Rafael J. Wysocki 2024-01-30 11:12 ` [PATCH v1 02/18] thermal: Add new structures and thermal_zone_device_register() AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 13:26 ` Geert Uytterhoeven 2024-01-30 13:26 ` Geert Uytterhoeven 2024-02-01 19:24 ` Rafael J. Wysocki 2024-02-01 19:24 ` Rafael J. Wysocki 2024-02-02 8:47 ` Dan Carpenter 2024-02-02 8:47 ` Dan Carpenter 2024-02-02 17:13 ` Rafael J. Wysocki 2024-02-02 17:13 ` Rafael J. Wysocki 2024-02-12 10:41 ` AngeloGioacchino Del Regno 2024-02-12 10:41 ` AngeloGioacchino Del Regno 2024-02-12 11:57 ` Rafael J. Wysocki 2024-02-12 11:57 ` Rafael J. Wysocki 2024-01-30 11:12 ` [PATCH v1 03/18] thermal: Directly use thermal_zone_platform_params for thermal_zone_device AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-31 1:58 ` kernel test robot 2024-01-31 1:58 ` kernel test robot 2024-01-31 11:09 ` kernel test robot 2024-02-01 19:42 ` Rafael J. Wysocki 2024-02-01 19:42 ` Rafael J. Wysocki 2024-02-02 10:04 ` AngeloGioacchino Del Regno 2024-02-02 10:04 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 04/18] thermal/drivers/da9062: Migrate to thermal_zone_device_register() AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 05/18] thermal/drivers/imx: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 06/18] thermal/drivers/rcar: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 13:34 ` Geert Uytterhoeven 2024-01-30 13:34 ` Geert Uytterhoeven 2024-01-30 15:08 ` Niklas Söderlund 2024-01-30 15:08 ` Niklas Söderlund 2024-01-30 11:12 ` [PATCH v1 07/18] thermal/drivers/st: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 08/18] thermal: intel: pch_thermal: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-02-01 19:51 ` Rafael J. Wysocki 2024-02-01 19:51 ` Rafael J. Wysocki 2024-02-02 10:10 ` AngeloGioacchino Del Regno 2024-02-02 10:10 ` AngeloGioacchino Del Regno 2024-02-02 17:44 ` Rafael J. Wysocki 2024-02-02 17:44 ` Rafael J. Wysocki 2024-01-30 11:12 ` [PATCH v1 09/18] thermal: intel: quark_dts: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 10/18] thermal: intel: soc_dts_iosf: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 11/18] thermal: intel: int340x: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 12/18] thermal: int340x: processor: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 13/18] thermal: intel: x86_pkg_temp: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 14/18] thermal/drivers/armada: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 14:11 ` Miquel Raynal 2024-01-30 14:11 ` Miquel Raynal 2024-01-30 11:12 ` [PATCH v1 15/18] thermal/drivers/dove: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 16/18] thermal/drivers/kirkwood: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 17/18] thermal/drivers/spear: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-01-30 11:12 ` [PATCH v1 18/18] thermal/drivers/int340x: " AngeloGioacchino Del Regno 2024-01-30 11:12 ` AngeloGioacchino Del Regno 2024-02-01 18:35 ` [PATCH v1 00/18] Thermal: Part 1 - Introduce new structs and registration Rafael J. Wysocki 2024-02-01 18:35 ` Rafael J. Wysocki 2024-02-02 9:58 ` AngeloGioacchino Del Regno 2024-02-02 9:58 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240130111250.185718-2-angelogioacchino.delregno@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=DLG-Adam.Ward.opensource@dm.renesas.com \ --cc=amitk@kernel.org \ --cc=andersson@kernel.org \ --cc=baolin.wang@linux.alibaba.com \ --cc=bchihi@baylibre.com \ --cc=d-gole@ti.com \ --cc=daniel.lezcano@linaro.org \ --cc=error27@gmail.com \ --cc=f.fainelli@gmail.com \ --cc=festevam@gmail.com \ --cc=hayashi.kunihiko@socionext.com \ --cc=hdegoede@redhat.com \ --cc=heiko@sntech.de \ --cc=jernej.skrabec@gmail.com \ --cc=kernel@collabora.com \ --cc=kernel@pengutronix.de \ --cc=konrad.dybcio@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=lukasz.luba@arm.com \ --cc=miquel.raynal@bootlin.com \ --cc=niklas.soderlund@ragnatech.se \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=srinivas.pandruvada@linux.intel.com \ --cc=support.opensource@diasemi.com \ --cc=thara.gopinath@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.