Re: [PATCH v3 14/24] of: property: add of_graph_get_next_endpoint()

From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Lad,  Prabhakar" <prabhakar.csengg@gmail.com>,
	"Niklas SÃ¶derlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Uwe Kleine-KÃ¶nig" <u.kleine-koenig@pengutronix.de>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Alexander Stein" <alexander.stein@ew.tq-group.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Alexey Brodkin" <abrodkin@synopsys.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Andy Gross" <agross@kernel.org>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"David Airlie" <airlied@gmail.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Emma Anholt" <emma@anholt.net>,
	"Eugen Hristev" <eugen.hristev@collabora.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
	"Helge Deller" <deller@gmx.de>,
	"Hugues Fruchet" <hugues.fruchet@foss.st.com>,
	"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"James Clark" <james.clark@arm.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Liu Ying" <victor.liu@nxp.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Marek Vasut" <marex@denx.de>, "Mark Brown" <broonie@kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Michael Tretter" <m.tretter@pengutronix.de>,
	"Michal Simek" <michal.simek@amd.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Philippe Cornu" <philippe.cornu@foss.st.com>,
	"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Saravana Kannan" <saravanak@google.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sowjanya Komatineni" <skomatineni@nvidia.com>,
	"Stefan Agner" <stefan@agner.ch>,
	"Suzuki K Poulose" <suzuki.poulose@arm.com>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Tim Harvey" <tharvey@gateworks.com>,
	"Todor Tomov" <todor.too@gmail.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"Yannick Fertre" <yannick.fertre@foss.st.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Jessica Zhang" <quic_jesszhan@quicinc.com>,
	"Jonas Karlman" <jonas@kwiboo.se>, "Leo Yan" <leo.yan@linaro.org>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Mike Leach" <mike.leach@linaro.org>,
	"Sam Ravnborg" <sam@ravnborg.org>, "Sean Paul" <sean@poorly.run>,
	"Tom Rix" <trix@redhat.com>,
	coresight@lists.linaro.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-staging@lists.linux.dev,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-tegra@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v3 14/24] of: property: add of_graph_get_next_endpoint()
Date: Wed, 31 Jan 2024 10:07:01 +0100	[thread overview]
Message-ID: <20240131100701.754a95ee@booty> (raw)
In-Reply-To: <874jeu6qhv.wl-kuninori.morimoto.gx@renesas.com>

Hello Kuninori Morimoto,

On Wed, 31 Jan 2024 05:06:36 +0000
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:

> To handle endpoint more intuitive, create of_graph_get_next_endpoint()
> 
> 	of_graph_get_next_endpoint(port1, NULL); // A1
> 	of_graph_get_next_endpoint(port1, A1);   // A2
> 	of_graph_get_next_endpoint(port1, A2);   // NULL

The idea looks good. My only concern is about reusing the
of_graph_get_next_endpoint() name after having removed the old, different
function having the same name. This can be confusing in the first
place to who is used to the old function, and also to anybody rebasing
their patches on top of a new kernel to find their code behaving
differently.

Also, as now we'd have two similar variants of this function, it would
be good if each of them were having a name that clearly identifies in
which way they differ from the other.

So a better name for this function would probably be
of_graph_get_next_port_endpoint() I guess, to clearly differentiate from
of_graph_get_next_device_endpoint().

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com