From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 1/3] drm/i915/bios: bump expected child device size
Date: Wed, 31 Jan 2024 20:48:39 +0200 [thread overview]
Message-ID: <20240131184841.872487-1-jani.nikula@intel.com> (raw)
VBT versions since 256 have an extra byte for EFP index.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 4 +++-
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 5f04e495fd27..2805ad701fe4 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2736,8 +2736,10 @@ parse_general_definitions(struct drm_i915_private *i915)
expected_size = 37;
} else if (i915->display.vbt.version <= 215) {
expected_size = 38;
- } else if (i915->display.vbt.version <= 250) {
+ } else if (i915->display.vbt.version <= 255) {
expected_size = 39;
+ } else if (i915->display.vbt.version <= 256) {
+ expected_size = 40;
} else {
expected_size = sizeof(*child);
BUILD_BUG_ON(sizeof(*child) < 39);
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index a9f44abfc9fc..648934fcd123 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -485,6 +485,7 @@ struct child_device_config {
u8 hdmi_iboost_level:4; /* 196+ */
u8 dp_max_link_rate:3; /* 216+ */
u8 dp_max_link_rate_reserved:5; /* 216+ */
+ u8 efp_index; /* 256+ */
} __packed;
struct bdb_general_definitions {
--
2.39.2
next reply other threads:[~2024-01-31 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 18:48 Jani Nikula [this message]
2024-01-31 18:48 ` [PATCH 2/3] drm/i915/bios: abstract child device size check Jani Nikula
2024-01-31 18:48 ` [PATCH 3/3] drm/i915/bios: abstract child device expected size Jani Nikula
2024-02-01 18:42 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/bios: bump expected child device size Patchwork
2024-02-02 8:50 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/bios: bump expected child device size (rev2) Patchwork
2024-02-02 8:54 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-02-12 16:44 ` [PATCH 1/3] drm/i915/bios: bump expected child device size Matt Roper
2024-02-23 23:21 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/bios: bump expected child device size (rev3) Patchwork
2024-02-23 23:26 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-24 16:04 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131184841.872487-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.