All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: mpatocka@redhat.com, heinzm@redhat.com, xni@redhat.com,
	blazej.kucman@linux.intel.com, agk@redhat.com,
	snitzer@kernel.org, dm-devel@lists.linux.dev, song@kernel.org,
	yukuai3@huawei.com, jbrassow@f14.redhat.com, neilb@suse.de,
	shli@fb.com, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	yukuai1@huaweicloud.com, yi.zhang@huawei.com,
	yangerkun@huawei.com
Subject: [PATCH v5 13/14] dm-raid: fix lockdep waring in "pers->hot_add_disk"
Date: Thu,  1 Feb 2024 17:25:58 +0800	[thread overview]
Message-ID: <20240201092559.910982-14-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20240201092559.910982-1-yukuai1@huaweicloud.com>

From: Yu Kuai <yukuai3@huawei.com>

The lockdep assert is added by commit a448af25becf ("md/raid10: remove
rcu protection to access rdev from conf") in print_conf(). And I didn't
notice that dm-raid is calling "pers->hot_add_disk" without holding
'reconfig_mutex'.

"pers->hot_add_disk" read and write many fields that is protected by
'reconfig_mutex', and raid_resume() already grab the lock in other
contex. Hence fix this problem by protecting "pers->host_add_disk"
with the lock.

Fixes: 9092c02d9435 ("DM RAID: Add ability to restore transiently failed devices on resume")
Fixes: a448af25becf ("md/raid10: remove rcu protection to access rdev from conf")

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/md/dm-raid.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 16d3348abfed..5f78cc19d6f3 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -4077,7 +4077,9 @@ static void raid_resume(struct dm_target *ti)
 		 * Take this opportunity to check whether any failed
 		 * devices are reachable again.
 		 */
+		mddev_lock_nointr(mddev);
 		attempt_restore_of_faulty_devices(rs);
+		mddev_unlock(mddev);
 	}
 
 	if (test_and_clear_bit(RT_FLAG_RS_SUSPENDED, &rs->runtime_flags)) {
-- 
2.39.2


  parent reply	other threads:[~2024-02-01  9:30 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  9:25 [PATCH v5 00/14] dm-raid/md/raid: fix v6.7 regressions Yu Kuai
2024-02-01  9:25 ` [PATCH v5 01/14] md: don't ignore suspended array in md_check_recovery() Yu Kuai
2024-02-16  6:58   ` Xiao Ni
2024-02-18  1:14     ` Yu Kuai
2024-02-18  1:33       ` Xiao Ni
2024-02-18  1:46         ` Yu Kuai
2024-02-18  2:27           ` Xiao Ni
2024-02-18  2:34             ` Yu Kuai
2024-02-18  3:15               ` Xiao Ni
2024-02-18  3:24                 ` Yu Kuai
2024-02-18  5:07                   ` Xiao Ni
2024-02-18  6:22                     ` Yu Kuai
2024-02-18  8:07                       ` Xiao Ni
2024-02-18  8:47                         ` Yu Kuai
2024-02-19  7:10                           ` Xiao Ni
2024-02-19  8:19                             ` Yu Kuai
2024-02-01  9:25 ` [PATCH v5 02/14] md: don't ignore read-only " Yu Kuai
2024-02-01  9:25 ` [PATCH v5 03/14] md: make sure md_do_sync() will set MD_RECOVERY_DONE Yu Kuai
2024-02-18  5:56   ` Xiao Ni
2024-02-18  6:51     ` Yu Kuai
2024-02-18  8:41       ` Xiao Ni
2024-02-18  8:59         ` Yu Kuai
2024-02-01  9:25 ` [PATCH v5 04/14] md: don't register sync_thread for reshape directly Yu Kuai
2024-02-28 12:07   ` Xiao Ni
2024-02-28 12:44     ` Yu Kuai
2024-02-28 12:57       ` Xiao Ni
2024-02-01  9:25 ` [PATCH v5 05/14] md: don't suspend the array for interrupted reshape Yu Kuai
2024-02-29  2:10   ` Xiao Ni
2024-02-29  2:14     ` Yu Kuai
2024-02-01  9:25 ` [PATCH v5 06/14] md: fix missing release of 'active_io' for flush Yu Kuai
2024-02-08  7:47   ` Song Liu
2024-02-01  9:25 ` [PATCH v5 07/14] md: export helpers to stop sync_thread Yu Kuai
2024-02-15 22:27   ` Song Liu
2024-02-18  2:35     ` Yu Kuai
2024-02-01  9:25 ` [PATCH v5 08/14] md: export helper md_is_rdwr() Yu Kuai
2024-02-01  9:25 ` [PATCH v5 09/14] dm-raid: really frozen sync_thread during suspend Yu Kuai
2024-02-18  4:53   ` Xiao Ni
2024-02-18  6:34     ` Yu Kuai
2024-02-19  7:27       ` Xiao Ni
2024-02-19  7:53         ` Yu Kuai
2024-02-19  8:45           ` Xiao Ni
2024-02-01  9:25 ` [PATCH v5 10/14] md/dm-raid: don't call md_reap_sync_thread() directly Yu Kuai
2024-02-01  9:25 ` [PATCH v5 11/14] dm-raid: add a new helper prepare_suspend() in md_personality Yu Kuai
2024-02-01  9:25 ` [PATCH v5 12/14] md/raid456: fix a deadlock for dm-raid456 while io concurrent with reshape Yu Kuai
2024-02-01  9:25 ` Yu Kuai [this message]
2024-02-01  9:25 ` [PATCH v5 14/14] dm-raid: remove mddev_suspend/resume() Yu Kuai
2024-02-03  3:19 ` [PATCH v5 00/14] dm-raid/md/raid: fix v6.7 regressions Benjamin Marzinski
2024-02-04  1:35   ` Yu Kuai
2024-02-04  7:00     ` Yu Kuai
2024-02-05 19:35     ` Benjamin Marzinski
2024-02-06  1:36       ` Yu Kuai
2024-02-06  3:57         ` Benjamin Marzinski
2024-02-06  7:03           ` Yu Kuai
2024-02-08  8:04           ` Song Liu
2024-02-08 23:17             ` Benjamin Marzinski
2024-02-09 22:37               ` Song Liu
2024-02-26  7:58                 ` Su Yue
2024-02-12 22:30 ` Song Liu
2024-02-15 22:24 ` Song Liu
2024-02-16  5:46   ` Benjamin Marzinski
2024-02-18  1:24     ` Yu Kuai
2024-02-19 16:05       ` Benjamin Marzinski
2024-02-20  3:09         ` Yu Kuai
2024-02-22  9:00     ` Yu Kuai
2024-02-28  1:19       ` Benjamin Marzinski
2024-02-28  1:35         ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201092559.910982-14-yukuai1@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=agk@redhat.com \
    --cc=akpm@osdl.org \
    --cc=blazej.kucman@linux.intel.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=heinzm@redhat.com \
    --cc=jbrassow@f14.redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=neilb@suse.de \
    --cc=shli@fb.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.